From: Phillip Potter <phil@philpotter.co.uk>
To: Chen Ni <nichen@iscas.ac.cn>
Cc: linux-kernel@vger.kernel.org, phil@philpotter.co.uk
Subject: Re: [PATCH] cdrom: Remove unnecessary NULL check before unregister_sysctl_table()
Date: Wed, 14 May 2025 22:57:14 +0100 [thread overview]
Message-ID: <aCURuvkmz-fw3Nnp@equinox> (raw)
In-Reply-To: <20250514032139.2317578-1-nichen@iscas.ac.cn>
On Wed, May 14, 2025 at 11:21:39AM +0800, Chen Ni wrote:
> unregister_sysctl_table() checks for NULL pointers internally.
> Remove unneeded NULL check here.
>
> Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
> ---
> drivers/cdrom/cdrom.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/cdrom/cdrom.c b/drivers/cdrom/cdrom.c
> index b163e043c687..21a10552da61 100644
> --- a/drivers/cdrom/cdrom.c
> +++ b/drivers/cdrom/cdrom.c
> @@ -3677,8 +3677,7 @@ static void cdrom_sysctl_register(void)
>
> static void cdrom_sysctl_unregister(void)
> {
> - if (cdrom_sysctl_header)
> - unregister_sysctl_table(cdrom_sysctl_header);
> + unregister_sysctl_table(cdrom_sysctl_header);
> }
>
> #else /* CONFIG_SYSCTL */
> --
> 2.25.1
>
Thank you for the patch, looks good.
Reviewed-by: Phillip Potter <phil@philpotter.co.uk>
I will send on for inclusion upstream.
Regards,
Phil
prev parent reply other threads:[~2025-05-14 21:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-14 3:21 [PATCH] cdrom: Remove unnecessary NULL check before unregister_sysctl_table() Chen Ni
2025-05-14 21:57 ` Phillip Potter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aCURuvkmz-fw3Nnp@equinox \
--to=phil@philpotter.co.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=nichen@iscas.ac.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox