* [PATCH] cdrom: Remove unnecessary NULL check before unregister_sysctl_table()
@ 2025-05-14 3:21 Chen Ni
2025-05-14 21:57 ` Phillip Potter
0 siblings, 1 reply; 2+ messages in thread
From: Chen Ni @ 2025-05-14 3:21 UTC (permalink / raw)
To: phil; +Cc: linux-kernel, Chen Ni
unregister_sysctl_table() checks for NULL pointers internally.
Remove unneeded NULL check here.
Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
---
drivers/cdrom/cdrom.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/cdrom/cdrom.c b/drivers/cdrom/cdrom.c
index b163e043c687..21a10552da61 100644
--- a/drivers/cdrom/cdrom.c
+++ b/drivers/cdrom/cdrom.c
@@ -3677,8 +3677,7 @@ static void cdrom_sysctl_register(void)
static void cdrom_sysctl_unregister(void)
{
- if (cdrom_sysctl_header)
- unregister_sysctl_table(cdrom_sysctl_header);
+ unregister_sysctl_table(cdrom_sysctl_header);
}
#else /* CONFIG_SYSCTL */
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] cdrom: Remove unnecessary NULL check before unregister_sysctl_table()
2025-05-14 3:21 [PATCH] cdrom: Remove unnecessary NULL check before unregister_sysctl_table() Chen Ni
@ 2025-05-14 21:57 ` Phillip Potter
0 siblings, 0 replies; 2+ messages in thread
From: Phillip Potter @ 2025-05-14 21:57 UTC (permalink / raw)
To: Chen Ni; +Cc: linux-kernel, phil
On Wed, May 14, 2025 at 11:21:39AM +0800, Chen Ni wrote:
> unregister_sysctl_table() checks for NULL pointers internally.
> Remove unneeded NULL check here.
>
> Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
> ---
> drivers/cdrom/cdrom.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/cdrom/cdrom.c b/drivers/cdrom/cdrom.c
> index b163e043c687..21a10552da61 100644
> --- a/drivers/cdrom/cdrom.c
> +++ b/drivers/cdrom/cdrom.c
> @@ -3677,8 +3677,7 @@ static void cdrom_sysctl_register(void)
>
> static void cdrom_sysctl_unregister(void)
> {
> - if (cdrom_sysctl_header)
> - unregister_sysctl_table(cdrom_sysctl_header);
> + unregister_sysctl_table(cdrom_sysctl_header);
> }
>
> #else /* CONFIG_SYSCTL */
> --
> 2.25.1
>
Thank you for the patch, looks good.
Reviewed-by: Phillip Potter <phil@philpotter.co.uk>
I will send on for inclusion upstream.
Regards,
Phil
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-05-14 21:57 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-05-14 3:21 [PATCH] cdrom: Remove unnecessary NULL check before unregister_sysctl_table() Chen Ni
2025-05-14 21:57 ` Phillip Potter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox