* Re: [PATCH 1/1] cxl/edac: Fix using wrong repair type to check dram event record
2025-06-20 5:29 [PATCH 1/1] cxl/edac: Fix using wrong repair type to check dram event record Li Ming
@ 2025-06-23 18:13 ` Ira Weiny
2025-06-24 14:38 ` Jonathan Cameron
` (3 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: Ira Weiny @ 2025-06-23 18:13 UTC (permalink / raw)
To: Li Ming, dave, jonathan.cameron, dave.jiang, alison.schofield,
vishal.l.verma, ira.weiny, dan.j.williams, shiju.jose
Cc: linux-cxl, linux-kernel, Li Ming
Li Ming wrote:
> cxl_find_rec_dram() is used to find a DRAM event record based on the
> inputted attributes. Different repair_type of the inputted attributes
> will check the DRAM event record in different ways.
> When EDAC driver is performing a memory rank sparing, it should use
> CXL_RANK_SPARING rather than CXL_BANK_SPARING as repair_type for DRAM
> event record checking.
>
> Fixes: 588ca944c277 ("cxl/edac: Add CXL memory device memory sparing control feature")
> Signed-off-by: Li Ming <ming.li@zohomail.com>
Reviewed-by: Ira Weiny <ira.weiny@intel.com>
[snip]
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH 1/1] cxl/edac: Fix using wrong repair type to check dram event record
2025-06-20 5:29 [PATCH 1/1] cxl/edac: Fix using wrong repair type to check dram event record Li Ming
2025-06-23 18:13 ` Ira Weiny
@ 2025-06-24 14:38 ` Jonathan Cameron
2025-06-24 14:49 ` Shiju Jose
` (2 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: Jonathan Cameron @ 2025-06-24 14:38 UTC (permalink / raw)
To: Li Ming
Cc: dave, dave.jiang, alison.schofield, vishal.l.verma, ira.weiny,
dan.j.williams, shiju.jose, linux-cxl, linux-kernel
On Fri, 20 Jun 2025 13:29:24 +0800
Li Ming <ming.li@zohomail.com> wrote:
> cxl_find_rec_dram() is used to find a DRAM event record based on the
> inputted attributes. Different repair_type of the inputted attributes
> will check the DRAM event record in different ways.
> When EDAC driver is performing a memory rank sparing, it should use
> CXL_RANK_SPARING rather than CXL_BANK_SPARING as repair_type for DRAM
> event record checking.
>
> Fixes: 588ca944c277 ("cxl/edac: Add CXL memory device memory sparing control feature")
> Signed-off-by: Li Ming <ming.li@zohomail.com>
Reviewed-by: Jonathan Cameron <jonathan.cameron@huawei.com>
^ permalink raw reply [flat|nested] 6+ messages in thread* RE: [PATCH 1/1] cxl/edac: Fix using wrong repair type to check dram event record
2025-06-20 5:29 [PATCH 1/1] cxl/edac: Fix using wrong repair type to check dram event record Li Ming
2025-06-23 18:13 ` Ira Weiny
2025-06-24 14:38 ` Jonathan Cameron
@ 2025-06-24 14:49 ` Shiju Jose
2025-06-25 18:17 ` Dave Jiang
2025-06-25 18:56 ` Fan Ni
4 siblings, 0 replies; 6+ messages in thread
From: Shiju Jose @ 2025-06-24 14:49 UTC (permalink / raw)
To: Li Ming, dave@stgolabs.net, Jonathan Cameron,
dave.jiang@intel.com, alison.schofield@intel.com,
vishal.l.verma@intel.com, ira.weiny@intel.com,
dan.j.williams@intel.com
Cc: linux-cxl@vger.kernel.org, linux-kernel@vger.kernel.org
>-----Original Message-----
>From: Li Ming <ming.li@zohomail.com>
>Sent: 20 June 2025 06:29
>To: dave@stgolabs.net; Jonathan Cameron <jonathan.cameron@huawei.com>;
>dave.jiang@intel.com; alison.schofield@intel.com; vishal.l.verma@intel.com;
>ira.weiny@intel.com; dan.j.williams@intel.com; Shiju Jose
><shiju.jose@huawei.com>
>Cc: linux-cxl@vger.kernel.org; linux-kernel@vger.kernel.org; Li Ming
><ming.li@zohomail.com>
>Subject: [PATCH 1/1] cxl/edac: Fix using wrong repair type to check dram event
>record
>
>cxl_find_rec_dram() is used to find a DRAM event record based on the inputted
>attributes. Different repair_type of the inputted attributes will check the DRAM
>event record in different ways.
>When EDAC driver is performing a memory rank sparing, it should use
>CXL_RANK_SPARING rather than CXL_BANK_SPARING as repair_type for DRAM
>event record checking.
>
>Fixes: 588ca944c277 ("cxl/edac: Add CXL memory device memory sparing
>control feature")
>Signed-off-by: Li Ming <ming.li@zohomail.com>
>---
>base-commit: 3c70ec71abdaf4e4fa48cd8fdfbbd864d78235a8 cxl/fixes
Reviewed-by: Shiju Jose <shiju.jose@huawei.com>
>---
> drivers/cxl/core/edac.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/cxl/core/edac.c b/drivers/cxl/core/edac.c index
>d725ee954199..623aaa4439c4 100644
>--- a/drivers/cxl/core/edac.c
>+++ b/drivers/cxl/core/edac.c
>@@ -1323,7 +1323,7 @@ cxl_mem_get_rec_dram(struct cxl_memdev *cxlmd,
> attrbs.bank = ctx->bank;
> break;
> case EDAC_REPAIR_RANK_SPARING:
>- attrbs.repair_type = CXL_BANK_SPARING;
>+ attrbs.repair_type = CXL_RANK_SPARING;
> break;
> default:
> return NULL;
>--
>2.34.1
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH 1/1] cxl/edac: Fix using wrong repair type to check dram event record
2025-06-20 5:29 [PATCH 1/1] cxl/edac: Fix using wrong repair type to check dram event record Li Ming
` (2 preceding siblings ...)
2025-06-24 14:49 ` Shiju Jose
@ 2025-06-25 18:17 ` Dave Jiang
2025-06-25 18:56 ` Fan Ni
4 siblings, 0 replies; 6+ messages in thread
From: Dave Jiang @ 2025-06-25 18:17 UTC (permalink / raw)
To: Li Ming, dave, jonathan.cameron, alison.schofield, vishal.l.verma,
ira.weiny, dan.j.williams, shiju.jose
Cc: linux-cxl, linux-kernel
On 6/19/25 10:29 PM, Li Ming wrote:
> cxl_find_rec_dram() is used to find a DRAM event record based on the
> inputted attributes. Different repair_type of the inputted attributes
> will check the DRAM event record in different ways.
> When EDAC driver is performing a memory rank sparing, it should use
> CXL_RANK_SPARING rather than CXL_BANK_SPARING as repair_type for DRAM
> event record checking.
>
> Fixes: 588ca944c277 ("cxl/edac: Add CXL memory device memory sparing control feature")
> Signed-off-by: Li Ming <ming.li@zohomail.com>
Applied to cxl/fixes. Thanks Ming!
> ---
> base-commit: 3c70ec71abdaf4e4fa48cd8fdfbbd864d78235a8 cxl/fixes
> ---
> drivers/cxl/core/edac.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/cxl/core/edac.c b/drivers/cxl/core/edac.c
> index d725ee954199..623aaa4439c4 100644
> --- a/drivers/cxl/core/edac.c
> +++ b/drivers/cxl/core/edac.c
> @@ -1323,7 +1323,7 @@ cxl_mem_get_rec_dram(struct cxl_memdev *cxlmd,
> attrbs.bank = ctx->bank;
> break;
> case EDAC_REPAIR_RANK_SPARING:
> - attrbs.repair_type = CXL_BANK_SPARING;
> + attrbs.repair_type = CXL_RANK_SPARING;
> break;
> default:
> return NULL;
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH 1/1] cxl/edac: Fix using wrong repair type to check dram event record
2025-06-20 5:29 [PATCH 1/1] cxl/edac: Fix using wrong repair type to check dram event record Li Ming
` (3 preceding siblings ...)
2025-06-25 18:17 ` Dave Jiang
@ 2025-06-25 18:56 ` Fan Ni
4 siblings, 0 replies; 6+ messages in thread
From: Fan Ni @ 2025-06-25 18:56 UTC (permalink / raw)
To: Li Ming
Cc: dave, jonathan.cameron, dave.jiang, alison.schofield,
vishal.l.verma, ira.weiny, dan.j.williams, shiju.jose, linux-cxl,
linux-kernel
On Fri, Jun 20, 2025 at 01:29:24PM +0800, Li Ming wrote:
> cxl_find_rec_dram() is used to find a DRAM event record based on the
> inputted attributes. Different repair_type of the inputted attributes
> will check the DRAM event record in different ways.
> When EDAC driver is performing a memory rank sparing, it should use
> CXL_RANK_SPARING rather than CXL_BANK_SPARING as repair_type for DRAM
> event record checking.
>
> Fixes: 588ca944c277 ("cxl/edac: Add CXL memory device memory sparing control feature")
> Signed-off-by: Li Ming <ming.li@zohomail.com>
> ---
Reviewed-by: Fan Ni <fan.ni@samsung.com>
> base-commit: 3c70ec71abdaf4e4fa48cd8fdfbbd864d78235a8 cxl/fixes
> ---
> drivers/cxl/core/edac.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/cxl/core/edac.c b/drivers/cxl/core/edac.c
> index d725ee954199..623aaa4439c4 100644
> --- a/drivers/cxl/core/edac.c
> +++ b/drivers/cxl/core/edac.c
> @@ -1323,7 +1323,7 @@ cxl_mem_get_rec_dram(struct cxl_memdev *cxlmd,
> attrbs.bank = ctx->bank;
> break;
> case EDAC_REPAIR_RANK_SPARING:
> - attrbs.repair_type = CXL_BANK_SPARING;
> + attrbs.repair_type = CXL_RANK_SPARING;
> break;
> default:
> return NULL;
> --
> 2.34.1
>
--
Fan Ni
^ permalink raw reply [flat|nested] 6+ messages in thread