public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Herbert Xu <herbert@gondor.apana.org.au>
To: Jiri Slaby <jirislaby@kernel.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
	"David S. Miller" <davem@davemloft.net>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Linux Crypto Mailing List <linux-crypto@vger.kernel.org>,
	Vegard Nossum <vegard.nossum@oracle.com>,
	netdev@vger.kernel.org, Eric Biggers <ebiggers@kernel.org>,
	Jakub Kicinski <kuba@kernel.org>
Subject: Re: 6.17 crashes in ipv6 code when booted fips=1 [was: [GIT PULL] Crypto Update for 6.17]
Date: Thu, 2 Oct 2025 19:27:31 +0800	[thread overview]
Message-ID: <aN5ho_VTClL5ai8l@gondor.apana.org.au> (raw)
In-Reply-To: <1a71398e-637f-4aa5-b4c6-0d3502a62a0c@kernel.org>

On Thu, Oct 02, 2025 at 12:57:11PM +0200, Jiri Slaby wrote:
>
> Anyway, cherry-picking this -next commit onto 6.17 works as well (the code
> uses now crypto_lib's sha1, not crypto's):
> commit 095928e7d80186c524013a5b5d54889fa2ec1eaa
> Author: Eric Biggers <ebiggers@kernel.org>
> Date:   Sat Aug 23 21:36:43 2025 -0400
> 
>     ipv6: sr: Use HMAC-SHA1 and HMAC-SHA256 library functions
> 
> 
> I don't know what to do next -- should it be put into 6.17 stable later and
> we are done?

Yes that works too.  But it's basically the same as reverting
the patch from Vegard since it makes the code use SHA1 again
even though we told it not too.

Perhaps we should just revert Vegard's change? Since it's kind
of pointless now that people are just using the underlying SHA1
algorithm directly through lib/crypto.

Cheers,
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

  reply	other threads:[~2025-10-02 11:27 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-29 11:07 [GIT PULL] Crypto Update for 6.17 Herbert Xu
2025-07-31 17:54 ` pr-tracker-bot
2025-10-02  8:10 ` Jiri Slaby
2025-10-02  9:30   ` Herbert Xu
2025-10-02 10:05     ` Jiri Slaby
2025-10-02 10:13       ` Jiri Slaby
2025-10-02 10:57         ` 6.17 crashes in ipv6 code when booted fips=1 [was: [GIT PULL] Crypto Update for 6.17] Jiri Slaby
2025-10-02 11:27           ` Herbert Xu [this message]
2025-10-02 11:30           ` Vegard Nossum
2025-10-02 17:23             ` Eric Biggers
2025-10-06 11:53               ` Vegard Nossum
2025-10-06 16:12                 ` Eric Biggers
2025-10-06 16:19                 ` Linus Torvalds
2025-10-06 16:32                   ` Vegard Nossum
2025-10-06 17:11                     ` Linus Torvalds
2025-10-06 19:11                       ` Vegard Nossum
2025-10-06 19:26                         ` Eric Biggers
2025-10-06 19:45                           ` Simo Sorce
2025-10-08 12:13                             ` Theodore Ts'o
2025-10-08 16:15                               ` Linus Torvalds
2025-10-06 20:09                           ` Vegard Nossum
2025-10-06 19:29                         ` Linus Torvalds

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aN5ho_VTClL5ai8l@gondor.apana.org.au \
    --to=herbert@gondor.apana.org.au \
    --cc=davem@davemloft.net \
    --cc=ebiggers@kernel.org \
    --cc=jirislaby@kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    --cc=vegard.nossum@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox