public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Vegard Nossum <vegard.nossum@oracle.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Eric Biggers <ebiggers@kernel.org>,
	Jiri Slaby <jirislaby@kernel.org>,
	Herbert Xu <herbert@gondor.apana.org.au>,
	"David S. Miller" <davem@davemloft.net>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Linux Crypto Mailing List <linux-crypto@vger.kernel.org>,
	netdev@vger.kernel.org, Jakub Kicinski <kuba@kernel.org>,
	Theodore Ts'o <tytso@mit.edu>,
	"nstange@suse.de" <nstange@suse.de>,
	"Wang, Jay" <wanjay@amazon.com>
Subject: Re: 6.17 crashes in ipv6 code when booted fips=1 [was: [GIT PULL] Crypto Update for 6.17]
Date: Mon, 6 Oct 2025 21:11:41 +0200	[thread overview]
Message-ID: <e1dc974a-eb36-4090-8d5f-debcb546ccb7@oracle.com> (raw)
In-Reply-To: <CAHk-=whzJ1Bcx5Yi5JC57pLsJYuApTwpC=WjNi28GLUv7HPCOQ@mail.gmail.com>


On 06/10/2025 18:19, Linus Torvalds wrote:
> I think the other way of writing that is "fips=1 is and will remain 
> irrelevant in the real world as long as it's that black-and-white".

On 06/10/2025 19:11, Linus Torvalds wrote:
> On Mon, 6 Oct 2025 at 09:32, Vegard Nossum <vegard.nossum@oracle.com> wrote:
>>
>> Okay, so I get that we don't like fips=1 around here (I'm not a
>> particularly big fan myself), but what's with the snark? fips=1 exists
>> in mainline and obviously has users. I'm just trying to make sure it
>> remains useful and usable.
> 
> It literally caused non-bootable machines because of that allegedly
> "remains useful and usable" because it changed something that never
> failed to failing. That's how this thread started.
> 
> So that's why the snark. I think you are deluding yourself and others
> if you call that "useful and usable".

Yes, thank you, I've already acknowledged that my patch caused boot
failures and I apologize for that unintentional breakage. Why does this
mean we should throw fips=1 in the bin, though? That's a total non sequitur.

The fact is that fips=1 is not useful if it doesn't actually result
something that complies with the standard; the only purpose of fips=1 is
to allow the kernel to be used and certified as a FIPS module. But as
SHA-1 is still allowed for now, please go ahead and revert my patch,
it's commit 9d50a25eeb05c.


Vegard

  reply	other threads:[~2025-10-06 19:12 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-29 11:07 [GIT PULL] Crypto Update for 6.17 Herbert Xu
2025-07-31 17:54 ` pr-tracker-bot
2025-10-02  8:10 ` Jiri Slaby
2025-10-02  9:30   ` Herbert Xu
2025-10-02 10:05     ` Jiri Slaby
2025-10-02 10:13       ` Jiri Slaby
2025-10-02 10:57         ` 6.17 crashes in ipv6 code when booted fips=1 [was: [GIT PULL] Crypto Update for 6.17] Jiri Slaby
2025-10-02 11:27           ` Herbert Xu
2025-10-02 11:30           ` Vegard Nossum
2025-10-02 17:23             ` Eric Biggers
2025-10-06 11:53               ` Vegard Nossum
2025-10-06 16:12                 ` Eric Biggers
2025-10-06 16:19                 ` Linus Torvalds
2025-10-06 16:32                   ` Vegard Nossum
2025-10-06 17:11                     ` Linus Torvalds
2025-10-06 19:11                       ` Vegard Nossum [this message]
2025-10-06 19:26                         ` Eric Biggers
2025-10-06 19:45                           ` Simo Sorce
2025-10-08 12:13                             ` Theodore Ts'o
2025-10-08 16:15                               ` Linus Torvalds
2025-10-06 20:09                           ` Vegard Nossum
2025-10-06 19:29                         ` Linus Torvalds

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e1dc974a-eb36-4090-8d5f-debcb546ccb7@oracle.com \
    --to=vegard.nossum@oracle.com \
    --cc=davem@davemloft.net \
    --cc=ebiggers@kernel.org \
    --cc=herbert@gondor.apana.org.au \
    --cc=jirislaby@kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=nstange@suse.de \
    --cc=torvalds@linux-foundation.org \
    --cc=tytso@mit.edu \
    --cc=wanjay@amazon.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox