[PATCH] drm/sitronix/st7571-i2c: reset position before clearing display

[PATCH] drm/sitronix/st7571-i2c: reset position before clearing display

[Marcus Folkesson]

We cannot know where the write pointer is, always reset position to
(0,0) before clearing display.

Signed-off-by: Marcus Folkesson <marcus.folkesson@gmail.com>
---
 drivers/gpu/drm/sitronix/st7571-i2c.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/sitronix/st7571-i2c.c b/drivers/gpu/drm/sitronix/st7571-i2c.c
index a6c4a6738dedf5881328414e9d8810d3af2a6fe4..32b91d65b768b26caa7dcef42a00d36f236fbc32 100644
--- a/drivers/gpu/drm/sitronix/st7571-i2c.c
+++ b/drivers/gpu/drm/sitronix/st7571-i2c.c
@@ -263,6 +263,7 @@ static int st7571_fb_clear_screen(struct st7571_device *st7571)
 	u32 npixels = st7571->ncols * round_up(st7571->nlines, ST7571_PAGE_HEIGHT) * st7571->bpp;
 	char pixelvalue = 0x00;
 
+	st7571_set_position(st7571, 0, 0);
 	for (int i = 0; i < npixels; i++)
 		regmap_bulk_write(st7571->regmap, ST7571_DATA_MODE, &pixelvalue, 1);
 

---
base-commit: 91494dee1091a14d91da6bcb39e12a907765c793
change-id: 20250911-st7571-reset-785838285415

Best regards,
-- 
Marcus Folkesson <marcus.folkesson@gmail.com>

Re: [PATCH] drm/sitronix/st7571-i2c: reset position before clearing display

[Javier Martinez Canillas]

Marcus Folkesson <marcus.folkesson@gmail.com> writes:

> We cannot know where the write pointer is, always reset position to
> (0,0) before clearing display.
>
> Signed-off-by: Marcus Folkesson <marcus.folkesson@gmail.com>
> ---

Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>

Marcus, do you already have commit rights in drm-misc or do you want me to
apply this patch ?

-- 
Best regards,

Javier Martinez Canillas
Core Platforms
Red Hat

Re: [PATCH] drm/sitronix/st7571-i2c: reset position before clearing display

[Marcus Folkesson]

[-- Attachment #1: Type: text/plain, Size: 749 bytes --]

Hello Javier,

On Wed, Sep 17, 2025 at 11:32:05AM +0200, Javier Martinez Canillas wrote:
> Marcus Folkesson <marcus.folkesson@gmail.com> writes:
> 
> > We cannot know where the write pointer is, always reset position to
> > (0,0) before clearing display.
> >
> > Signed-off-by: Marcus Folkesson <marcus.folkesson@gmail.com>
> > ---
> 
> Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>
> 
> Marcus, do you already have commit rights in drm-misc or do you want me to
> apply this patch ?

I sent a request for commit rights yesterday, once it is approved I will
apply this patch myself :-)


> 
> -- 
> Best regards,
> 
> Javier Martinez Canillas
> Core Platforms
> Red Hat
> 

Best regards,
Marcus Folkesson

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: [PATCH] drm/sitronix/st7571-i2c: reset position before clearing display

[Javier Martinez Canillas]

Marcus Folkesson <marcus.folkesson@gmail.com> writes:

Hello Marcus,

> Hello Javier,
>
> On Wed, Sep 17, 2025 at 11:32:05AM +0200, Javier Martinez Canillas wrote:
>> Marcus Folkesson <marcus.folkesson@gmail.com> writes:
>> 
>> > We cannot know where the write pointer is, always reset position to
>> > (0,0) before clearing display.
>> >
>> > Signed-off-by: Marcus Folkesson <marcus.folkesson@gmail.com>
>> > ---
>> 
>> Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>
>> 
>> Marcus, do you already have commit rights in drm-misc or do you want me to
>> apply this patch ?
>
> I sent a request for commit rights yesterday, once it is approved I will
> apply this patch myself :-)
>

Sounds good. Thanks!

-- 
Best regards,

Javier Martinez Canillas
Core Platforms
Red Hat

Re: [PATCH] drm/sitronix/st7571-i2c: reset position before clearing display

[Marcus Folkesson]

[-- Attachment #1: Type: text/plain, Size: 1137 bytes --]

Hello Javier,

On Thu, Sep 18, 2025 at 01:07:18PM +0200, Javier Martinez Canillas wrote:
> Marcus Folkesson <marcus.folkesson@gmail.com> writes:
> 
> Hello Marcus,
> 
> > Hello Javier,
> >
> > On Wed, Sep 17, 2025 at 11:32:05AM +0200, Javier Martinez Canillas wrote:
> >> Marcus Folkesson <marcus.folkesson@gmail.com> writes:
> >> 
> >> > We cannot know where the write pointer is, always reset position to
> >> > (0,0) before clearing display.
> >> >
> >> > Signed-off-by: Marcus Folkesson <marcus.folkesson@gmail.com>
> >> > ---
> >> 
> >> Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>
> >> 
> >> Marcus, do you already have commit rights in drm-misc or do you want me to
> >> apply this patch ?
> >
> > I sent a request for commit rights yesterday, once it is approved I will
> > apply this patch myself :-)
> >

It took longer than expected to get commit rights.

Could you please apply this patch so that I could get it of my TODO-list
:-)

> 
> Sounds good. Thanks!
> 
> -- 
> Best regards,
> 
> Javier Martinez Canillas
> Core Platforms
> Red Hat

Thanks,
Marcus Folkesson

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: [PATCH] drm/sitronix/st7571-i2c: reset position before clearing display

[Javier Martinez Canillas]

Marcus Folkesson <marcus.folkesson@gmail.com> writes:

Hello Marcus,

> Hello Javier,
>
> On Thu, Sep 18, 2025 at 01:07:18PM +0200, Javier Martinez Canillas wrote:
>> Marcus Folkesson <marcus.folkesson@gmail.com> writes:
>> 
>> Hello Marcus,
>> 
>> > Hello Javier,
>> >
>> > On Wed, Sep 17, 2025 at 11:32:05AM +0200, Javier Martinez Canillas wrote:
>> >> Marcus Folkesson <marcus.folkesson@gmail.com> writes:
>> >> 
>> >> > We cannot know where the write pointer is, always reset position to
>> >> > (0,0) before clearing display.
>> >> >
>> >> > Signed-off-by: Marcus Folkesson <marcus.folkesson@gmail.com>
>> >> > ---
>> >> 
>> >> Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>
>> >> 
>> >> Marcus, do you already have commit rights in drm-misc or do you want me to
>> >> apply this patch ?
>> >
>> > I sent a request for commit rights yesterday, once it is approved I will
>> > apply this patch myself :-)
>> >
>
> It took longer than expected to get commit rights.
>
> Could you please apply this patch so that I could get it of my TODO-list
> :-)
>

Sure, pushed to drm-misc (drm-misc-next). Thanks!

-- 
Best regards,

Javier Martinez Canillas
Core Platforms
Red Hat