public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Johan Hovold <johan@kernel.org>
To: Oleksandr Suvorov <cryosay@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] USB: serial: ftdi_sio: add device ID for U-Blox EVK-M101
Date: Thu, 30 Oct 2025 10:40:34 +0100	[thread overview]
Message-ID: <aQMykuOFuwi0OTdi@hovoldconsulting.com> (raw)
In-Reply-To: <CAGgjyvFATG4PpHrbWV87tqtLeO3zeM_0508wtATrsxw3s06zVw@mail.gmail.com>

On Thu, Oct 30, 2025 at 09:39:36AM +0200, Oleksandr Suvorov wrote:
> On Wed, Oct 15 2025 at 16:36 Johan Hovold <johan@kernel.org> wrote:

> > > has a USB Type-C port that presents itself as a USB device
> > > (1546:0506) [1] with four attached FTDI serial ports, connected to:
> > > - EVK-M101 current sensors
> > > - EVK-M101 I2C
> > > - EVK-M101 UART
> > > - EVK-M101 port D
> > >
> > > This commit registers U-Blox's VID/PID of this device so that FTDI SIO driver
> > > successfully registers these 4 serial ports.
> >
> > Are you sure you should not just register the UART port? Some FTDI chips
> > support I2C but you'd need a different driver for that.
> 
> Thanks for pointing this out, looks like I should add a custom probe()
> for this device.
> Preparing v2.

Actually, you can just use USB_DEVICE_INTERFACE_NUMBER() in the match
table, no need for a custom probe function.

> > > Datasheet: https://content.u-blox.com/sites/default/files/documents/EVK-M10_UserGuide_UBX-21003949.pdf
> >
> > The user guide also says "Do not use this COM port" for all ports but
> > the UART port.
> 
> Yes, you're right, thanks. It's just not that easy hacking the kernel
> while defending from russian invaders :)

I can only imagine.

Johan

  reply	other threads:[~2025-10-30  9:40 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-26  6:02 [PATCH] USB: serial: ftdi_sio: add device ID for U-Blox EVK-M101 Oleksandr Suvorov
2025-10-14 14:53 ` Johan Hovold
2025-10-30  7:39   ` Oleksandr Suvorov
2025-10-30  9:40     ` Johan Hovold [this message]
2025-10-30  9:00   ` [PATCH v2] usb: serial: ftdi_sio: add support for u-blox EVK-M101 Oleksandr Suvorov
2025-10-30 15:42     ` [PATCH v3] " Oleksandr Suvorov
2025-10-30 16:49       ` Johan Hovold

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aQMykuOFuwi0OTdi@hovoldconsulting.com \
    --to=johan@kernel.org \
    --cc=cryosay@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox