public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Lee Jones <lee@kernel.org>
Cc: Binbin Zhou <zhoubinbin@loongson.cn>,
	linux-kernel@vger.kernel.org, Chong Qiao <qiaochong@loongson.cn>
Subject: Re: [PATCH v2 1/2] mfd: ls2kbmc: Fully convert to use managed resources
Date: Wed, 19 Nov 2025 18:59:44 +0200	[thread overview]
Message-ID: <aR33gIMtB6zCeqdZ@smile.fi.intel.com> (raw)
In-Reply-To: <20251119164703.GU1949330@google.com>

On Wed, Nov 19, 2025 at 04:47:03PM +0000, Lee Jones wrote:
> On Thu, 13 Nov 2025, Andy Shevchenko wrote:
> 
> > The mixing of managed and non-managed resources may lead to possible
> > use-after-free bugs. In this driver the problematic part is the device
> > functionality that may just have gone behind the functions back, e.g.,
> > when interrupt is being served. Fix this by switching to managed resources
> > for PCI.
> > 
> > Fixes: 91a3e1f5453a ("mfd: ls2kbmc: Check for devm_mfd_add_devices() failure")
> > Fixes: d952bba3fbb5 ("mfd: ls2kbmc: Add Loongson-2K BMC reset function support")
> > Reviewed-by: Binbin Zhou <zhoubinbin@loongson.cn>
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > ---
> >  drivers/mfd/ls2k-bmc-core.c | 28 +++++++---------------------
> >  1 file changed, 7 insertions(+), 21 deletions(-)
> 
> Still doesn't apply.  I'm getting lots of conflicts.
> 
> What base are you on?

Linux Next which includes your -fixes branch. You probably need to merge either
it or v6.18-rc6 to the -next. Then the v1 will be okay to apply.

The bottom line is that without doing that we will have conflicts either in
Linux Next followed by merging by Linus or in your branches locally before
going to the above mentioned.

Another possibility is cherry-pick patches from -fixes to -next.

And alternative is to wait for -rc1 and rebase this on top of and
apply then.

> % git --no-pager log --oneline drivers/mfd/ls2k-bmc-core.c
> 3696ac1d0db2 mfd: ls2kbmc: Remove unneeded semicolon from ls2k_bmc_recover_pci_data()
> d952bba3fbb5 mfd: ls2kbmc: Add Loongson-2K BMC reset function support
> 0d64f6d1ffe9 mfd: ls2kbmc: Introduce Loongson-2K BMC core driver

-- 
With Best Regards,
Andy Shevchenko



  reply	other threads:[~2025-11-19 16:59 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-13 16:22 [PATCH v2 0/2] mfd: ls2kbmc: A fix and a refactoring Andy Shevchenko
2025-11-13 16:22 ` [PATCH v2 1/2] mfd: ls2kbmc: Fully convert to use managed resources Andy Shevchenko
2025-11-19 16:47   ` Lee Jones
2025-11-19 16:59     ` Andy Shevchenko [this message]
2025-11-20  8:54       ` Lee Jones
2025-11-20  9:11         ` Andy Shevchenko
2025-11-20 13:39           ` Lee Jones
2025-11-20 13:48             ` Andy Shevchenko
2025-12-14 14:57   ` (subset) " Lee Jones
2025-11-13 16:22 ` [PATCH v2 2/2] mfd: ls2kbmc: Use PCI API instead of direct accesses Andy Shevchenko
2025-12-14 14:57 ` [PATCH v2 0/2] mfd: ls2kbmc: A fix and a refactoring Lee Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aR33gIMtB6zCeqdZ@smile.fi.intel.com \
    --to=andriy.shevchenko@linux.intel.com \
    --cc=lee@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=qiaochong@loongson.cn \
    --cc=zhoubinbin@loongson.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox