From: Troy Mitchell <troy.mitchell@linux.dev>
To: Encrow Thorne <jyc0019@gmail.com>,
Philipp Zabel <p.zabel@pengutronix.de>
Cc: Troy Mitchell <troy.mitchell@linux.dev>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] reset: fix BIT macro reference
Date: Mon, 10 Nov 2025 13:58:24 +0800 [thread overview]
Message-ID: <aRF_APEKXpkOc7z6@kernel.org> (raw)
In-Reply-To: <20251105170006.GA487100@hailin-HP-Pavilion-Laptop-14-dv0xxx>
On Thu, Nov 06, 2025 at 01:00:06AM +0800, Encrow Thorne wrote:
> On Wed, Nov 05, 2025 at 04:51:33PM +0100, Philipp Zabel wrote:
> > On Mi, 2025-11-05 at 23:40 +0800, Encrow Thorne wrote:
> > > RESET_CONTROL_FLAGS_BIT_* macros use BIT(), but reset.h does not
> > > include bits.h or bitops.h. This causes compilation errors when
> > ^^^^^^^^^^^
> > Troy suggested "or bitops.h" can be dropped.
> >
> > > including reset.h standalone.
> > >
> > > Include bits.h to make reset.h self-contained.
> > >
> > > Suggested-by: Troy Mitchell <troy.mitchell@linux.dev>
> > > Reviewed-by: Troy Mitchell <troy.mitchell@linux.dev>
> > > Signed-off-by: Encrow Thorne <jyc0019@gmail.com>
> > > ---
> > > Changes in v2:
> > > - EDITME: describe what is new in this series revision.
> > > - EDITME: use bulletpoints and terse descriptions.
> >
> > These should be replaced with a short description of the changes
> > relative to v1.
> >
> >
> Sorry for the oversight on my side regarding the “Changes in v2” placeholders.
> Do you recommend I resend a corrected v2 now, or wait and include it in a v3?
> Thanks for your guidance.
Send v3 when you are ready.
- Troy
next prev parent reply other threads:[~2025-11-10 5:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-05 15:40 [PATCH v2] reset: fix BIT macro reference Encrow Thorne
2025-11-05 15:51 ` Philipp Zabel
2025-11-05 17:00 ` Encrow Thorne
2025-11-10 5:58 ` Troy Mitchell [this message]
2025-11-05 16:19 ` Troy Mitchell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aRF_APEKXpkOc7z6@kernel.org \
--to=troy.mitchell@linux.dev \
--cc=jyc0019@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox