[PATCH v2] reset: fix BIT macro reference

[PATCH v2] reset: fix BIT macro reference

[Encrow Thorne]

RESET_CONTROL_FLAGS_BIT_* macros use BIT(), but reset.h does not
include bits.h or bitops.h. This causes compilation errors when
including reset.h standalone.

Include bits.h to make reset.h self-contained.

Suggested-by: Troy Mitchell <troy.mitchell@linux.dev>
Reviewed-by: Troy Mitchell <troy.mitchell@linux.dev>
Signed-off-by: Encrow Thorne <jyc0019@gmail.com>
---
Changes in v2:
- EDITME: describe what is new in this series revision.
- EDITME: use bulletpoints and terse descriptions.
- Link to v1: https://lore.kernel.org/r/20251105-rfc-reset-include-bits-v1-1-d7e1bbc7e1ab@gmail.com
---
 include/linux/reset.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/include/linux/reset.h b/include/linux/reset.h
index 840d75d172f6..44f9e3415f92 100644
--- a/include/linux/reset.h
+++ b/include/linux/reset.h
@@ -2,6 +2,7 @@
 #ifndef _LINUX_RESET_H_
 #define _LINUX_RESET_H_
 
+#include <linux/bits.h>
 #include <linux/err.h>
 #include <linux/errno.h>
 #include <linux/types.h>

---
base-commit: 8fec172c82c2b5f6f8e47ab837c1dc91ee3d1b87
change-id: 20251105-rfc-reset-include-bits-4ec72344d1a3

Best regards,
-- 
Encrow Thorne <jyc0019@gmail.com>

Re: [PATCH v2] reset: fix BIT macro reference

[Philipp Zabel]

On Mi, 2025-11-05 at 23:40 +0800, Encrow Thorne wrote:
> RESET_CONTROL_FLAGS_BIT_* macros use BIT(), but reset.h does not
> include bits.h or bitops.h. This causes compilation errors when
                 ^^^^^^^^^^^
Troy suggested "or bitops.h" can be dropped.

> including reset.h standalone.
> 
> Include bits.h to make reset.h self-contained.
> 
> Suggested-by: Troy Mitchell <troy.mitchell@linux.dev>
> Reviewed-by: Troy Mitchell <troy.mitchell@linux.dev>
> Signed-off-by: Encrow Thorne <jyc0019@gmail.com>
> ---
> Changes in v2:
> - EDITME: describe what is new in this series revision.
> - EDITME: use bulletpoints and terse descriptions.

These should be replaced with a short description of the changes
relative to v1.


Otherwise,

Reviewed-by: Philipp Zabel <p.zabel@pengutronix.de>

regards
Philipp

Re: [PATCH v2] reset: fix BIT macro reference

[Encrow Thorne]

On Wed, Nov 05, 2025 at 04:51:33PM +0100, Philipp Zabel wrote:
> On Mi, 2025-11-05 at 23:40 +0800, Encrow Thorne wrote:
> > RESET_CONTROL_FLAGS_BIT_* macros use BIT(), but reset.h does not
> > include bits.h or bitops.h. This causes compilation errors when
>                  ^^^^^^^^^^^
> Troy suggested "or bitops.h" can be dropped.
> 
> > including reset.h standalone.
> > 
> > Include bits.h to make reset.h self-contained.
> > 
> > Suggested-by: Troy Mitchell <troy.mitchell@linux.dev>
> > Reviewed-by: Troy Mitchell <troy.mitchell@linux.dev>
> > Signed-off-by: Encrow Thorne <jyc0019@gmail.com>
> > ---
> > Changes in v2:
> > - EDITME: describe what is new in this series revision.
> > - EDITME: use bulletpoints and terse descriptions.
> 
> These should be replaced with a short description of the changes
> relative to v1.
> 
> 
Sorry for the oversight on my side regarding the “Changes in v2” placeholders.
Do you recommend I resend a corrected v2 now, or wait and include it in a v3?
Thanks for your guidance.

				-Encrow
> Otherwise,
> 
> Reviewed-by: Philipp Zabel <p.zabel@pengutronix.de>
> 
> regards
> Philipp

Re: [PATCH v2] reset: fix BIT macro reference

[Troy Mitchell]

On Thu, Nov 06, 2025 at 01:00:06AM +0800, Encrow Thorne wrote:
> On Wed, Nov 05, 2025 at 04:51:33PM +0100, Philipp Zabel wrote:
> > On Mi, 2025-11-05 at 23:40 +0800, Encrow Thorne wrote:
> > > RESET_CONTROL_FLAGS_BIT_* macros use BIT(), but reset.h does not
> > > include bits.h or bitops.h. This causes compilation errors when
> >                  ^^^^^^^^^^^
> > Troy suggested "or bitops.h" can be dropped.
> > 
> > > including reset.h standalone.
> > > 
> > > Include bits.h to make reset.h self-contained.
> > > 
> > > Suggested-by: Troy Mitchell <troy.mitchell@linux.dev>
> > > Reviewed-by: Troy Mitchell <troy.mitchell@linux.dev>
> > > Signed-off-by: Encrow Thorne <jyc0019@gmail.com>
> > > ---
> > > Changes in v2:
> > > - EDITME: describe what is new in this series revision.
> > > - EDITME: use bulletpoints and terse descriptions.
> > 
> > These should be replaced with a short description of the changes
> > relative to v1.
> > 
> > 
> Sorry for the oversight on my side regarding the “Changes in v2” placeholders.
> Do you recommend I resend a corrected v2 now, or wait and include it in a v3?
> Thanks for your guidance.
Send v3 when you are ready.

          - Troy

Re: [PATCH v2] reset: fix BIT macro reference

[Troy Mitchell]

On Wed, Nov 05, 2025 at 11:40:12PM +0800, Encrow Thorne wrote:
> RESET_CONTROL_FLAGS_BIT_* macros use BIT(), but reset.h does not
> include bits.h or bitops.h. This causes compilation errors when
> including reset.h standalone.
> 
> Include bits.h to make reset.h self-contained.
> 
> Suggested-by: Troy Mitchell <troy.mitchell@linux.dev>
> Reviewed-by: Troy Mitchell <troy.mitchell@linux.dev>
> Signed-off-by: Encrow Thorne <jyc0019@gmail.com>
> ---
> Changes in v2:
> - EDITME: describe what is new in this series revision.
> - EDITME: use bulletpoints and terse descriptions.
> - Link to v1: https://lore.kernel.org/r/20251105-rfc-reset-include-bits-v1-1-d7e1bbc7e1ab@gmail.com
What's that?

    - Troy
> ---
>  include/linux/reset.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/include/linux/reset.h b/include/linux/reset.h
> index 840d75d172f6..44f9e3415f92 100644
> --- a/include/linux/reset.h
> +++ b/include/linux/reset.h
> @@ -2,6 +2,7 @@
>  #ifndef _LINUX_RESET_H_
>  #define _LINUX_RESET_H_
>  
> +#include <linux/bits.h>
>  #include <linux/err.h>
>  #include <linux/errno.h>
>  #include <linux/types.h>
> 
> ---
> base-commit: 8fec172c82c2b5f6f8e47ab837c1dc91ee3d1b87
> change-id: 20251105-rfc-reset-include-bits-4ec72344d1a3
> 
> Best regards,
> -- 
> Encrow Thorne <jyc0019@gmail.com>
>