From: Petr Mladek <pmladek@suse.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: linux-kernel@vger.kernel.org,
Steven Rostedt <rostedt@goodmis.org>,
Rasmus Villemoes <linux@rasmusvillemoes.dk>,
Sergey Senozhatsky <senozhatsky@chromium.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH v2 1/1] lib/vsprintf: Deduplicate special hex number specifier data
Date: Fri, 14 Nov 2025 10:45:47 +0100 [thread overview]
Message-ID: <aRb6S_JjJ5oslKCP@pathway.suse.cz> (raw)
In-Reply-To: <20251113150313.3030700-1-andriy.shevchenko@linux.intel.com>
On Thu 2025-11-13 16:02:59, Andy Shevchenko wrote:
> Two functions use the same specifier data for the special hex number.
> Almost the same as the field width is calculated on the size of the
> given type. Due to that, make a compound literal macro in order to
> deduplicate the rest.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Looks good to me:
Reviewed-by: Petr Mladek <pmladek@suse.com>
Tested-by: Petr Mladek <pmladek@suse.com>
I am going to wait few more days for potential feedback and push
it next Wednesday or so if nobody complained.
Best Regards,
Petr
next prev parent reply other threads:[~2025-11-14 9:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-13 15:02 [PATCH v2 1/1] lib/vsprintf: Deduplicate special hex number specifier data Andy Shevchenko
2025-11-14 9:45 ` Petr Mladek [this message]
2025-11-19 9:22 ` Petr Mladek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aRb6S_JjJ5oslKCP@pathway.suse.cz \
--to=pmladek@suse.com \
--cc=akpm@linux-foundation.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=rostedt@goodmis.org \
--cc=senozhatsky@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox