[PATCH v2] selftests/futex: Fix storing address of local variable

[PATCH v2] selftests/futex: Fix storing address of local variable

[Ankit Khushwaha]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset=8, Size: 1567 bytes --]

In "child_circular_list()" address of local variable ‘lock_struct a’
is assigned to "" raising the following warning.

robust_list.c: In function ‘child_circular_list’:
robust_list.c:522:24: warning: storing the address of local variable ‘a’
in ‘head.list.next’ [-Wdangling-pointer=]

  522 |         head.list.next = &a.list;
      |         ~~~~~~~~~~~~~~~^~~~~~~~~
robust_list.c:513:28: note: ‘a’ declared here
  513 |         struct lock_struct a, b, c;
      |                            ^
robust_list.c:512:40: note: ‘head’ declared here
  512 |         static struct robust_list_head head;
      |                                        ^~~~

removing the static keyword of "head" to fix this.

Signed-off-by: Ankit Khushwaha <ankitkhushwaha.linux@gmail.com>
---
changelog:

v2:
Added changes suggested by André.

v1: https://lore.kernel.org/all/20251118162619.50586-1-ankitkhushwaha.linux@gmail.com/
---
 tools/testing/selftests/futex/functional/robust_list.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/testing/selftests/futex/functional/robust_list.c b/tools/testing/selftests/futex/functional/robust_list.c
index e7d1254e18ca..ef21a7ec9def 100644
--- a/tools/testing/selftests/futex/functional/robust_list.c
+++ b/tools/testing/selftests/futex/functional/robust_list.c
@@ -509,7 +509,7 @@ TEST(test_robust_list_multiple_elements)

 static int child_circular_list(void *arg)
 {
-	static struct robust_list_head head;
+	struct robust_list_head head;
 	struct lock_struct a, b, c;
 	int ret;

--
2.51.1

Re: [PATCH v2] selftests/futex: Fix storing address of local variable

[André Almeida]

Hi Ankit,

Em 18/11/2025 14:08, Ankit Khushwaha escreveu:
> In "child_circular_list()" address of local variable ‘lock_struct a’
> is assigned to "" raising the following warning.
> 
> robust_list.c: In function ‘child_circular_list’:
> robust_list.c:522:24: warning: storing the address of local variable ‘a’
> in ‘head.list.next’ [-Wdangling-pointer=]
> 
>    522 |         head.list.next = &a.list;
>        |         ~~~~~~~~~~~~~~~^~~~~~~~~
> robust_list.c:513:28: note: ‘a’ declared here
>    513 |         struct lock_struct a, b, c;
>        |                            ^
> robust_list.c:512:40: note: ‘head’ declared here
>    512 |         static struct robust_list_head head;
>        |                                        ^~~~
> 
> removing the static keyword of "head" to fix this.
> 

This should be "Remove the static..." as noted in the kernel documentation:

"Describe your changes in imperative mood, e.g. “make xyzzy do frotz” 
instead of “[This patch] makes xyzzy do frotz” or “[I] changed xyzzy to 
do frotz”, as if you are giving orders to the codebase to change its 
behaviour."

Please have a look on this page here: 
https://www.kernel.org/doc/html/latest/process/submitting-patches.html

Re: [PATCH v2] selftests/futex: Fix storing address of local variable

[Ankit Khushwaha]

Hi André,

On Wed, Nov 19, 2025 at 12:28:37PM -0300, André Almeida wrote:
> Hi Ankit,
> 
> This should be "Remove the static..." as noted in the kernel documentation:

Thanks for pointing it out. I forgot to change the patch name according
the changes. I will send v3 patch with correct patch name.

> 
> "Describe your changes in imperative mood, e.g. “make xyzzy do frotz”
> instead of “[This patch] makes xyzzy do frotz” or “[I] changed xyzzy to do
> frotz”, as if you are giving orders to the codebase to change its
> behaviour."
> 
> Please have a look on this page here:
> https://www.kernel.org/doc/html/latest/process/submitting-patches.html

Thanks
-- Ankit