public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@linaro.org>
To: Tomasz Sadowski <tsdwski@gmail.com>
Cc: Dave Penkler <dpenkler@gmail.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] staging: fluke_gpib: use kzalloc instead of kmalloc + memset
Date: Thu, 27 Nov 2025 08:58:16 +0300	[thread overview]
Message-ID: <aSfoeE0y_L0QHXw7@stanley.mountain> (raw)
In-Reply-To: <20251126204838.17767-1-tsdwski@gmail.com>

On Wed, Nov 26, 2025 at 09:45:49PM +0100, Tomasz Sadowski wrote:
> v2:
>  - Add proper commit description
>  - No changes in patch
> 

This stuff needs to go under the --- cut off line.

> Use kzalloc() instead of kmalloc() + memset() to simplify memory allocation.
> 
> Also use sizeof(*board->private_data) instead of repeating the struct name.
> This avoids duplication and keeps the code correct if the struct name
> changes in the future.
> 
> Signed-off-by: Tomasz Sadowski <tsdwski@gmail.com>
> ---
  ^^^

Here.

regards,
dan carpenter


      reply	other threads:[~2025-11-27  5:58 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-26 20:45 [PATCH v2] staging: fluke_gpib: use kzalloc instead of kmalloc + memset Tomasz Sadowski
2025-11-27  5:58 ` Dan Carpenter [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aSfoeE0y_L0QHXw7@stanley.mountain \
    --to=dan.carpenter@linaro.org \
    --cc=dpenkler@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=tsdwski@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox