From: Charles Keepax <ckeepax@opensource.cirrus.com>
To: Haotian Zhang <vulab@iscas.ac.cn>
Cc: lee@kernel.org, ckeepax@opensource.wolfsonmicro.com,
patches@opensource.cirrus.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mfd: arizona: Fix regulator resource leak on wm5102_clear_write_sequencer failure
Date: Mon, 15 Dec 2025 09:23:10 +0000 [thread overview]
Message-ID: <aT/TfpcFedLntO4Z@opensource.cirrus.com> (raw)
In-Reply-To: <20251214145804.2037-1-vulab@iscas.ac.cn>
On Sun, Dec 14, 2025 at 10:58:03PM +0800, Haotian Zhang wrote:
> The wm5102_clear_write_sequencer() helper may return an error
> and just return, bypassing the cleanup sequence and causing
> regulators to remain enabled, leading to a resource leak.
>
> Change the direct return to jump to the err_reset label to
> properly free the resources.
>
> Fixes: 1c1c6bba57f5 ("mfd: wm5102: Ensure we always boot the device fully")
> Signed-off-by: Haotian Zhang <vulab@iscas.ac.cn>
> ---
Reviewed-by: Charles Keepax <ckeepax@opensource.cirrus.com>
Thanks,
Charles
next prev parent reply other threads:[~2025-12-15 9:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-14 14:58 [PATCH] mfd: arizona: Fix regulator resource leak on wm5102_clear_write_sequencer failure Haotian Zhang
2025-12-15 9:23 ` Charles Keepax [this message]
2026-01-08 15:56 ` (subset) " Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aT/TfpcFedLntO4Z@opensource.cirrus.com \
--to=ckeepax@opensource.cirrus.com \
--cc=ckeepax@opensource.wolfsonmicro.com \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@opensource.cirrus.com \
--cc=vulab@iscas.ac.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox