public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "andriy.shevchenko@linux.intel.com" <andriy.shevchenko@linux.intel.com>
To: Jonathan Brophy <J.Brophy@corkillsystems.co.nz>
Cc: "lee@kernel.org" <lee@kernel.org>,
	"linux-leds@vger.kernel.org" <linux-leds@vger.kernel.org>,
	Pavel Machek <pavel@kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v1 1/1] leds: Unexport of_led_get()
Date: Wed, 10 Dec 2025 14:33:35 +0200	[thread overview]
Message-ID: <aTlon6M4Gn0AuXyz@smile.fi.intel.com> (raw)
In-Reply-To: <SYAPR01MB28638039D514AD18AA2B43C3B2A0A@SYAPR01MB2863.ausprd01.prod.outlook.com>

On Wed, Dec 10, 2025 at 10:43:38AM +0000, Jonathan Brophy wrote:
>  [PATCH v1 1/1] leds: Unexport of_led_get()
> 
> it would seem the removal of this function has removed the only way to search
> led phandles the device tree.

Are you talking about upstream drivers that now regressed somehow or is it
about downstream?

> The devm version works functionally different and is not a replacement.
> virtual led grouping drivers are unable to match phandles.
> is there plans to create a fwnode_led_get() replacment for of_led_get ?

When there will be a user that may not call existing APIs.

> The problem is gpio leds don't have fwnode properties so searching by
> platform does not work.

Can you elaborate? I think your downstream code (I have no other ideas
where you Q came from) uses some outdated approaches. Try to look at
the problem from the level of the existing APIs and frameworks. We shouldn't
really have such an issue (but it might be some special use case, I admit).


-- 
With Best Regards,
Andy Shevchenko



  reply	other threads:[~2025-12-10 12:33 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-10 10:43 [PATCH v1 1/1] leds: Unexport of_led_get() Jonathan Brophy
2025-12-10 12:33 ` andriy.shevchenko [this message]
2025-12-10 18:30   ` Jonathan Brophy
2025-12-10 21:54     ` andriy.shevchenko
2025-12-11  0:49       ` Jonathan Brophy
2025-12-11 13:51         ` andriy.shevchenko
2025-12-11 12:34       ` Alexander Dahl
2025-12-11 13:46         ` andriy.shevchenko
  -- strict thread matches above, loose matches on Subject: below --
2025-06-30  9:26 Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aTlon6M4Gn0AuXyz@smile.fi.intel.com \
    --to=andriy.shevchenko@linux.intel.com \
    --cc=J.Brophy@corkillsystems.co.nz \
    --cc=lee@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-leds@vger.kernel.org \
    --cc=pavel@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox