public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "andriy.shevchenko@linux.intel.com" <andriy.shevchenko@linux.intel.com>
To: Jonathan Brophy <J.Brophy@corkillsystems.co.nz>,
	"lee@kernel.org" <lee@kernel.org>,
	"linux-leds@vger.kernel.org" <linux-leds@vger.kernel.org>,
	Pavel Machek <pavel@kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v1 1/1] leds: Unexport of_led_get()
Date: Thu, 11 Dec 2025 15:46:51 +0200	[thread overview]
Message-ID: <aTrLS84EjEGuSXC1@smile.fi.intel.com> (raw)
In-Reply-To: <20251211-plural-generic-c7e78cd51f9d@thorsis.com>

On Thu, Dec 11, 2025 at 01:34:10PM +0100, Alexander Dahl wrote:
> Am Wed, Dec 10, 2025 at 11:54:19PM +0200 schrieb andriy.shevchenko@linux.intel.com:
> > On Wed, Dec 10, 2025 at 06:30:06PM +0000, Jonathan Brophy wrote:
> > > > Can you elaborate? I think your downstream code (I have no other ideas where you Q came from)
> > > > uses some outdated approaches. Try to look at the problem from the level of the existing APIs and 
> > > > frameworks. We shouldn't really have such an issue (but it might be some special use case, I admit).
> > > 
> > > I'm trying to create a virtual led driver but with the removal of
> > > of_led_get() im struggling to find a way to make it work.
> > 
> > Still it's unclear to me what it means and how the code look like.
> > Perhaps you need to send some patches for the discussion (maybe as
> > RFC if you think they are not upstream ready).
> 
> I guess it is about the patch series Jonathan already sent?

I don't know, I wasn't in Cc list there. And it seems the series got a lot of
useful comments already. So. if next version being Cc'ed to me, I would review
it. (Going ahead: the series, if survives the approach, has a lot of style and
related mistakes, like wrong kernel version and data in the ABI documentation.)

> https://lore.kernel.org/linux-leds/20251019092331.49531-1-professorjonny98@gmail.com/T/#u


-- 
With Best Regards,
Andy Shevchenko



  reply	other threads:[~2025-12-11 13:46 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-10 10:43 [PATCH v1 1/1] leds: Unexport of_led_get() Jonathan Brophy
2025-12-10 12:33 ` andriy.shevchenko
2025-12-10 18:30   ` Jonathan Brophy
2025-12-10 21:54     ` andriy.shevchenko
2025-12-11  0:49       ` Jonathan Brophy
2025-12-11 13:51         ` andriy.shevchenko
2025-12-11 12:34       ` Alexander Dahl
2025-12-11 13:46         ` andriy.shevchenko [this message]
  -- strict thread matches above, loose matches on Subject: below --
2025-06-30  9:26 Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aTrLS84EjEGuSXC1@smile.fi.intel.com \
    --to=andriy.shevchenko@linux.intel.com \
    --cc=J.Brophy@corkillsystems.co.nz \
    --cc=lee@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-leds@vger.kernel.org \
    --cc=pavel@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox