The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Andrea Righi <arighi@nvidia.com>
To: Tejun Heo <tj@kernel.org>
Cc: Changwoo Min <changwoo@igalia.com>,
	David Vernet <void@manifault.com>,
	Emil Tsalapatis <emil@etsalapatis.com>,
	linux-kernel@vger.kernel.org, sched-ext@lists.linux.dev
Subject: Re: [PATCHSET sched_ext/for-6.19-fixes] sched_ext: Fix missing post-enqueue handling in move_local_task_to_local_dsq()
Date: Fri, 12 Dec 2025 00:29:31 +0100	[thread overview]
Message-ID: <aTtT22FI5MfSa_xf@gpd4> (raw)
In-Reply-To: <20251211224809.3383633-1-tj@kernel.org>

Hi Tejun,

On Thu, Dec 11, 2025 at 12:48:07PM -1000, Tejun Heo wrote:
> Hello,
> 
> move_local_task_to_local_dsq() was missing post-enqueue handling which
> matters now that scx_bpf_dsq_move() can be called while the CPU is busy.
> 
>  0001-sched_ext-Factor-out-local_dsq_post_enq-from-dispatc.patch
>  0002-sched_ext-Fix-missing-post-enqueue-handling-in-move_.patch

A couple of comments about the commit description, but overall looks good
to me.

Reviewed-by: Andrea Righi <arighi@nvidia.com>

Thanks,
-Andrea

> 
> diffstat:
>  kernel/sched/ext.c | 44 +++++++++++++++++++++++++++++---------------
>  1 file changed, 29 insertions(+), 15 deletions(-)
> 
> --
> tejun

  parent reply	other threads:[~2025-12-11 23:29 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-11 22:48 [PATCHSET sched_ext/for-6.19-fixes] sched_ext: Fix missing post-enqueue handling in move_local_task_to_local_dsq() Tejun Heo
2025-12-11 22:48 ` [PATCH 1/2] sched_ext: Factor out local_dsq_post_enq() from dispatch_enqueue() Tejun Heo
2025-12-11 23:23   ` Andrea Righi
2025-12-11 22:48 ` [PATCH 2/2] sched_ext: Fix missing post-enqueue handling in move_local_task_to_local_dsq() Tejun Heo
2025-12-11 23:27   ` Andrea Righi
2025-12-11 23:35   ` Christian Loehle
2025-12-12  1:34     ` Tejun Heo
2025-12-11 23:29 ` Andrea Righi [this message]
2025-12-12  1:45 ` [PATCHSET v2 sched_ext/for-6.19-fixes] " Tejun Heo
2025-12-12  1:45   ` [PATCH 1/2] sched_ext: Factor out local_dsq_post_enq() from dispatch_enqueue() Tejun Heo
2025-12-12  5:50     ` Emil Tsalapatis
2025-12-12  1:45   ` [PATCH 2/2] sched_ext: Fix missing post-enqueue handling in move_local_task_to_local_dsq() Tejun Heo
2025-12-12  5:57     ` Emil Tsalapatis
2025-12-12 16:28   ` [PATCHSET v2 sched_ext/for-6.19-fixes] " Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aTtT22FI5MfSa_xf@gpd4 \
    --to=arighi@nvidia.com \
    --cc=changwoo@igalia.com \
    --cc=emil@etsalapatis.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sched-ext@lists.linux.dev \
    --cc=tj@kernel.org \
    --cc=void@manifault.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox