From: Thadeu Lima de Souza Cascardo <cascardo@igalia.com>
To: Alper Ak <alperyasinak1@gmail.com>
Cc: arnd@arndb.de, gregkh@linuxfoundation.org,
linux-kernel@vger.kernel.org, kernel test robot <lkp@intel.com>,
Dan Carpenter <dan.carpenter@linaro.org>
Subject: Re: [PATCH] char: misc: Use IS_ERR() for filp_open() return value
Date: Fri, 26 Dec 2025 23:16:32 -0300 [thread overview]
Message-ID: <aU9BgOhtDdahBCKo@quatroqueijos.cascardo.eti.br> (raw)
In-Reply-To: <20251226230248.113073-1-alperyasinak1@gmail.com>
On Sat, Dec 27, 2025 at 02:02:48AM +0300, Alper Ak wrote:
> filp_open() never returns NULL, it returns either a valid pointer or an
> error pointer. Using IS_ERR_OR_NULL() is unnecessary. Additionally, if
> filp were NULL, PTR_ERR(NULL) would return 0, leading to a misleading
> error message.
>
> Fixes: 74d8361be344 ("char: misc: add test cases")
> Reported-by: kernel test robot <lkp@intel.com>
> Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
> Closes: https://lore.kernel.org/r/202506132058.thWZHlrb-lkp@intel.com/
> Signed-off-by: Alper Ak <alperyasinak1@gmail.com>
> ---
> drivers/char/misc_minor_kunit.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/char/misc_minor_kunit.c b/drivers/char/misc_minor_kunit.c
> index 6fc8b05169c5..e930c78e1ef9 100644
> --- a/drivers/char/misc_minor_kunit.c
> +++ b/drivers/char/misc_minor_kunit.c
> @@ -166,7 +166,7 @@ static void __init miscdev_test_can_open(struct kunit *test, struct miscdevice *
> KUNIT_FAIL(test, "failed to create node\n");
>
> filp = filp_open(devname, O_RDONLY, 0);
> - if (IS_ERR_OR_NULL(filp))
> + if (IS_ERR(filp))
> KUNIT_FAIL(test, "failed to open misc device: %ld\n", PTR_ERR(filp));
> else
> fput(filp);
> --
> 2.43.0
>
Acked-by: Thadeu Lima de Souza Cascardo <cascardo@igalia.com>
prev parent reply other threads:[~2025-12-27 2:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-26 9:14 [PATCH] char: misc: Use IS_ERR() for filp_open() return value Alper Ak
2025-12-26 19:12 ` Thadeu Lima de Souza Cascardo
2025-12-26 23:02 ` Alper Ak
2025-12-27 2:16 ` Thadeu Lima de Souza Cascardo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aU9BgOhtDdahBCKo@quatroqueijos.cascardo.eti.br \
--to=cascardo@igalia.com \
--cc=alperyasinak1@gmail.com \
--cc=arnd@arndb.de \
--cc=dan.carpenter@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox