public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Sean Christopherson <seanjc@google.com>
To: Xin Li <xin@zytor.com>
Cc: Ingo Molnar <mingo@kernel.org>,
	LKML <linux-kernel@vger.kernel.org>,  ML X86 <x86@kernel.org>,
	Chao Gao <chao.gao@intel.com>
Subject: Re: Time to drop wrmsrl()/rdmsrl()?
Date: Mon, 15 Dec 2025 12:15:21 -0800	[thread overview]
Message-ID: <aUBsWQw2WGjlEWqH@google.com> (raw)
In-Reply-To: <6CB34103-3BF6-43ED-890A-650429CBC491@zytor.com>

On Mon, Dec 15, 2025, Xin Li wrote:
> Hi Ingo,
> 
> Keeping them around only causes churn now, so probably it is time to drop
> them?

+1, IMO keeping the old APIs is doing far more harm than good at this point.

> https://lore.kernel.org/lkml/aK8fmMGH0rB2LuA9@google.com/
> 
> https://lore.kernel.org/lkml/aR0vK3z1owwM8X8H@intel.com/
> 
> 
> I think all of their uses were changed to wrmsrq()/rdmsrq(), but they are
> coming back, and with the latest Linux 6.19-rc1 tag, I get:
> 
> $git grep -w rdmsrl
> arch/x86/events/amd/uncore.c:   rdmsrl(hwc->event_base, new);
> arch/x86/include/asm/msr.h:#define rdmsrl(msr, val) rdmsrq(msr, val)
> arch/x86/kernel/cpu/resctrl/monitor.c:  rdmsrl(MSR_IA32_QM_CTR, msr_val);
> drivers/hv/mshv_vtl_main.c:                             rdmsrl(reg_table[i].msr_addr, *reg64);
> drivers/idle/intel_idle.c:      rdmsrl(MSR_PKG_CST_CONFIG_CONTROL, msr_val);
> drivers/idle/intel_idle.c:      rdmsrl(MSR_PKG_CST_CONFIG_CONTROL, msr_val);
> 
> 
> Thanks!
>     Xin

      reply	other threads:[~2025-12-15 20:15 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-15  8:27 Time to drop wrmsrl()/rdmsrl()? Xin Li
2025-12-15 20:15 ` Sean Christopherson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aUBsWQw2WGjlEWqH@google.com \
    --to=seanjc@google.com \
    --cc=chao.gao@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=x86@kernel.org \
    --cc=xin@zytor.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox