[PATCH 0/5] Remove MODULE_ALIAS from all mcb client drivers

[PATCH 0/5] Remove MODULE_ALIAS from all mcb client drivers

[Javier Rodriguez]

The first patches I sent for fixing the autoload problem encountered
on mcb device drivers were 2. The first was focused on updating the
modpost process for letting kbuild to access to the data within
MODULE_DEVICE_TABLE and the second one for removing the MODULE_ALIAS
on all mcb client drivers.

They were rejected and Andy suggested me to split the second patch
in a per-driver basis instead of sending all drivers' changes in a
single patch once the first patch was merged.

You can find the messages here:

https://lore.kernel.org/all/CAHp75VfhM5GuYY1qUKgBhePDo4oe5k3K1ZDTPbYJNr5NtjVVfQ@mail.gmail.com/

The first patch is already merged on Linus's Git repository for 6.19-rc4

commit 1f4ea4838b13 ("mcb: Add missing modpost build support")

So now I am sending this patch series for removing MODULE_ALIAS
on all mcb client drivers as it is no longer required.

Jose Javier Rodriguez Barbarin (5):
  gpio: gpio-menz127: drop unneeded MODULE_ALIAS
  serial: men_z135_uart: drop unneeded MODULE_ALIAS
  iio: adc: men_z188_adc: drop unneeded MODULE_ALIAS
  8250_men_mcb: drop unneeded MODULE_ALIAS
  watchdog: menz069_wdt: drop unneeded MODULE_ALIAS

 drivers/gpio/gpio-menz127.c            | 1 -
 drivers/iio/adc/men_z188_adc.c         | 1 -
 drivers/tty/serial/8250/8250_men_mcb.c | 3 ---
 drivers/tty/serial/men_z135_uart.c     | 1 -
 drivers/watchdog/menz69_wdt.c          | 1 -
 5 files changed, 7 deletions(-)

-- 
2.52.0

[PATCH 1/5] gpio: gpio-menz127: drop unneeded MODULE_ALIAS

[Javier Rodriguez]

From: Jose Javier Rodriguez Barbarin <dev-josejavier.rodriguez@duagon.com>

The MODULE_ALIAS() is redundant since the module alias is now
automatically generated from the MODULE_DEVICE_TABLE().

Remove the explicit alias.

No functional change intended.

Fixes: 1f4ea4838b13 ("mcb: Add missing modpost build support")
Reviewed-by: Jorge Sanjuan Garcia <dev-jorge.sanjuangarcia@duagon.com>
Cc: Linus Walleij <linusw@kernel.org>
Cc: Bartosz Golaszewski <brgl@kernel.org>
Cc: Andy Shevchenko <andriy.shevchenko@intel.com>
Cc: linux-gpio@vger.kernel.org
Signed-off-by: Jose Javier Rodriguez Barbarin <dev-josejavier.rodriguez@duagon.com>
---
 drivers/gpio/gpio-menz127.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/gpio/gpio-menz127.c b/drivers/gpio/gpio-menz127.c
index 52b13c6ae496..f51e7517f551 100644
--- a/drivers/gpio/gpio-menz127.c
+++ b/drivers/gpio/gpio-menz127.c
@@ -223,5 +223,4 @@ module_mcb_driver(men_z127_driver);
 MODULE_AUTHOR("Andreas Werner <andreas.werner@men.de>");
 MODULE_DESCRIPTION("MEN GPIO Controller");
 MODULE_LICENSE("GPL v2");
-MODULE_ALIAS("mcb:16z127");
 MODULE_IMPORT_NS("MCB");
-- 
2.52.0

[PATCH 2/5] serial: men_z135_uart: drop unneeded MODULE_ALIAS

[Javier Rodriguez]

From: Jose Javier Rodriguez Barbarin <dev-josejavier.rodriguez@duagon.com>

The MODULE_ALIAS() is redundant since the module alias is now
automatically generated from the MODULE_DEVICE_TABLE().

Remove the explicit alias.

No functional change intended.

Fixes: 1f4ea4838b13 ("mcb: Add missing modpost build support")
Reviewed-by: Jorge Sanjuan Garcia <dev-jorge.sanjuangarcia@duagon.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Jiri Slaby <jirislaby@kernel.org>
Cc: Andy Shevchenko <andriy.shevchenko@intel.com>
Cc: linux-serial@vger.kernel.org
Signed-off-by: Jose Javier Rodriguez Barbarin <dev-josejavier.rodriguez@duagon.com>
---
 drivers/tty/serial/men_z135_uart.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/tty/serial/men_z135_uart.c b/drivers/tty/serial/men_z135_uart.c
index 9cc15449b673..6fad57fee912 100644
--- a/drivers/tty/serial/men_z135_uart.c
+++ b/drivers/tty/serial/men_z135_uart.c
@@ -919,5 +919,4 @@ module_exit(men_z135_exit);
 MODULE_AUTHOR("Johannes Thumshirn <johannes.thumshirn@men.de>");
 MODULE_LICENSE("GPL v2");
 MODULE_DESCRIPTION("MEN 16z135 High Speed UART");
-MODULE_ALIAS("mcb:16z135");
 MODULE_IMPORT_NS("MCB");
-- 
2.52.0

[PATCH 3/5] iio: adc: men_z188_adc: drop unneeded MODULE_ALIAS

[Javier Rodriguez]

From: Jose Javier Rodriguez Barbarin <dev-josejavier.rodriguez@duagon.com>

The MODULE_ALIAS() is redundant since the module alias is now
automatically generated from the MODULE_DEVICE_TABLE().

Remove the explicit alias.

No functional change intended.

Fixes: 1f4ea4838b13 ("mcb: Add missing modpost build support")
Reviewed-by: Jorge Sanjuan Garcia <dev-jorge.sanjuangarcia@duagon.com>
Cc: Jonathan Cameron <jic23@kernel.org>
Cc: Andy Shevchenko <andriy.shevchenko@intel.com>
Cc: linux-iio@vger.kernel.org
Signed-off-by: Jose Javier Rodriguez Barbarin <dev-josejavier.rodriguez@duagon.com>
---
 drivers/iio/adc/men_z188_adc.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/iio/adc/men_z188_adc.c b/drivers/iio/adc/men_z188_adc.c
index cf8a8c0412ec..90919d282e7b 100644
--- a/drivers/iio/adc/men_z188_adc.c
+++ b/drivers/iio/adc/men_z188_adc.c
@@ -171,5 +171,4 @@ module_mcb_driver(men_z188_driver);
 MODULE_AUTHOR("Johannes Thumshirn <johannes.thumshirn@men.de>");
 MODULE_LICENSE("GPL");
 MODULE_DESCRIPTION("IIO ADC driver for MEN 16z188 ADC Core");
-MODULE_ALIAS("mcb:16z188");
 MODULE_IMPORT_NS("MCB");
-- 
2.52.0

[PATCH 4/5] 8250_men_mcb: drop unneeded MODULE_ALIAS

[Javier Rodriguez]

From: Jose Javier Rodriguez Barbarin <dev-josejavier.rodriguez@duagon.com>

The MODULE_ALIAS() is redundant since the module alias is now
automatically generated from the MODULE_DEVICE_TABLE().

Remove the explicit alias.

No functional change intended.

Fixes: 1f4ea4838b13 ("mcb: Add missing modpost build support")
Reviewed-by: Jorge Sanjuan Garcia <dev-jorge.sanjuangarcia@duagon.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Jiri Slaby <jirislaby@kernel.org>
Cc: Andy Shevchenko <andriy.shevchenko@intel.com>
Cc: linux-serial@vger.kernel.org
Signed-off-by: Jose Javier Rodriguez Barbarin <dev-josejavier.rodriguez@duagon.com>
---
 drivers/tty/serial/8250/8250_men_mcb.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/tty/serial/8250/8250_men_mcb.c b/drivers/tty/serial/8250/8250_men_mcb.c
index a78ef35c8187..9774a95f2980 100644
--- a/drivers/tty/serial/8250/8250_men_mcb.c
+++ b/drivers/tty/serial/8250/8250_men_mcb.c
@@ -268,7 +268,4 @@ module_mcb_driver(mcb_driver);
 MODULE_LICENSE("GPL v2");
 MODULE_DESCRIPTION("MEN 8250 UART driver");
 MODULE_AUTHOR("Michael Moese <michael.moese@men.de");
-MODULE_ALIAS("mcb:16z125");
-MODULE_ALIAS("mcb:16z025");
-MODULE_ALIAS("mcb:16z057");
 MODULE_IMPORT_NS("MCB");
-- 
2.52.0

[PATCH 5/5] watchdog: menz069_wdt: drop unneeded MODULE_ALIAS

[Javier Rodriguez]

From: Jose Javier Rodriguez Barbarin <dev-josejavier.rodriguez@duagon.com>

The MODULE_ALIAS() is redundant since the module alias is now
automatically generated from the MODULE_DEVICE_TABLE().

Remove the explicit alias.

No functional change intended.

Fixes: 1f4ea4838b13 ("mcb: Add missing modpost build support")
Reviewed-by: Jorge Sanjuan Garcia <dev-jorge.sanjuangarcia@duagon.com>
Cc: Johannes Thumshirn <jth@kernel.org>
Cc: Wim Van Sebroeck <wim@linux-watchdog.org>
Cc: Guenter Roeck <linux@roeck-us.net>
Cc: Andy Shevchenko <andriy.shevchenko@intel.com>
Cc: linux-watchdog@vger.kernel.org
Signed-off-by: Jose Javier Rodriguez Barbarin <dev-josejavier.rodriguez@duagon.com>
---
 drivers/watchdog/menz69_wdt.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/watchdog/menz69_wdt.c b/drivers/watchdog/menz69_wdt.c
index 6e5e4e5c0b56..3fe23451135d 100644
--- a/drivers/watchdog/menz69_wdt.c
+++ b/drivers/watchdog/menz69_wdt.c
@@ -163,5 +163,4 @@ module_mcb_driver(men_z069_driver);
 MODULE_AUTHOR("Johannes Thumshirn <jth@kernel.org>");
 MODULE_DESCRIPTION("Watchdog driver for the MEN z069 IP-Core");
 MODULE_LICENSE("GPL v2");
-MODULE_ALIAS("mcb:16z069");
 MODULE_IMPORT_NS("MCB");
-- 
2.52.0

Re: [PATCH 5/5] watchdog: menz069_wdt: drop unneeded MODULE_ALIAS

[Guenter Roeck]

On Tue, Dec 30, 2025 at 10:59:28PM +0100, Javier Rodriguez wrote:
> From: Jose Javier Rodriguez Barbarin <dev-josejavier.rodriguez@duagon.com>
> 
> The MODULE_ALIAS() is redundant since the module alias is now
> automatically generated from the MODULE_DEVICE_TABLE().
> 

Unless the generated alias is not "mcb:16z069", and it is unlikely that
it is. That means it is not really redundant.

Guenter

> Remove the explicit alias.
> 
> No functional change intended.
> 
> Fixes: 1f4ea4838b13 ("mcb: Add missing modpost build support")
> Reviewed-by: Jorge Sanjuan Garcia <dev-jorge.sanjuangarcia@duagon.com>
> Cc: Johannes Thumshirn <jth@kernel.org>
> Cc: Wim Van Sebroeck <wim@linux-watchdog.org>
> Cc: Guenter Roeck <linux@roeck-us.net>
> Cc: Andy Shevchenko <andriy.shevchenko@intel.com>
> Cc: linux-watchdog@vger.kernel.org
> Signed-off-by: Jose Javier Rodriguez Barbarin <dev-josejavier.rodriguez@duagon.com>
> ---
>  drivers/watchdog/menz69_wdt.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/watchdog/menz69_wdt.c b/drivers/watchdog/menz69_wdt.c
> index 6e5e4e5c0b56..3fe23451135d 100644
> --- a/drivers/watchdog/menz69_wdt.c
> +++ b/drivers/watchdog/menz69_wdt.c
> @@ -163,5 +163,4 @@ module_mcb_driver(men_z069_driver);
>  MODULE_AUTHOR("Johannes Thumshirn <jth@kernel.org>");
>  MODULE_DESCRIPTION("Watchdog driver for the MEN z069 IP-Core");
>  MODULE_LICENSE("GPL v2");
> -MODULE_ALIAS("mcb:16z069");
>  MODULE_IMPORT_NS("MCB");
> -- 
> 2.52.0

Re: [PATCH 3/5] iio: adc: men_z188_adc: drop unneeded MODULE_ALIAS

[Jonathan Cameron]

On Tue, 30 Dec 2025 22:59:26 +0100
Javier Rodriguez <josejavier.rodriguez@duagon.com> wrote:

> From: Jose Javier Rodriguez Barbarin <dev-josejavier.rodriguez@duagon.com>
> 
> The MODULE_ALIAS() is redundant since the module alias is now
> automatically generated from the MODULE_DEVICE_TABLE().
> 
> Remove the explicit alias.
> 
> No functional change intended.
> 
> Fixes: 1f4ea4838b13 ("mcb: Add missing modpost build support")

From the patch description I'm not seeing how this is a fix?
Seems like cleanup of unnecessary code given what you have written above.

> Reviewed-by: Jorge Sanjuan Garcia <dev-jorge.sanjuangarcia@duagon.com>
> Cc: Jonathan Cameron <jic23@kernel.org>
> Cc: Andy Shevchenko <andriy.shevchenko@intel.com>
> Cc: linux-iio@vger.kernel.org
> Signed-off-by: Jose Javier Rodriguez Barbarin <dev-josejavier.rodriguez@duagon.com>
> ---
>  drivers/iio/adc/men_z188_adc.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/iio/adc/men_z188_adc.c b/drivers/iio/adc/men_z188_adc.c
> index cf8a8c0412ec..90919d282e7b 100644
> --- a/drivers/iio/adc/men_z188_adc.c
> +++ b/drivers/iio/adc/men_z188_adc.c
> @@ -171,5 +171,4 @@ module_mcb_driver(men_z188_driver);
>  MODULE_AUTHOR("Johannes Thumshirn <johannes.thumshirn@men.de>");
>  MODULE_LICENSE("GPL");
>  MODULE_DESCRIPTION("IIO ADC driver for MEN 16z188 ADC Core");
> -MODULE_ALIAS("mcb:16z188");
>  MODULE_IMPORT_NS("MCB");

Re: [PATCH 1/5] gpio: gpio-menz127: drop unneeded MODULE_ALIAS

[Andy Shevchenko]

On Tue, Dec 30, 2025 at 10:59:24PM +0100, Javier Rodriguez wrote:
>    From: Jose Javier Rodriguez Barbarin <dev-josejavier.rodriguez@duagon.com>
> 
>    The MODULE_ALIAS() is redundant since the module alias is now
>    automatically generated from the MODULE_DEVICE_TABLE().
> 
>    Remove the explicit alias.
> 
>    No functional change intended.

The patch is mangled.

>    Fixes: 1f4ea4838b13 ("mcb: Add missing modpost build support")
>    Reviewed-by: Jorge Sanjuan Garcia <dev-jorge.sanjuangarcia@duagon.com>

>    Cc: Linus Walleij <linusw@kernel.org>
>    Cc: Bartosz Golaszewski <brgl@kernel.org>
>    Cc: Andy Shevchenko <andriy.shevchenko@intel.com>
>    Cc: linux-gpio@vger.kernel.org

Please, move the Cc: list after the '---' line...

>    Signed-off-by: Jose Javier Rodriguez Barbarin
>    <dev-josejavier.rodriguez@duagon.com>
>    ---

...here. It will have the same effect on email, but will reduce a noise in the
Git history.

...

>    The information contained in this message is private and confidential, as
>    well as any enclosed document/file attached to it and is addressed
>    exclusively to its recipient. Please if you are not the intended recipient
>    and have received this message by mistake, notify us of this fact and
>    delete the message from your system. The copying, dissemination or
>    disclosure of its content to third parties without the prior written
>    consent of DUAGON IBERIA S.L. is forbidden. Otherwise, it will violate
>    current legislation. In accordance with Spanish Data Protection Law 3/2018
>    and the European Data Protection Regulation 2016/679, we remind you that
>    your data is processed by DUAGON IBERIA S.L.. You can freely exercise the
>    rights of access, opposition, rectification, cancellation or suppression,
>    revocation of consent, portability and limitation of data processing, by
>    contacting DUAGON IBERIA S.L., Ronda de Europa, 5. Tres Cantos. Madrid,
>    C.P. 28760. Spain.

This is not compatible with the Open Source workflow. Please, make sure there
is no footer in the next version.

...

Also, you missed a cover letter. Or send the patches separately as I don't see
now any evidence of the cross patch dependency.

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH 1/5] gpio: gpio-menz127: drop unneeded MODULE_ALIAS

[Jose Javier Rodriguez Barbarin]

On Fri, Jan 02, 2026 at 02:10:47PM +0200, Andy Shevchenko wrote:
> On Tue, Dec 30, 2025 at 10:59:24PM +0100, Javier Rodriguez wrote:
> >    From: Jose Javier Rodriguez Barbarin <dev-josejavier.rodriguez@duagon.com>
> > 
> >    The MODULE_ALIAS() is redundant since the module alias is now
> >    automatically generated from the MODULE_DEVICE_TABLE().
> > 
> >    Remove the explicit alias.
> > 
> >    No functional change intended.
> 
> The patch is mangled.
> 
> >    Fixes: 1f4ea4838b13 ("mcb: Add missing modpost build support")
> >    Reviewed-by: Jorge Sanjuan Garcia <dev-jorge.sanjuangarcia@duagon.com>
> 
> >    Cc: Linus Walleij <linusw@kernel.org>
> >    Cc: Bartosz Golaszewski <brgl@kernel.org>
> >    Cc: Andy Shevchenko <andriy.shevchenko@intel.com>
> >    Cc: linux-gpio@vger.kernel.org
> 
> Please, move the Cc: list after the '---' line...
> 
> >    Signed-off-by: Jose Javier Rodriguez Barbarin
> >    <dev-josejavier.rodriguez@duagon.com>
> >    ---
> 
> ...here. It will have the same effect on email, but will reduce a noise in the
> Git history.
> 
> ...
> 
> >    The information contained in this message is private and confidential, as
> >    well as any enclosed document/file attached to it and is addressed
> >    exclusively to its recipient. Please if you are not the intended recipient
> >    and have received this message by mistake, notify us of this fact and
> >    delete the message from your system. The copying, dissemination or
> >    disclosure of its content to third parties without the prior written
> >    consent of DUAGON IBERIA S.L. is forbidden. Otherwise, it will violate
> >    current legislation. In accordance with Spanish Data Protection Law 3/2018
> >    and the European Data Protection Regulation 2016/679, we remind you that
> >    your data is processed by DUAGON IBERIA S.L.. You can freely exercise the
> >    rights of access, opposition, rectification, cancellation or suppression,
> >    revocation of consent, portability and limitation of data processing, by
> >    contacting DUAGON IBERIA S.L., Ronda de Europa, 5. Tres Cantos. Madrid,
> >    C.P. 28760. Spain.
> 
> This is not compatible with the Open Source workflow. Please, make sure there
> is no footer in the next version.
> 

This is a bit embarrasing. I forgot to configure git to use tu proper email account.

> ...
> 
> Also, you missed a cover letter. Or send the patches separately as I don't see
> now any evidence of the cross patch dependency.

Yes, I decided to send the patches in a way that was not the best. So I'm going to
send the patches separately for each subsystem.

> 
> -- 
> With Best Regards,
> Andy Shevchenko
> 
> 

Thank you so much for your review.

Regards,

Javier R.