From: Dan Carpenter <dan.carpenter@linaro.org>
To: "Dominik Karol Piątkowski" <dominik.karol.piatkowski@protonmail.com>
Cc: Dave Penkler <dpenkler@gmail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Michael Rubin <matchstick@neverthere.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/9] gpib: Unify *allocate_private
Date: Mon, 19 Jan 2026 10:34:52 +0300 [thread overview]
Message-ID: <aW3enNsGsE_hKtKR@stanley.mountain> (raw)
In-Reply-To: <20260113190759.54355-1-dominik.karol.piatkowski@protonmail.com>
On Tue, Jan 13, 2026 at 07:08:37PM +0000, Dominik Karol Piątkowski wrote:
> Recently, gpib driver got out of staging area. There is still a bit of work that
> can be done to improve it.
>
> Return values for *allocate_private functions as well as calling code in
> gpib driver are all over the place. Unify them by returning -errno if
> something fails, zero otherwise. Use the returned value as early return
> value in case of error.
>
> Untouched gpib files already use the proposed convention.
>
> Signed-off-by: Dominik Karol Piątkowski <dominik.karol.piatkowski@protonmail.com>
I don't see the point of the allocate_private() functions. Why not
just open code it?
regards,
dan carpenter
next prev parent reply other threads:[~2026-01-19 7:34 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-13 19:08 [PATCH 0/9] gpib: Unify *allocate_private Dominik Karol Piątkowski
2026-01-13 19:08 ` [PATCH 1/9] gpib: agilent_82350b: " Dominik Karol Piątkowski
2026-01-16 7:36 ` Greg Kroah-Hartman
2026-01-16 14:45 ` Dominik Karol Piątkowski
2026-01-13 19:08 ` [PATCH 2/9] gpib: cb7210: " Dominik Karol Piątkowski
2026-01-13 19:08 ` [PATCH 3/9] gpib: cec: " Dominik Karol Piątkowski
2026-01-15 16:29 ` Dave Penkler
2026-01-15 18:11 ` Dominik Karol Piątkowski
2026-01-16 7:50 ` Greg Kroah-Hartman
2026-01-13 19:09 ` [PATCH 4/9] gpib: gpio: " Dominik Karol Piątkowski
2026-01-13 19:09 ` [PATCH 5/9] gpib: hp_82335: " Dominik Karol Piątkowski
2026-01-13 19:09 ` [PATCH 6/9] gpib: hp_82341: " Dominik Karol Piątkowski
2026-01-13 19:09 ` [PATCH 7/9] gpib: ines: " Dominik Karol Piątkowski
2026-01-13 19:09 ` [PATCH 8/9] gpib: pc2: " Dominik Karol Piątkowski
2026-01-13 19:09 ` [PATCH 9/9] gpib: tnt4882: " Dominik Karol Piątkowski
2026-01-19 7:34 ` Dan Carpenter [this message]
2026-01-20 16:12 ` [PATCH 0/9] gpib: " Dominik Karol Piątkowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aW3enNsGsE_hKtKR@stanley.mountain \
--to=dan.carpenter@linaro.org \
--cc=dominik.karol.piatkowski@protonmail.com \
--cc=dpenkler@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matchstick@neverthere.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox