From: "Luck, Tony" <tony.luck@intel.com>
To: Borislav Petkov <bp@alien8.de>
Cc: Fenghua Yu <fenghuay@nvidia.com>,
Reinette Chatre <reinette.chatre@intel.com>,
Maciej Wieczor-Retman <maciej.wieczor-retman@intel.com>,
Peter Newman <peternewman@google.com>,
James Morse <james.morse@arm.com>,
Babu Moger <babu.moger@amd.com>,
"Drew Fustini" <dfustini@baylibre.com>,
Dave Martin <Dave.Martin@arm.com>, Chen Yu <yu.c.chen@intel.com>,
<x86@kernel.org>, <linux-kernel@vger.kernel.org>,
<patches@lists.linux.dev>
Subject: Re: [PATCH v17 30/32] fs/resctrl: Provide interface to create architecture specific debugfs area
Date: Sat, 10 Jan 2026 11:13:40 -0800 [thread overview]
Message-ID: <aWKk5BYP8BJjYhs6@agluck-desk3> (raw)
In-Reply-To: <20260110105758.GAaWIwtlX9o_oVXIM_@fat_crate.local>
On Sat, Jan 10, 2026 at 11:57:58AM +0100, Borislav Petkov wrote:
> On Wed, Dec 17, 2025 at 09:21:17AM -0800, Tony Luck wrote:
> > All files below /sys/fs/resctrl are considered user ABI.
> >
> > This leaves no place for architectures to provide additional interfaces.
> >
> > Add resctrl_debugfs_mon_info_arch_mkdir() which creates a directory in
> > the debugfs file system for a monitoring resource. Naming follows the
> > layout of the main resctrl hierarchy:
> >
> > /sys/kernel/debug/resctrl/info/{resource}_MON/{arch}
> >
> > The {arch} last level directory name matches the output of the user level
> > "uname -m" command.
> >
> > Architecture code may use this directory for debug information, or for minor
> > tuning of features. It must not be used for basic feature enabling as debugfs
> > may not be configured/mounted on production systems.
>
> I, like you guys, thought that debugfs is "safe" in the sense, stuff there
> can't really be an ABI but just recently at LPC I got schooled about it and,
> basically, if anything in luserspace starts using debugfs, it will be
> considered an ABI.
>
> And this thinking has been there for a looong time now:
>
> https://lwn.net/Articles/309298/
>
> So, before you put anything there, think again because you might end up
> supporting it just like an ABI.
Please drop patches 30, 31, and the debugfs hunk to Documentation from patch 32
while I look at options. The debugfs bits aren't needed for normal
operation, just for debugging if things don't appear to be working as
expected. No need to hold up inclusion waiting for a solution.
Telemetry based events tied to RMIDs are new in Clearwater Forest. I
have line of sight to a second platorm. But extrapolating from two
data points to decide on a stable ABI seems very risky.
Thanks
-Tony
next prev parent reply other threads:[~2026-01-10 19:13 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-17 17:20 [PATCH v17 00/32] x86,fs/resctrl telemetry monitoring Tony Luck
2025-12-17 17:20 ` [PATCH v17 01/32] x86,fs/resctrl: Improve domain type checking Tony Luck
2025-12-17 17:20 ` [PATCH v17 02/32] x86/resctrl: Move L3 initialization into new helper function Tony Luck
2025-12-17 17:20 ` [PATCH v17 03/32] x86/resctrl: Refactor domain_remove_cpu_mon() ready for new domain types Tony Luck
2025-12-17 17:20 ` [PATCH v17 04/32] x86/resctrl: Clean up domain_remove_cpu_ctrl() Tony Luck
2025-12-17 17:20 ` [PATCH v17 05/32] x86,fs/resctrl: Refactor domain create/remove using struct rdt_domain_hdr Tony Luck
2025-12-17 17:20 ` [PATCH v17 06/32] fs/resctrl: Split L3 dependent parts out of __mon_event_count() Tony Luck
2025-12-17 17:20 ` [PATCH v17 07/32] x86,fs/resctrl: Use struct rdt_domain_hdr when reading counters Tony Luck
2025-12-17 17:20 ` [PATCH v17 08/32] x86,fs/resctrl: Rename struct rdt_mon_domain and rdt_hw_mon_domain Tony Luck
2025-12-17 17:20 ` [PATCH v17 09/32] x86,fs/resctrl: Rename some L3 specific functions Tony Luck
2025-12-17 17:20 ` [PATCH v17 10/32] fs/resctrl: Make event details accessible to functions when reading events Tony Luck
2025-12-17 17:20 ` [PATCH v17 11/32] x86,fs/resctrl: Handle events that can be read from any CPU Tony Luck
2025-12-17 17:20 ` [PATCH v17 12/32] x86,fs/resctrl: Support binary fixed point event counters Tony Luck
2025-12-17 17:21 ` [PATCH v17 13/32] x86,fs/resctrl: Add an architectural hook called for each mount Tony Luck
2026-01-05 19:17 ` Borislav Petkov
2026-01-05 19:39 ` Luck, Tony
2026-01-05 20:04 ` Borislav Petkov
2026-01-05 20:15 ` Luck, Tony
2026-01-07 17:29 ` Reinette Chatre
2026-01-07 18:05 ` Luck, Tony
2026-01-07 19:33 ` Reinette Chatre
2026-01-07 20:25 ` Luck, Tony
2026-01-07 22:09 ` Reinette Chatre
2026-01-07 22:27 ` Luck, Tony
2026-01-07 23:09 ` Reinette Chatre
2026-01-08 0:16 ` Luck, Tony
2026-01-08 2:42 ` Reinette Chatre
2025-12-17 17:21 ` [PATCH v17 14/32] x86,fs/resctrl: Add and initialize a resource for package scope monitoring Tony Luck
2025-12-17 17:21 ` [PATCH v17 15/32] fs/resctrl: Emphasize that L3 monitoring resource is required for summing domains Tony Luck
2025-12-17 17:21 ` [PATCH v17 16/32] x86/resctrl: Discover hardware telemetry events Tony Luck
2025-12-17 17:21 ` [PATCH v17 17/32] x86,fs/resctrl: Fill in details of events for guid 0x26696143 and 0x26557651 Tony Luck
2025-12-17 17:21 ` [PATCH v17 18/32] x86,fs/resctrl: Add architectural event pointer Tony Luck
2025-12-17 17:21 ` [PATCH v17 19/32] x86/resctrl: Find and enable usable telemetry events Tony Luck
2026-01-09 12:16 ` Borislav Petkov
2026-01-09 16:17 ` Reinette Chatre
2026-01-09 16:53 ` Luck, Tony
2026-01-09 22:01 ` Borislav Petkov
2025-12-17 17:21 ` [PATCH v17 20/32] x86/resctrl: Read " Tony Luck
2025-12-17 17:21 ` [PATCH v17 21/32] fs/resctrl: Refactor mkdir_mondata_subdir() Tony Luck
2025-12-17 17:21 ` [PATCH v17 22/32] fs/resctrl: Refactor rmdir_mondata_subdir_allrdtgrp() Tony Luck
2025-12-17 17:21 ` [PATCH v17 23/32] x86,fs/resctrl: Handle domain creation/deletion for RDT_RESOURCE_PERF_PKG Tony Luck
2025-12-17 17:21 ` [PATCH v17 24/32] x86/resctrl: Add energy/perf choices to rdt boot option Tony Luck
2026-01-09 22:16 ` Borislav Petkov
2026-01-09 22:20 ` Luck, Tony
2025-12-17 17:21 ` [PATCH v17 25/32] x86/resctrl: Handle number of RMIDs supported by RDT_RESOURCE_PERF_PKG Tony Luck
2025-12-17 17:21 ` [PATCH v17 26/32] fs/resctrl: Move allocation/free of closid_num_dirty_rmid[] Tony Luck
2025-12-17 17:21 ` [PATCH v17 27/32] x86,fs/resctrl: Compute number of RMIDs as minimum across resources Tony Luck
2025-12-17 17:21 ` [PATCH v17 28/32] fs/resctrl: Move RMID initialization to first mount Tony Luck
2025-12-17 17:21 ` [PATCH v17 29/32] x86/resctrl: Enable RDT_RESOURCE_PERF_PKG Tony Luck
2025-12-17 17:21 ` [PATCH v17 30/32] fs/resctrl: Provide interface to create architecture specific debugfs area Tony Luck
2026-01-10 10:57 ` Borislav Petkov
2026-01-10 19:13 ` Luck, Tony [this message]
2026-01-10 19:42 ` Borislav Petkov
2026-01-10 23:29 ` Luck, Tony
2025-12-17 17:21 ` [PATCH v17 31/32] x86/resctrl: Add debugfs files to show telemetry aggregator status Tony Luck
2025-12-17 17:21 ` [PATCH v17 32/32] x86,fs/resctrl: Update documentation for telemetry events Tony Luck
2025-12-17 22:16 ` [PATCH v17 00/32] x86,fs/resctrl telemetry monitoring Reinette Chatre
2026-01-04 6:14 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aWKk5BYP8BJjYhs6@agluck-desk3 \
--to=tony.luck@intel.com \
--cc=Dave.Martin@arm.com \
--cc=babu.moger@amd.com \
--cc=bp@alien8.de \
--cc=dfustini@baylibre.com \
--cc=fenghuay@nvidia.com \
--cc=james.morse@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maciej.wieczor-retman@intel.com \
--cc=patches@lists.linux.dev \
--cc=peternewman@google.com \
--cc=reinette.chatre@intel.com \
--cc=x86@kernel.org \
--cc=yu.c.chen@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox