The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Antoniu Miclaus <antoniu.miclaus@analog.com>
Cc: "Lars-Peter Clausen" <lars@metafoo.de>,
	"Michael Hennerich" <Michael.Hennerich@analog.com>,
	"Jonathan Cameron" <jic23@kernel.org>,
	"David Lechner" <dlechner@baylibre.com>,
	"Nuno Sá" <nuno.sa@analog.com>,
	"Andy Shevchenko" <andy@kernel.org>,
	"Ramona Gradinariu" <ramona.gradinariu@analog.com>,
	"Andrew Ijano" <andrew.ijano@gmail.com>,
	"Gustavo Bastos" <gustavobastos@usp.br>,
	linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] iio: accel: adxl372: remove unused int2_bitmask field
Date: Thu, 29 Jan 2026 16:28:11 +0200	[thread overview]
Message-ID: <aXtuexNdZhKvfAg6@smile.fi.intel.com> (raw)
In-Reply-To: <20260129141205.106285-1-antoniu.miclaus@analog.com>

On Thu, Jan 29, 2026 at 04:11:57PM +0200, Antoniu Miclaus wrote:
> Remove unused int2_bitmask field from adxl372_state struct.
> The field is declared but never accessed in the driver.

While patches are okay, you have two issues with the series (or three):
- the email thread is not a thread, missed --thread?
- the series lacks of a cover letter

And optional third one: should it even be a series in the first place?

You can use my script [1] to make it not forgotten.

[1]: https://github.com/andy-shev/home-bin-tools/blob/master/ge2maintainer.sh

P.S. I hope that this simple thing can be caught during internal reviews...

-- 
With Best Regards,
Andy Shevchenko



  parent reply	other threads:[~2026-01-29 14:28 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-29 14:11 [PATCH 1/3] iio: accel: adxl372: remove unused int2_bitmask field Antoniu Miclaus
2026-01-29 14:11 ` [PATCH 2/3] iio: accel: adxl380: remove unused odr field Antoniu Miclaus
2026-01-29 16:24   ` Jonathan Cameron
2026-01-29 16:38     ` Miclaus, Antoniu
2026-01-29 14:11 ` [PATCH 3/3] iio: accel: sca3000: remove unused last_timestamp field Antoniu Miclaus
2026-01-29 16:26   ` Jonathan Cameron
2026-01-29 14:28 ` Andy Shevchenko [this message]
2026-01-29 14:37   ` [PATCH 1/3] iio: accel: adxl372: remove unused int2_bitmask field Miclaus, Antoniu
2026-01-29 15:36     ` Andy Shevchenko
2026-01-29 16:25 ` Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aXtuexNdZhKvfAg6@smile.fi.intel.com \
    --to=andriy.shevchenko@intel.com \
    --cc=Michael.Hennerich@analog.com \
    --cc=andrew.ijano@gmail.com \
    --cc=andy@kernel.org \
    --cc=antoniu.miclaus@analog.com \
    --cc=dlechner@baylibre.com \
    --cc=gustavobastos@usp.br \
    --cc=jic23@kernel.org \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nuno.sa@analog.com \
    --cc=ramona.gradinariu@analog.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox