[PATCH 1/3] iio: accel: adxl372: remove unused int2_bitmask field

[PATCH 1/3] iio: accel: adxl372: remove unused int2_bitmask field

[Antoniu Miclaus]

Remove unused int2_bitmask field from adxl372_state struct.
The field is declared but never accessed in the driver.

Signed-off-by: Antoniu Miclaus <antoniu.miclaus@analog.com>
---
 drivers/iio/accel/adxl372.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/iio/accel/adxl372.c b/drivers/iio/accel/adxl372.c
index 46d518a2a029..9e4e8c8d9e9c 100644
--- a/drivers/iio/accel/adxl372.c
+++ b/drivers/iio/accel/adxl372.c
@@ -295,7 +295,6 @@ struct adxl372_state {
 	u32				inact_time_ms;
 	u8				fifo_set_size;
 	unsigned long			int1_bitmask;
-	unsigned long			int2_bitmask;
 	u16				watermark;
 	__be16				fifo_buf[ADXL372_FIFO_SIZE];
 	bool				peak_fifo_mode_en;
-- 
2.43.0

[PATCH 2/3] iio: accel: adxl380: remove unused odr field

[Antoniu Miclaus]

Remove unused odr field from adxl380_state struct.
The field is declared but never accessed in the driver.

Signed-off-by: Antoniu Miclaus <antoniu.miclaus@analog.com>
---
 drivers/iio/accel/adxl380.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/iio/accel/adxl380.c b/drivers/iio/accel/adxl380.c
index aef5109c1ddd..4c584f6ec902 100644
--- a/drivers/iio/accel/adxl380.c
+++ b/drivers/iio/accel/adxl380.c
@@ -206,7 +206,6 @@ struct adxl380_state {
 	struct mutex lock;
 	enum adxl380_axis tap_axis_en;
 	u8 range;
-	u8 odr;
 	u8 fifo_set_size;
 	u8 transf_buf[3];
 	u16 watermark;
-- 
2.43.0

Re: [PATCH 2/3] iio: accel: adxl380: remove unused odr field

[Jonathan Cameron]

On Thu, 29 Jan 2026 16:11:58 +0200
Antoniu Miclaus <antoniu.miclaus@analog.com> wrote:

> Remove unused odr field from adxl380_state struct.
> The field is declared but never accessed in the driver.
It is used in my tree...

I blindly applied this on assumption a build test was quicker than
checking if you were right :)

drivers/iio/accel/adxl380.c:271:8: error: no member named 'odr' in 'struct adxl380_state'
  271 |                         st->odr = ADXL380_ODR_VLP;
      |                         ~~  ^
drivers/iio/accel/adxl380.c:273:11: error: no member named 'odr' in 'struct adxl380_state'
  273 |                 if (st->odr == ADXL380_ODR_VLP)
      |                     ~~  ^
drivers/iio/accel/adxl380.c:440:42: error: no member named 'odr' in 'struct adxl380_state'
  440 |         *odr = st->chip_info->samp_freq_tbl[st->odr];
      |                                             ~~  ^
drivers/iio/accel/adxl380.c:518:6: error: no member named 'odr' in 'struct adxl380_state'
  518 |         st->odr = odr;
      |         ~~  ^
drivers/iio/accel/adxl380.c:1967:6: error: no member named 'odr' in 'struct adxl380_state'
 1967 |         st->odr = ADXL380_ODR_DSM;
      |         ~~  ^
5 errors generated.


> 
> Signed-off-by: Antoniu Miclaus <antoniu.miclaus@analog.com>
> ---
>  drivers/iio/accel/adxl380.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/iio/accel/adxl380.c b/drivers/iio/accel/adxl380.c
> index aef5109c1ddd..4c584f6ec902 100644
> --- a/drivers/iio/accel/adxl380.c
> +++ b/drivers/iio/accel/adxl380.c
> @@ -206,7 +206,6 @@ struct adxl380_state {
>  	struct mutex lock;
>  	enum adxl380_axis tap_axis_en;
>  	u8 range;
> -	u8 odr;
>  	u8 fifo_set_size;
>  	u8 transf_buf[3];
>  	u16 watermark;

RE: [PATCH 2/3] iio: accel: adxl380: remove unused odr field

[Miclaus, Antoniu]

> -----Original Message-----
> From: Jonathan Cameron <jic23@kernel.org>
> Sent: Thursday, January 29, 2026 6:25 PM
> To: Miclaus, Antoniu <Antoniu.Miclaus@analog.com>
> Cc: Hennerich, Michael <Michael.Hennerich@analog.com>; Lars-Peter Clausen
> <lars@metafoo.de>; David Lechner <dlechner@baylibre.com>; Sa, Nuno
> <Nuno.Sa@analog.com>; Andy Shevchenko <andy@kernel.org>; Gradinariu,
> Ramona <Ramona.Gradinariu@analog.com>; Andrew Ijano
> <andrew.ijano@gmail.com>; linux-iio@vger.kernel.org; linux-
> kernel@vger.kernel.org
> Subject: Re: [PATCH 2/3] iio: accel: adxl380: remove unused odr field
> 
> [External]
> 
> On Thu, 29 Jan 2026 16:11:58 +0200
> Antoniu Miclaus <antoniu.miclaus@analog.com> wrote:
> 
> > Remove unused odr field from adxl380_state struct.
> > The field is declared but never accessed in the driver.
> It is used in my tree...
> 
> I blindly applied this on assumption a build test was quicker than
> checking if you were right :)
> 

Oh, I applied this against latest master branch where it was valid. Saw now the new patches that make use of it.

> drivers/iio/accel/adxl380.c:271:8: error: no member named 'odr' in 'struct
> adxl380_state'
>   271 |                         st->odr = ADXL380_ODR_VLP;
>       |                         ~~  ^
> drivers/iio/accel/adxl380.c:273:11: error: no member named 'odr' in 'struct
> adxl380_state'
>   273 |                 if (st->odr == ADXL380_ODR_VLP)
>       |                     ~~  ^
> drivers/iio/accel/adxl380.c:440:42: error: no member named 'odr' in 'struct
> adxl380_state'
>   440 |         *odr = st->chip_info->samp_freq_tbl[st->odr];
>       |                                             ~~  ^
> drivers/iio/accel/adxl380.c:518:6: error: no member named 'odr' in 'struct
> adxl380_state'
>   518 |         st->odr = odr;
>       |         ~~  ^
> drivers/iio/accel/adxl380.c:1967:6: error: no member named 'odr' in 'struct
> adxl380_state'
>  1967 |         st->odr = ADXL380_ODR_DSM;
>       |         ~~  ^
> 5 errors generated

> 
> >
> > Signed-off-by: Antoniu Miclaus <antoniu.miclaus@analog.com>
> > ---
> >  drivers/iio/accel/adxl380.c | 1 -
> >  1 file changed, 1 deletion(-)
> >
> > diff --git a/drivers/iio/accel/adxl380.c b/drivers/iio/accel/adxl380.c
> > index aef5109c1ddd..4c584f6ec902 100644
> > --- a/drivers/iio/accel/adxl380.c
> > +++ b/drivers/iio/accel/adxl380.c
> > @@ -206,7 +206,6 @@ struct adxl380_state {
> >  	struct mutex lock;
> >  	enum adxl380_axis tap_axis_en;
> >  	u8 range;
> > -	u8 odr;
> >  	u8 fifo_set_size;
> >  	u8 transf_buf[3];
> >  	u16 watermark;

[PATCH 3/3] iio: accel: sca3000: remove unused last_timestamp field

[Antoniu Miclaus]

Remove unused last_timestamp field from sca3000_state
struct. The field is declared but never accessed in the
driver.

Signed-off-by: Antoniu Miclaus <antoniu.miclaus@analog.com>
---
 drivers/iio/accel/sca3000.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/iio/accel/sca3000.c b/drivers/iio/accel/sca3000.c
index bfa8a3f5a92f..950b4c672484 100644
--- a/drivers/iio/accel/sca3000.c
+++ b/drivers/iio/accel/sca3000.c
@@ -153,7 +153,6 @@
  * struct sca3000_state - device instance state information
  * @us:			the associated spi device
  * @info:			chip variant information
- * @last_timestamp:		the timestamp of the last event
  * @mo_det_use_count:		reference counter for the motion detection unit
  * @lock:			lock used to protect elements of sca3000_state
  *				and the underlying device state.
@@ -163,7 +162,6 @@
 struct sca3000_state {
 	struct spi_device		*us;
 	const struct sca3000_chip_info	*info;
-	s64				last_timestamp;
 	int				mo_det_use_count;
 	struct mutex			lock;
 	/* Can these share a cacheline ? */
-- 
2.43.0

Re: [PATCH 3/3] iio: accel: sca3000: remove unused last_timestamp field

[Jonathan Cameron]

On Thu, 29 Jan 2026 16:11:59 +0200
Antoniu Miclaus <antoniu.miclaus@analog.com> wrote:

> Remove unused last_timestamp field from sca3000_state
> struct. The field is declared but never accessed in the
> driver.
> 
> Signed-off-by: Antoniu Miclaus <antoniu.miclaus@analog.com>
Also fine so applied.

Thanks for tidying these up.

Jonathan

> ---
>  drivers/iio/accel/sca3000.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/iio/accel/sca3000.c b/drivers/iio/accel/sca3000.c
> index bfa8a3f5a92f..950b4c672484 100644
> --- a/drivers/iio/accel/sca3000.c
> +++ b/drivers/iio/accel/sca3000.c
> @@ -153,7 +153,6 @@
>   * struct sca3000_state - device instance state information
>   * @us:			the associated spi device
>   * @info:			chip variant information
> - * @last_timestamp:		the timestamp of the last event
>   * @mo_det_use_count:		reference counter for the motion detection unit
>   * @lock:			lock used to protect elements of sca3000_state
>   *				and the underlying device state.
> @@ -163,7 +162,6 @@
>  struct sca3000_state {
>  	struct spi_device		*us;
>  	const struct sca3000_chip_info	*info;
> -	s64				last_timestamp;
>  	int				mo_det_use_count;
>  	struct mutex			lock;
>  	/* Can these share a cacheline ? */

Re: [PATCH 1/3] iio: accel: adxl372: remove unused int2_bitmask field

[Andy Shevchenko]

On Thu, Jan 29, 2026 at 04:11:57PM +0200, Antoniu Miclaus wrote:
> Remove unused int2_bitmask field from adxl372_state struct.
> The field is declared but never accessed in the driver.

While patches are okay, you have two issues with the series (or three):
- the email thread is not a thread, missed --thread?
- the series lacks of a cover letter

And optional third one: should it even be a series in the first place?

You can use my script [1] to make it not forgotten.

[1]: https://github.com/andy-shev/home-bin-tools/blob/master/ge2maintainer.sh

P.S. I hope that this simple thing can be caught during internal reviews...

-- 
With Best Regards,
Andy Shevchenko

RE: [PATCH 1/3] iio: accel: adxl372: remove unused int2_bitmask field

[Miclaus, Antoniu]

> -----Original Message-----
> From: Andy Shevchenko <andriy.shevchenko@intel.com>
> Sent: Thursday, January 29, 2026 4:28 PM
> To: Miclaus, Antoniu <Antoniu.Miclaus@analog.com>
> Cc: Lars-Peter Clausen <lars@metafoo.de>; Hennerich, Michael
> <Michael.Hennerich@analog.com>; Jonathan Cameron <jic23@kernel.org>;
> David Lechner <dlechner@baylibre.com>; Sa, Nuno <Nuno.Sa@analog.com>;
> Andy Shevchenko <andy@kernel.org>; Gradinariu, Ramona
> <Ramona.Gradinariu@analog.com>; Andrew Ijano
> <andrew.ijano@gmail.com>; Gustavo Bastos <gustavobastos@usp.br>; linux-
> iio@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: Re: [PATCH 1/3] iio: accel: adxl372: remove unused int2_bitmask field
> 
> [External]
> 
> On Thu, Jan 29, 2026 at 04:11:57PM +0200, Antoniu Miclaus wrote:
> > Remove unused int2_bitmask field from adxl372_state struct.
> > The field is declared but never accessed in the driver.
> 
> While patches are okay, you have two issues with the series (or three):
> - the email thread is not a thread, missed --thread?

Thanks for pointing that out. I never used --thread before, is the first time I am 
seeing it mentioned in a review.

> - the series lacks of a cover letter

True. Will do that in v2 (if changes requested). Btw, for these small changes if they
aren't placed in a series but individually I guess I can skip the cover letter?

> You can use my script [1] to make it not forgotten.
> 
> [1]: https://urldefense.com/v3/__https://github.com/andy-shev/home-bin-
> tools/blob/master/ge2maintainer.sh__;!!A3Ni8CS0y2Y!48H-
> JjuYcJZ2OfRfcWweVwMeYt0ghmCKzi1zlIX6jeIA15T0zhb28_T2Zj1YrAL8ho-
> gPXrtsmWhbYh4wW8N1TrsINiFNkI$
> 
> P.S. I hope that this simple thing can be caught during internal reviews...
> 
> --
> With Best Regards,
> Andy Shevchenko
> 

Re: [PATCH 1/3] iio: accel: adxl372: remove unused int2_bitmask field

[Andy Shevchenko]

On Thu, Jan 29, 2026 at 4:38 PM Miclaus, Antoniu
<Antoniu.Miclaus@analog.com> wrote:

> Btw, for these small changes if they
> aren't placed in a series but individually I guess I can skip the cover letter?

Correct.

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH 1/3] iio: accel: adxl372: remove unused int2_bitmask field

[Jonathan Cameron]

On Thu, 29 Jan 2026 16:11:57 +0200
Antoniu Miclaus <antoniu.miclaus@analog.com> wrote:

> Remove unused int2_bitmask field from adxl372_state struct.
> The field is declared but never accessed in the driver.
> 
> Signed-off-by: Antoniu Miclaus <antoniu.miclaus@analog.com>
This one is fine so applied.

Thanks,

Jonathan

> ---
>  drivers/iio/accel/adxl372.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/iio/accel/adxl372.c b/drivers/iio/accel/adxl372.c
> index 46d518a2a029..9e4e8c8d9e9c 100644
> --- a/drivers/iio/accel/adxl372.c
> +++ b/drivers/iio/accel/adxl372.c
> @@ -295,7 +295,6 @@ struct adxl372_state {
>  	u32				inact_time_ms;
>  	u8				fifo_set_size;
>  	unsigned long			int1_bitmask;
> -	unsigned long			int2_bitmask;
>  	u16				watermark;
>  	__be16				fifo_buf[ADXL372_FIFO_SIZE];
>  	bool				peak_fifo_mode_en;