[PATCH] iio: imu: inv_icm45600: fix INT1 drive bit inverted

[PATCH] iio: imu: inv_icm45600: fix INT1 drive bit inverted

[Jean-Baptiste Maneyrol via B4 Relay]

From: Jean-Baptiste Maneyrol <jean-baptiste.maneyrol@tdk.com>

Drive bit must be set for open-drain mode and be cleared for push-pull
mode.

Fixes: 06674a72cf7a ("iio: imu: inv_icm45600: add buffer support in iio devices")
Signed-off-by: Jean-Baptiste Maneyrol <jean-baptiste.maneyrol@tdk.com>
Cc: stable@vger.kernel.org
---
 drivers/iio/imu/inv_icm45600/inv_icm45600.h      | 2 +-
 drivers/iio/imu/inv_icm45600/inv_icm45600_core.c | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/iio/imu/inv_icm45600/inv_icm45600.h b/drivers/iio/imu/inv_icm45600/inv_icm45600.h
index c5b5446f6c3b43150512bcc4357cee385080b634..1c796d4b2a4038203f734f80d7bf7bad138c3497 100644
--- a/drivers/iio/imu/inv_icm45600/inv_icm45600.h
+++ b/drivers/iio/imu/inv_icm45600/inv_icm45600.h
@@ -205,7 +205,7 @@ struct inv_icm45600_sensor_state {
 #define INV_ICM45600_SPI_SLEW_RATE_38NS			0
 
 #define INV_ICM45600_REG_INT1_CONFIG2			0x0018
-#define INV_ICM45600_INT1_CONFIG2_PUSH_PULL		BIT(2)
+#define INV_ICM45600_INT1_CONFIG2_OPEN_DRAIN		BIT(2)
 #define INV_ICM45600_INT1_CONFIG2_LATCHED		BIT(1)
 #define INV_ICM45600_INT1_CONFIG2_ACTIVE_HIGH		BIT(0)
 #define INV_ICM45600_INT1_CONFIG2_ACTIVE_LOW		0x00
diff --git a/drivers/iio/imu/inv_icm45600/inv_icm45600_core.c b/drivers/iio/imu/inv_icm45600/inv_icm45600_core.c
index ab1cb7b9dba435a3280e50ab77cd16e903c7816c..b028044d609a41f6d4b747383323130ded0d2e79 100644
--- a/drivers/iio/imu/inv_icm45600/inv_icm45600_core.c
+++ b/drivers/iio/imu/inv_icm45600/inv_icm45600_core.c
@@ -637,8 +637,8 @@ static int inv_icm45600_irq_init(struct inv_icm45600_state *st, int irq,
 		break;
 	}
 
-	if (!open_drain)
-		val |= INV_ICM45600_INT1_CONFIG2_PUSH_PULL;
+	if (open_drain)
+		val |= INV_ICM45600_INT1_CONFIG2_OPEN_DRAIN;
 
 	ret = regmap_write(st->map, INV_ICM45600_REG_INT1_CONFIG2, val);
 	if (ret)

---
base-commit: d820183f371d9aa8517a1cd21fe6edacf0f94b7f
change-id: 20260205-inv-icm45600-fix-int1-drive-bit-7d12ea3e2cd2

Best regards,
-- 
Jean-Baptiste Maneyrol <jean-baptiste.maneyrol@tdk.com>

Re: [PATCH] iio: imu: inv_icm45600: fix INT1 drive bit inverted

[Andy Shevchenko]

On Thu, Feb 5, 2026 at 11:55 AM Jean-Baptiste Maneyrol via B4 Relay
<devnull+jean-baptiste.maneyrol.tdk.com@kernel.org> wrote:
>
> Drive bit must be set for open-drain mode and be cleared for push-pull
> mode.

Any pointers to the datasheet? (to the particular section / table that
explains this bit)

...

Assuming it's correct, with added reference to the datasheet
Reviewed-by: Andy Shevchenko <andy@kernel.org>

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH] iio: imu: inv_icm45600: fix INT1 drive bit inverted

[Jean-Baptiste Maneyrol]

>From: Andy Shevchenko <andy.shevchenko@gmail.com>
>Sent: Thursday, February 5, 2026 12:32
>To: Jean-Baptiste Maneyrol <Jean-Baptiste.Maneyrol@tdk.com>
>Cc: Remi Buisson <Remi.Buisson@tdk.com>; Jonathan Cameron <jic23@kernel.org>; David Lechner <dlechner@baylibre.com>; Nuno Sá <nuno.sa@analog.com>; Andy Shevchenko <andy@kernel.org>; Jonathan Cameron <Jonathan.Cameron@huawei.com>; linux-iio@vger.kernel.org <linux-iio@vger.kernel.org>; linux-kernel@vger.kernel.org <linux-kernel@vger.kernel.org>; stable@vger.kernel.org <stable@vger.kernel.org>
>Subject: Re: [PATCH] iio: imu: inv_icm45600: fix INT1 drive bit inverted
> 
>On Thu, Feb 5, 2026 at 11: 55 AM Jean-Baptiste Maneyrol via B4 Relay <devnull+jean-baptiste. maneyrol. tdk. com@ kernel. org> wrote: > > Drive bit must be set for open-drain mode and be cleared for push-pull > mode. Any pointers to
>ZjQcmQRYFpfptBannerStart
>This Message Is From an External Sender
>This message came from outside your organization.
> 
>ZjQcmQRYFpfptBannerEnd
>On Thu, Feb 5, 2026 at 11:55 AM Jean-Baptiste Maneyrol via B4 Relay
><devnull+jean-baptiste.maneyrol.tdk.com@kernel.org> wrote:
>>
>> Drive bit must be set for open-drain mode and be cleared for push-pull
>> mode.
>
>Any pointers to the datasheet? (to the particular section / table that
>explains this bit)

Hello Andy,

here is a link to the datasheet:
https://invensense.tdk.com/wp-content/uploads/documentation/DS-000576_ICM-45605.pdf

The register bits are described in section 17.23 (page 72).

Thanks,
JB

>
>...
>
>Assuming it's correct, with added reference to the datasheet
>Reviewed-by: Andy Shevchenko <andy@kernel.org>
>
>-- 
>With Best Regards,
>Andy Shevchenko
>

Re: [PATCH] iio: imu: inv_icm45600: fix INT1 drive bit inverted

[Andy Shevchenko]

On Thu, Feb 05, 2026 at 12:29:32PM +0000, Jean-Baptiste Maneyrol wrote:
> >From: Andy Shevchenko <andy.shevchenko@gmail.com>
> >Sent: Thursday, February 5, 2026 12:32
> >On Thu, Feb 5, 2026 at 11:55 AM Jean-Baptiste Maneyrol via B4 Relay
> ><devnull+jean-baptiste.maneyrol.tdk.com@kernel.org> wrote:
> >>
> >> Drive bit must be set for open-drain mode and be cleared for push-pull
> >> mode.
> >
> >Any pointers to the datasheet? (to the particular section / table that
> >explains this bit)
> 
> here is a link to the datasheet:
> https://invensense.tdk.com/wp-content/uploads/documentation/DS-000576_ICM-45605.pdf
> 
> The register bits are described in section 17.23 (page 72).

Yes, please add this reference to the commit message
(URL might not be needed, though; just free text).

-- 
With Best Regards,
Andy Shevchenko