[PATCH v3 0/2] iio: gyro: mpu3050: fix pm_runtime error handling

[PATCH v3 0/2] iio: gyro: mpu3050: fix pm_runtime error handling

[Antoniu Miclaus]

Fix pm_runtime error handling across the mpu3050 driver. The existing
code uses pm_runtime_get_sync() without checking return values, allowing
operations to proceed even when the device fails to resume.

Replace pm_runtime_get_sync() with pm_runtime_resume_and_get() and
propagate errors appropriately. Unlike pm_runtime_get_sync(), the usage
count is not incremented on error.

Changes in v3:
- Rename patches to focus on fix rather than API change
- Add Fixes: tags
- Collect Reviewed-by

Antoniu Miclaus (2):
  iio: gyro: mpu3050-i2c: fix pm_runtime error handling in bypass_select
  iio: gyro: mpu3050-core: fix pm_runtime error handling

 drivers/iio/gyro/mpu3050-core.c | 17 +++++++++++++----
 drivers/iio/gyro/mpu3050-i2c.c  |  3 +--
 2 files changed, 14 insertions(+), 6 deletions(-)

-- 
2.43.0

[PATCH v3 0/2] iio: gyro: mpu3050: fix pm_runtime error handling

[Antoniu Miclaus]

Fix pm_runtime error handling across the mpu3050 driver. The existing
code uses pm_runtime_get_sync() without checking return values, allowing
operations to proceed even when the device fails to resume.

Replace pm_runtime_get_sync() with pm_runtime_resume_and_get() and
propagate errors appropriately. Unlike pm_runtime_get_sync(), the usage
count is not incremented on error.

Changes in v3:
- Rename patches to focus on fix rather than API change
- Add Fixes: tags
- Collect Reviewed-by

Antoniu Miclaus (2):
  iio: gyro: mpu3050-i2c: fix pm_runtime error handling in bypass_select
  iio: gyro: mpu3050-core: fix pm_runtime error handling

 drivers/iio/gyro/mpu3050-core.c | 17 +++++++++++++----
 drivers/iio/gyro/mpu3050-i2c.c  |  3 +--
 2 files changed, 14 insertions(+), 6 deletions(-)

-- 
2.43.0

[PATCH v3 1/2] iio: gyro: mpu3050-i2c: fix pm_runtime error handling

[Antoniu Miclaus]

pm_runtime_get_sync() does not check its return value, and the
function always returns success. This allows I2C mux operations to
proceed even when the device fails to resume.

Use pm_runtime_resume_and_get() and propagate its return value to
properly handle resume failures.

Fixes: 3904b28efb2c ("iio: gyro: Add driver for the MPU-3050 gyroscope")
Signed-off-by: Antoniu Miclaus <antoniu.miclaus@analog.com>
---
Changes in v3:
- Rename patch to focus on fix rather than API change
- Reword commit message
- Add Fixes: tag
 drivers/iio/gyro/mpu3050-i2c.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/iio/gyro/mpu3050-i2c.c b/drivers/iio/gyro/mpu3050-i2c.c
index 092878f2c886..6549b22e643d 100644
--- a/drivers/iio/gyro/mpu3050-i2c.c
+++ b/drivers/iio/gyro/mpu3050-i2c.c
@@ -19,8 +19,7 @@ static int mpu3050_i2c_bypass_select(struct i2c_mux_core *mux, u32 chan_id)
 	struct mpu3050 *mpu3050 = i2c_mux_priv(mux);
 
 	/* Just power up the device, that is all that is needed */
-	pm_runtime_get_sync(mpu3050->dev);
-	return 0;
+	return pm_runtime_resume_and_get(mpu3050->dev);
 }
 
 static int mpu3050_i2c_bypass_deselect(struct i2c_mux_core *mux, u32 chan_id)
-- 
2.43.0

[PATCH v3 2/2] iio: gyro: mpu3050-core: fix pm_runtime error handling

[Antoniu Miclaus]

pm_runtime_get_sync() does not check its return value, allowing the
driver to access hardware that may fail to resume. Use
pm_runtime_resume_and_get() which propagates errors and avoids
incrementing the usage count on failure.

In preenable, add pm_runtime_put_autosuspend() on set_8khz_samplerate()
failure since postdisable does not run when preenable fails.

Fixes: 3904b28efb2c ("iio: gyro: Add driver for the MPU-3050 gyroscope")
Reviewed-by: Linus Walleij <linusw@kernel.org>
Signed-off-by: Antoniu Miclaus <antoniu.miclaus@analog.com>
---
Changes in v3:
- Rename patch to focus on fix rather than API change
- Reword commit message
- Add Fixes: tag

 drivers/iio/gyro/mpu3050-core.c | 17 +++++++++++++----
 1 file changed, 13 insertions(+), 4 deletions(-)

diff --git a/drivers/iio/gyro/mpu3050-core.c b/drivers/iio/gyro/mpu3050-core.c
index ee2fcd20545d..1cc421eb4782 100644
--- a/drivers/iio/gyro/mpu3050-core.c
+++ b/drivers/iio/gyro/mpu3050-core.c
@@ -322,7 +322,9 @@ static int mpu3050_read_raw(struct iio_dev *indio_dev,
 		}
 	case IIO_CHAN_INFO_RAW:
 		/* Resume device */
-		pm_runtime_get_sync(mpu3050->dev);
+		ret = pm_runtime_resume_and_get(mpu3050->dev);
+		if (ret)
+			return ret;
 		mutex_lock(&mpu3050->lock);
 
 		ret = mpu3050_set_8khz_samplerate(mpu3050);
@@ -647,12 +649,19 @@ static irqreturn_t mpu3050_trigger_handler(int irq, void *p)
 static int mpu3050_buffer_preenable(struct iio_dev *indio_dev)
 {
 	struct mpu3050 *mpu3050 = iio_priv(indio_dev);
+	int ret;
 
-	pm_runtime_get_sync(mpu3050->dev);
+	ret = pm_runtime_resume_and_get(mpu3050->dev);
+	if (ret)
+		return ret;
 
 	/* Unless we have OUR trigger active, run at full speed */
-	if (!mpu3050->hw_irq_trigger)
-		return mpu3050_set_8khz_samplerate(mpu3050);
+	if (!mpu3050->hw_irq_trigger) {
+		ret = mpu3050_set_8khz_samplerate(mpu3050);
+		if (ret)
+			pm_runtime_put_autosuspend(mpu3050->dev);
+		return ret;
+	}
 
 	return 0;
 }
-- 
2.43.0

RE: [PATCH v3 0/2] iio: gyro: mpu3050: fix pm_runtime error handling

[Miclaus, Antoniu]

> -----Original Message-----
> From: Antoniu Miclaus <antoniu.miclaus@analog.com>
> Sent: Monday, February 9, 2026 1:33 PM
> To: Linus Walleij <linusw@kernel.org>; Jonathan Cameron <jic23@kernel.org>;
> David Lechner <dlechner@baylibre.com>; Sa, Nuno <Nuno.Sa@analog.com>;
> Andy Shevchenko <andy@kernel.org>; linux-iio@vger.kernel.org; linux-
> kernel@vger.kernel.org
> Cc: Miclaus, Antoniu <Antoniu.Miclaus@analog.com>
> Subject: [PATCH v3 0/2] iio: gyro: mpu3050: fix pm_runtime error handling
> 
> Fix pm_runtime error handling across the mpu3050 driver. The existing
> code uses pm_runtime_get_sync() without checking return values, allowing
> operations to proceed even when the device fails to resume.
> 
> Replace pm_runtime_get_sync() with pm_runtime_resume_and_get() and
> propagate errors appropriately. Unlike pm_runtime_get_sync(), the usage
> count is not incremented on error.
> 
> Changes in v3:
> - Rename patches to focus on fix rather than API change
> - Add Fixes: tags
> - Collect Reviewed-by

Sent by mistake, only the cover-letter. This patch can be ignored.

> Antoniu Miclaus (2):
>   iio: gyro: mpu3050-i2c: fix pm_runtime error handling in bypass_select
>   iio: gyro: mpu3050-core: fix pm_runtime error handling
> 
>  drivers/iio/gyro/mpu3050-core.c | 17 +++++++++++++----
>  drivers/iio/gyro/mpu3050-i2c.c  |  3 +--
>  2 files changed, 14 insertions(+), 6 deletions(-)
> 
> --
> 2.43.0

Re: [PATCH v3 0/2] iio: gyro: mpu3050: fix pm_runtime error handling

[Andy Shevchenko]

On Mon, Feb 09, 2026 at 12:13:28PM +0000, Miclaus, Antoniu wrote:
> > -----Original Message-----
> > From: Antoniu Miclaus <antoniu.miclaus@analog.com>
> > Sent: Monday, February 9, 2026 1:33 PM

> > Fix pm_runtime error handling across the mpu3050 driver. The existing
> > code uses pm_runtime_get_sync() without checking return values, allowing
> > operations to proceed even when the device fails to resume.
> > 
> > Replace pm_runtime_get_sync() with pm_runtime_resume_and_get() and
> > propagate errors appropriately. Unlike pm_runtime_get_sync(), the usage
> > count is not incremented on error.
> > 
> > Changes in v3:
> > - Rename patches to focus on fix rather than API change
> > - Add Fixes: tags
> > - Collect Reviewed-by
> 
> Sent by mistake, only the cover-letter. This patch can be ignored.

You lost me. Did you send the cover-letter by a mistake, or
the entire series? "This patch" is absent in the cover letter
and for the matter of fact, there are two patches in it.

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH v3 2/2] iio: gyro: mpu3050-core: fix pm_runtime error handling

[Andy Shevchenko]

On Mon, Feb 09, 2026 at 02:02:16PM +0200, Antoniu Miclaus wrote:
> pm_runtime_get_sync() does not check its return value, allowing the
> driver to access hardware that may fail to resume. Use

Try to make lines more filled, this can be achieved by moving "the":

  pm_runtime_get_sync() does not check its return value, allowing
  the driver to access hardware that may fail to resume. Use

> pm_runtime_resume_and_get() which propagates errors and avoids
> incrementing the usage count on failure.
> 
> In preenable, add pm_runtime_put_autosuspend() on set_8khz_samplerate()
> failure since postdisable does not run when preenable fails.

...

>  static int mpu3050_buffer_preenable(struct iio_dev *indio_dev)
>  {
>  	struct mpu3050 *mpu3050 = iio_priv(indio_dev);
> +	int ret;
>  
> -	pm_runtime_get_sync(mpu3050->dev);
> +	ret = pm_runtime_resume_and_get(mpu3050->dev);
> +	if (ret)
> +		return ret;
>  
>  	/* Unless we have OUR trigger active, run at full speed */
> -	if (!mpu3050->hw_irq_trigger)
> -		return mpu3050_set_8khz_samplerate(mpu3050);
> +	if (!mpu3050->hw_irq_trigger) {
> +		ret = mpu3050_set_8khz_samplerate(mpu3050);
> +		if (ret)
> +			pm_runtime_put_autosuspend(mpu3050->dev);

> +		return ret;
> +	}
>  
>  	return 0;

These 4 LoCs can be replaced with

	return ret;

>  }

-- 
With Best Regards,
Andy Shevchenko

RE: [PATCH v3 0/2] iio: gyro: mpu3050: fix pm_runtime error handling

[Miclaus, Antoniu]

--
Antoniu Miclăuş

> -----Original Message-----
> From: Andy Shevchenko <andriy.shevchenko@intel.com>
> Sent: Monday, February 9, 2026 3:32 PM
> To: Miclaus, Antoniu <Antoniu.Miclaus@analog.com>
> Cc: Linus Walleij <linusw@kernel.org>; Jonathan Cameron <jic23@kernel.org>;
> David Lechner <dlechner@baylibre.com>; Sa, Nuno <Nuno.Sa@analog.com>;
> Andy Shevchenko <andy@kernel.org>; linux-iio@vger.kernel.org; linux-
> kernel@vger.kernel.org
> Subject: Re: [PATCH v3 0/2] iio: gyro: mpu3050: fix pm_runtime error
> handling
> 
> [External]
> 
> On Mon, Feb 09, 2026 at 12:13:28PM +0000, Miclaus, Antoniu wrote:
> > > -----Original Message-----
> > > From: Antoniu Miclaus <antoniu.miclaus@analog.com>
> > > Sent: Monday, February 9, 2026 1:33 PM
> 
> > > Fix pm_runtime error handling across the mpu3050 driver. The existing
> > > code uses pm_runtime_get_sync() without checking return values,
> allowing
> > > operations to proceed even when the device fails to resume.
> > >
> > > Replace pm_runtime_get_sync() with pm_runtime_resume_and_get() and
> > > propagate errors appropriately. Unlike pm_runtime_get_sync(), the usage
> > > count is not incremented on error.
> > >
> > > Changes in v3:
> > > - Rename patches to focus on fix rather than API change
> > > - Add Fixes: tags
> > > - Collect Reviewed-by
> >
> > Sent by mistake, only the cover-letter. This patch can be ignored.
> 
> You lost me. Did you send the cover-letter by a mistake, or
> the entire series? "This patch" is absent in the cover letter
> and for the matter of fact, there are two patches in it.

I sent by mistake only the cover letter first.

Then I resent the entire patchseries properly (including cover letter).

> --
> With Best Regards,
> Andy Shevchenko
> 

Re: [PATCH v3 0/2] iio: gyro: mpu3050: fix pm_runtime error handling

[Andy Shevchenko]

On Mon, Feb 09, 2026 at 01:39:57PM +0000, Miclaus, Antoniu wrote:
> > -----Original Message-----
> > From: Andy Shevchenko <andriy.shevchenko@intel.com>
> > Sent: Monday, February 9, 2026 3:32 PM
> > On Mon, Feb 09, 2026 at 12:13:28PM +0000, Miclaus, Antoniu wrote:
> > > > -----Original Message-----
> > > > From: Antoniu Miclaus <antoniu.miclaus@analog.com>
> > > > Sent: Monday, February 9, 2026 1:33 PM

...

> > > Sent by mistake, only the cover-letter. This patch can be ignored.
> > 
> > You lost me. Did you send the cover-letter by a mistake, or
> > the entire series? "This patch" is absent in the cover letter
> > and for the matter of fact, there are two patches in it.
> 
> I sent by mistake only the cover letter first.
> 
> Then I resent the entire patchseries properly (including cover letter).

Ah, okay, that explains me having two same mails for cover-letter.

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH v3 2/2] iio: gyro: mpu3050-core: fix pm_runtime error handling

[Nuno Sá]

On Mon, 2026-02-09 at 14:02 +0200, Antoniu Miclaus wrote:
> pm_runtime_get_sync() does not check its return value, allowing the

I don't want to be too picky but the above is a bit of bad wording :).
pm_runtime_get_sync() indeed returns 'int' so the caller is the one not checking
it. So we have two things happening:

1) We don't want to ignore the return value from the PM API;
2) We don't want to, unconditionally, increment the device usage count and hence pivot to
use pm_runtime_resume_and_get()

- Nuno Sá

> driver to access hardware that may fail to resume. Use
> pm_runtime_resume_and_get() which propagates errors and avoids
> incrementing the usage count on failure.
> 
> In preenable, add pm_runtime_put_autosuspend() on set_8khz_samplerate()
> failure since postdisable does not run when preenable fails.
> 
> Fixes: 3904b28efb2c ("iio: gyro: Add driver for the MPU-3050 gyroscope")
> Reviewed-by: Linus Walleij <linusw@kernel.org>
> Signed-off-by: Antoniu Miclaus <antoniu.miclaus@analog.com>
> ---
> Changes in v3:
> - Rename patch to focus on fix rather than API change
> - Reword commit message
> - Add Fixes: tag
> 
>  drivers/iio/gyro/mpu3050-core.c | 17 +++++++++++++----
>  1 file changed, 13 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/iio/gyro/mpu3050-core.c b/drivers/iio/gyro/mpu3050-core.c
> index ee2fcd20545d..1cc421eb4782 100644
> --- a/drivers/iio/gyro/mpu3050-core.c
> +++ b/drivers/iio/gyro/mpu3050-core.c
> @@ -322,7 +322,9 @@ static int mpu3050_read_raw(struct iio_dev *indio_dev,
>  		}
>  	case IIO_CHAN_INFO_RAW:
>  		/* Resume device */
> -		pm_runtime_get_sync(mpu3050->dev);
> +		ret = pm_runtime_resume_and_get(mpu3050->dev);
> +		if (ret)
> +			return ret;
>  		mutex_lock(&mpu3050->lock);
>  
>  		ret = mpu3050_set_8khz_samplerate(mpu3050);
> @@ -647,12 +649,19 @@ static irqreturn_t mpu3050_trigger_handler(int irq, void *p)
>  static int mpu3050_buffer_preenable(struct iio_dev *indio_dev)
>  {
>  	struct mpu3050 *mpu3050 = iio_priv(indio_dev);
> +	int ret;
>  
> -	pm_runtime_get_sync(mpu3050->dev);
> +	ret = pm_runtime_resume_and_get(mpu3050->dev);
> +	if (ret)
> +		return ret;
>  
>  	/* Unless we have OUR trigger active, run at full speed */
> -	if (!mpu3050->hw_irq_trigger)
> -		return mpu3050_set_8khz_samplerate(mpu3050);
> +	if (!mpu3050->hw_irq_trigger) {
> +		ret = mpu3050_set_8khz_samplerate(mpu3050);
> +		if (ret)
> +			pm_runtime_put_autosuspend(mpu3050->dev);
> +		return ret;
> +	}
>  
>  	return 0;
>  }