From: David Laight <David.Laight@ACULAB.COM>
To: 'Dave Hansen' <dave.hansen@intel.com>,
Fenghua Yu <fenghua.yu@intel.com>,
Thomas Gleixner <tglx@linutronix.de>,
Borislav Petkov <bp@alien8.de>,
"Dave Hansen" <dave.hansen@linux.intel.com>,
Ingo Molnar <mingo@redhat.com>, "Tony Luck" <tony.luck@intel.com>
Cc: x86 <x86@kernel.org>, linux-kernel <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] x86/split_lock: Enable the split lock detect feature on Raptor Lake P and Alder Lake N CPUs
Date: Sat, 2 Jul 2022 10:32:33 +0000 [thread overview]
Message-ID: <aa0ee519f6dc49f9b866abb438bde1e1@AcuMS.aculab.com> (raw)
In-Reply-To: <e333c40a-13da-8def-56db-9b61ef46e296@intel.com>
From: Dave Hansen
> Sent: 01 July 2022 15:20
>
> On 7/1/22 06:19, Fenghua Yu wrote:
> > These CPU models support the split lock detect feature. Add them to
> > the x86_cpu_ids match table.
>
> When is there going to be architectural detection for this feature? Or,
> is the plan to just keep adding CPUs to this table as they are available.
I saw that as well, it really doesn't scale at all.
Isn't it usual for the flag to not be settable on old cpu?
In any case the flag could be set and then a 'split lock'
transfer and see if it faults.
OTOH why bother with the test?
Unless you want to report that the 'split lock' detection
doesn't work?
Or did Intel really screw this up and use a flag that has
some other undesirable effect on (at least some) older cpu.
David
-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)
next prev parent reply other threads:[~2022-07-02 10:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-01 13:19 [PATCH] x86/split_lock: Enable the split lock detect feature on Raptor Lake P and Alder Lake N CPUs Fenghua Yu
2022-07-01 14:20 ` Dave Hansen
2022-07-02 10:32 ` David Laight [this message]
2022-07-05 19:46 ` Dave Hansen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aa0ee519f6dc49f9b866abb438bde1e1@AcuMS.aculab.com \
--to=david.laight@aculab.com \
--cc=bp@alien8.de \
--cc=dave.hansen@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=fenghua.yu@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox