From: Osama Abdelkader <osama.abdelkader@gmail.com>
To: Markus Elfring <Markus.Elfring@web.de>
Cc: linux-riscv@lists.infradead.org,
Albert Ou <aou@eecs.berkeley.edu>,
Alexandre Ghiti <alex@ghiti.fr>,
Andrew Morton <akpm@linux-foundation.org>,
Lorenzo Stoakes <lorenzo.stoakes@oracle.com>,
Oscar Salvador <osalvador@suse.de>,
Palmer Dabbelt <palmer@dabbelt.com>,
Paul Walmsley <pjw@kernel.org>,
Qi Zheng <zhengqi.arch@bytedance.com>,
Suren Baghdasaryan <surenb@google.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] riscv: mm: add null check for find_vm_area in set_memory
Date: Mon, 16 Mar 2026 16:21:41 +0100 [thread overview]
Message-ID: <abgfx9gpUA6vWvZA@osama> (raw)
In-Reply-To: <71d162ec-8745-4391-a94c-e5b0bacb4fe1@web.de>
On Mon, Mar 16, 2026 at 11:22:26AM +0100, Markus Elfring wrote:
> > find_vm_area() can return NULL. Add a null check to avoid potential
> > null pointer dereference, matching the pattern used by other arches.
>
> 1. Were any source code analysis tools involved here?
No, both were found during manual review and compare with arm64.
>
> 2. How do you think about to add any tags (like “Fixes” and “Cc”) accordingly?
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v7.0-rc4#n145
>
> 3. Would you like to refer to the function “__set_memory” in the summary phrase?
>
Done, I just sent v2, appreciate your review.
>
> Regards,
> Markus
Thanks,
Osama
next prev parent reply other threads:[~2026-03-16 15:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-14 22:28 [PATCH] riscv: mm: add null check for find_vm_area in set_memory Osama Abdelkader
2026-03-16 10:22 ` Markus Elfring
2026-03-16 15:21 ` Osama Abdelkader [this message]
2026-03-16 16:34 ` Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=abgfx9gpUA6vWvZA@osama \
--to=osama.abdelkader@gmail.com \
--cc=Markus.Elfring@web.de \
--cc=akpm@linux-foundation.org \
--cc=alex@ghiti.fr \
--cc=aou@eecs.berkeley.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=osalvador@suse.de \
--cc=palmer@dabbelt.com \
--cc=pjw@kernel.org \
--cc=surenb@google.com \
--cc=zhengqi.arch@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox