From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Mark Brown <broonie@kernel.org>
Cc: "Peng Fan (OSS)" <peng.fan@oss.nxp.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Frieder Schrempf <frieder.schrempf@kontron.de>,
Joy Zou <joy.zou@nxp.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] regulator: pca9450: Correct interrupt type
Date: Mon, 16 Mar 2026 17:40:54 +0100 [thread overview]
Message-ID: <abgyluG3HU37Rcqu@black.igk.intel.com> (raw)
In-Reply-To: <cfd6f551-05ac-4157-9bf9-bca2f6cc1956@sirena.org.uk>
On Tue, Mar 10, 2026 at 03:34:35PM +0000, Mark Brown wrote:
> On Tue, Mar 10, 2026 at 01:24:44PM +0000, Peng Fan (OSS) wrote:
>
> > BTW, I am also thinking whether we need to drop setting
> > IRQF_TIRRGER_[X] when calling request irq in this driver.
>
> I can't remember off hand what the effect of that is TBH. I'm not sure
> how it'd interact with incorrectly specified DTs?
One may need a quirk for incorrectly specified DTs,
basically something like
flags = irq_...get flags...(...);
if (flags & BAD!)
...issue warning and fix the flags...
ret = devm_irq_...(flags)
...
Also consider dropping dup error message as devm_*_irq*() already does that
for us.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-03-16 16:40 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-10 4:25 [PATCH 0/2] regulator: pca9450: Minor fixes Peng Fan (OSS)
2026-03-10 4:25 ` [PATCH 1/2] regulator: pca9450: Correct interrupt type Peng Fan (OSS)
2026-03-10 13:15 ` Mark Brown
2026-03-10 13:24 ` Peng Fan (OSS)
2026-03-10 15:34 ` Mark Brown
2026-03-16 16:40 ` Andy Shevchenko [this message]
2026-03-23 10:58 ` Laurent Pinchart
2026-03-23 12:38 ` Peng Fan
2026-03-23 13:49 ` Laurent Pinchart
2026-03-10 4:25 ` [PATCH 2/2] regulator: pca9450: Correct probed name for PCA9452 Peng Fan (OSS)
2026-03-11 10:47 ` [PATCH 0/2] regulator: pca9450: Minor fixes Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=abgyluG3HU37Rcqu@black.igk.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=broonie@kernel.org \
--cc=frieder.schrempf@kontron.de \
--cc=joy.zou@nxp.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peng.fan@oss.nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox