From: Vineet Gupta <vgupta@kernel.org>
To: Bagas Sanjaya <bagasdotme@gmail.com>,
Vineet Gupta <vgupta@kernel.org>,
Jilin Yuan <yuanjilin@cdjrlc.com>
Cc: Julia.Lawall@inria.fr, rdunlap@infradead.org,
linux-snps-arc@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ARC:mm:Fix syntax errors in comments
Date: Thu, 23 Jun 2022 18:57:58 -0700 [thread overview]
Message-ID: <ac0b07c8-0cd4-6ab4-2939-ead4c813ef78@kernel.org> (raw)
In-Reply-To: <89bc29c5-ad82-4f20-2855-44e57b043c49@gmail.com>
On 6/23/22 00:56, Bagas Sanjaya wrote:
>> In an ideal world yes. But sometimes maintainer complain to break whitespacxe fixes and such into independent fix. Also as someone said later in the thread, for somebody just getting into kernel and figuring out patch submission etc this could be a perfect dry run and helps improve the code anyways.
>>
> Seems like you missed the point that it's OK to have typofixes while
> doing other real changes (like refactoring) in the same patch.
No I did not.
> Quoting from [1]:
>
>> My opinion is that trivial patches like this are fine as a starting
>> point for new contributors, which is why I acked the previous patch from
>> you guys. However, if we start getting two of these every week it just
>> adds more maintenance burden than it's worth.
> I tend to agree with the last sentence of above quote. Let's pretend that
> I'm the tree maintainer. Besides reviewing real change patches, I get
> flooded by these similar minor cleanup patches that I need to review.
> Some (but not all) these patches have issues (say subject or description
> error) that are repeated.
"Repeated" is the key - First time I'd politely tell them to DTRT but
will just ignore if things continue.
> Lazily speaking, I'd like to privately notice the
> submitter about the situation, and I withhold these for now.
Funny that you say this: ever since this got posted I now see 3 patches
for typo fixes :-)
But it is something in maintainers purview and for now i'm ok.
Thx,
-Vineet
next prev parent reply other threads:[~2022-06-24 1:58 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-22 8:04 [PATCH] ARC:mm:Fix syntax errors in comments Jilin Yuan
2022-06-22 8:30 ` Bagas Sanjaya
2022-06-22 8:42 ` Shahab Vahedi
2022-06-22 9:16 ` Julia Lawall
2022-06-22 9:25 ` Shahab Vahedi
2022-06-22 9:38 ` Julia Lawall
2022-06-22 13:20 ` Bagas Sanjaya
2022-06-22 13:46 ` Julia Lawall
2022-06-22 14:10 ` Conor.Dooley
2022-06-23 2:50 ` Vineet Gupta
2022-06-23 7:56 ` Bagas Sanjaya
2022-06-24 1:57 ` Vineet Gupta [this message]
2022-06-24 3:16 ` Bagas Sanjaya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ac0b07c8-0cd4-6ab4-2939-ead4c813ef78@kernel.org \
--to=vgupta@kernel.org \
--cc=Julia.Lawall@inria.fr \
--cc=bagasdotme@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-snps-arc@lists.infradead.org \
--cc=rdunlap@infradead.org \
--cc=yuanjilin@cdjrlc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox