public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Vineet Gupta <vgupta@kernel.org>
To: Bagas Sanjaya <bagasdotme@gmail.com>, Jilin Yuan <yuanjilin@cdjrlc.com>
Cc: vgupta@kernel.org, Julia.Lawall@inria.fr, rdunlap@infradead.org,
	linux-snps-arc@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ARC:mm:Fix syntax errors in comments
Date: Wed, 22 Jun 2022 19:50:39 -0700	[thread overview]
Message-ID: <d104124c-5196-bc80-b3e3-0ab55f0cc35e@kernel.org> (raw)
In-Reply-To: <YrLTCXLrr3HB39lv@debian.me>



On 6/22/22 01:30, Bagas Sanjaya wrote:
>> - * If the U-mapping is not congruent to to K-mapping, former needs flushing.
>> + * If the U-mapping is not congruent to K-mapping, former needs flushing.
>>    */
>>   void flush_dcache_page(struct page *page)
>>   {
> The patch is OK, but its subject is wrong.

Right.

> The patch above isn't fixing any syntax errors, but rather minor cleanup.
> The subject should have been "Remove duplicate 'to' in the
> flush_dcache_page() comment".

I'd just say "ARC: mm: fix typos"

> I think that this kind of cleanup patches (typofixes) are best done
> as part of **actual** work on the code in question (for example
> refactoring or fixing build errors).

In an ideal world yes. But sometimes maintainer complain to break 
whitespacxe fixes and such into independent fix. Also as someone said 
later in the thread, for somebody just getting into kernel and figuring 
out patch submission etc this could be a perfect dry run and helps 
improve the code anyways.

-Vineet

  parent reply	other threads:[~2022-06-23  2:50 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-22  8:04 [PATCH] ARC:mm:Fix syntax errors in comments Jilin Yuan
2022-06-22  8:30 ` Bagas Sanjaya
2022-06-22  8:42   ` Shahab Vahedi
2022-06-22  9:16     ` Julia Lawall
2022-06-22  9:25       ` Shahab Vahedi
2022-06-22  9:38         ` Julia Lawall
2022-06-22 13:20           ` Bagas Sanjaya
2022-06-22 13:46             ` Julia Lawall
2022-06-22 14:10               ` Conor.Dooley
2022-06-23  2:50   ` Vineet Gupta [this message]
2022-06-23  7:56     ` Bagas Sanjaya
2022-06-24  1:57       ` Vineet Gupta
2022-06-24  3:16         ` Bagas Sanjaya

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d104124c-5196-bc80-b3e3-0ab55f0cc35e@kernel.org \
    --to=vgupta@kernel.org \
    --cc=Julia.Lawall@inria.fr \
    --cc=bagasdotme@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-snps-arc@lists.infradead.org \
    --cc=rdunlap@infradead.org \
    --cc=yuanjilin@cdjrlc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox