From: Dan Carpenter <error27@gmail.com>
To: Adith Joshua <adithalex29@gmail.com>
Cc: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org, straube.linux@gmail.com
Subject: Re: [PATCH] staging: rtl8723bs: replace magic numbers with named constants
Date: Mon, 13 Apr 2026 08:41:00 +0300 [thread overview]
Message-ID: <adyB7AAjC9m5so0d@stanley.mountain> (raw)
In-Reply-To: <CAFvcH2DQJtB6B9L+SMgg_aPXGe96hw2i6+C1N0uhapHvJQHd2w@mail.gmail.com>
On Mon, Apr 13, 2026 at 10:51:16AM +0530, Adith Joshua wrote:
> Hi Dan, Luka,
>
> Thanks for the review.
>
> Made some careless errors there... sorry about that
>
> Looking at it again, I see that the BCNTCFG field mapping in my patch is
> wrong (I swapped AIFS and CW in the naming). The TBTT_PROHIBIT suffix was
> also an assumption based on a vague comment, which I shouldn’t have relied
> on.
>
> I was looking at:
> https://android.googlesource.com/kernel/msm/+/android-7.1.0_r0.2/drivers/staging/rtl8188eu/include/rtl8188e_spec.h#296
>
> and also cross-referencing with rtw88:
> drivers/net/wireless/realtek/rtw88/reg.h
>
> And no, this wasn’t AI generated 🙂(I know the choice of emoji could be
> better)
>
> I'll send a v2 with these corrections.
>
Please don't bother.
This explanation is again far too vague to be checked. I would
prefer to leave it as-is until we are more sure that the information
is correct. Misleading documentation is worse than having none.
regards,
dan carpenter
next prev parent reply other threads:[~2026-04-13 5:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-11 5:28 [PATCH] staging: rtl8723bs: replace magic numbers with named constants Adith-Joshua
2026-04-11 8:07 ` Dan Carpenter
2026-04-11 17:20 ` Luka Gejak
[not found] ` <CAFvcH2CjS=HMxt_Dd04eMAELQtxdB5LYmLa_1TLnJeEuKvR6=Q@mail.gmail.com>
2026-04-12 12:57 ` Dan Carpenter
[not found] ` <CAFvcH2DQJtB6B9L+SMgg_aPXGe96hw2i6+C1N0uhapHvJQHd2w@mail.gmail.com>
2026-04-13 5:41 ` Dan Carpenter [this message]
2026-04-11 17:15 ` Luka Gejak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=adyB7AAjC9m5so0d@stanley.mountain \
--to=error27@gmail.com \
--cc=adithalex29@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=straube.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox