From: "H. Peter Anvin" <hpa@zytor.com>
To: Jacob Pan <jacob.jun.pan@linux.intel.com>,
X86 Kernel <x86@kernel.org>, LKML <linux-kernel@vger.kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Dave Hansen <dave.hansen@intel.com>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
linux-perf-users@vger.kernel.org,
Peter Zijlstra <peterz@infradead.org>
Cc: Andi Kleen <andi.kleen@intel.com>, Xin Li <xin3.li@intel.com>
Subject: Re: [PATCH 4/6] x86/irq: Process nmi sources in NMI handler
Date: Wed, 29 May 2024 14:12:19 -0700 [thread overview]
Message-ID: <ae870a38-e7ee-4334-ba4d-ca3e4e17a53d@zytor.com> (raw)
In-Reply-To: <20240529203325.3039243-5-jacob.jun.pan@linux.intel.com>
On 5/29/24 13:33, Jacob Pan wrote:
> +
> + rcu_read_lock();
> + /* Bit 0 is for unknown NMI sources, skip it. */
> + for_each_set_bit_from(vec, &source_bitmask, NR_NMI_SOURCE_VECTORS) {
> + a = rcu_dereference(nmiaction_src_table[vec]);
> + if (!a) {
> + pr_warn_ratelimited("NMI received %d no handler", vec);
> + continue;
> + }
In this case, you should assume some chipset hardware or VMM is giving
you garbage in the event bitmask, and treat it as if bit 0 were set.
-hpa
next prev parent reply other threads:[~2024-05-29 21:12 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-29 20:33 [PATCH 0/6] Add support for NMI source reporting Jacob Pan
2024-05-29 20:33 ` [PATCH 1/6] x86/irq: Add enumeration of NMI source reporting CPU feature Jacob Pan
2024-05-29 20:49 ` H. Peter Anvin
2024-05-30 16:19 ` Jacob Pan
2024-05-30 20:39 ` Jacob Pan
2024-05-29 20:33 ` [PATCH 2/6] x86/irq: Extend NMI handler registration interface to include source Jacob Pan
2024-05-29 20:59 ` H. Peter Anvin
2024-05-30 17:49 ` Jacob Pan
2024-05-29 20:33 ` [PATCH 3/6] x86/irq: Factor out common NMI handling code Jacob Pan
2024-05-29 20:33 ` [PATCH 4/6] x86/irq: Process nmi sources in NMI handler Jacob Pan
2024-05-29 20:47 ` H. Peter Anvin
2024-05-30 16:10 ` Jacob Pan
2024-05-29 21:12 ` H. Peter Anvin [this message]
2024-05-30 17:52 ` Jacob Pan
2024-05-29 20:33 ` [PATCH 5/6] perf/x86: Enable NMI source reporting for perfmon Jacob Pan
2024-05-29 20:33 ` [PATCH 6/6] x86/irq: Enable NMI source on IPIs delivered as NMI Jacob Pan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ae870a38-e7ee-4334-ba4d-ca3e4e17a53d@zytor.com \
--to=hpa@zytor.com \
--cc=andi.kleen@intel.com \
--cc=bp@alien8.de \
--cc=dave.hansen@intel.com \
--cc=jacob.jun.pan@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=xin3.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox