From: Oleg Nesterov <oleg@redhat.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] dequeue_synchronous_signal: kill the unnecessary still-pending check
Date: Mon, 27 Apr 2026 13:34:56 +0200 [thread overview]
Message-ID: <ae9J4P6vZZLbNOWw@redhat.com> (raw)
In-Reply-To: <20260426122723.d1b180bf62b03a94cfe5d2f7@linux-foundation.org>
On 04/26, Andrew Morton wrote:
>
> On Sun, 26 Apr 2026 18:21:29 +0200 Oleg Nesterov <oleg@redhat.com> wrote:
>
> > The signals in SYNCHRONOUS_MASK are not real-time signals, so at most
> > one instance can be queued. Add a static_assert() to ensure.
> >
> > Remove the list_for_each_entry_continue() loop and simplify the code.
>
> AI review asked a thing:
> https://sashiko.dev/#/patchset/ae47bBSixfPpkQBm@redhat.com
OOPS. Indeed I am stupid. I forgor that posixtimer_send_sigqueue() checks
prepare_signal() but not legacy_queue().
Heh ;) Dear Sashiko, thanks for your quick NACK!
Oleg.
prev parent reply other threads:[~2026-04-27 11:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-26 16:21 [PATCH 1/2] dequeue_synchronous_signal: use SI_FROMKERNEL() Oleg Nesterov
2026-04-26 16:21 ` [PATCH 2/2] dequeue_synchronous_signal: kill the unnecessary still-pending check Oleg Nesterov
2026-04-26 19:27 ` Andrew Morton
2026-04-27 11:34 ` Oleg Nesterov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ae9J4P6vZZLbNOWw@redhat.com \
--to=oleg@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox