From: Michael Walle <michael@walle.cc>
To: Potin Lai <potin.lai@quantatw.com>
Cc: Tudor Ambarus <tudor.ambarus@microchip.com>,
Pratyush Yadav <p.yadav@ti.com>,
Miquel Raynal <miquel.raynal@bootlin.com>,
Richard Weinberger <richard@nod.at>,
Vignesh Raghavendra <vigneshr@ti.com>,
Patrick Williams <patrick@stwcx.xyz>,
linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/1] mtd: spi-nor: winbond: Add support for w25q01jv-iq
Date: Tue, 22 Feb 2022 08:24:31 +0100 [thread overview]
Message-ID: <aedb6f8e3d878f487aa7fef147e352b4@walle.cc> (raw)
In-Reply-To: <20220222064227.16724-1-potin.lai@quantatw.com>
Hi,
Am 2022-02-22 07:42, schrieb Potin Lai:
> Add support for winbond w25q01jv-iq chip
>
> root@bletchley:~# cat
> /sys/devices/platform/ahb/1e620000.spi/spi_master/spi0/spi0.0/spi-nor/jedec_id
> ef4021
> root@bletchley:~# cat
> /sys/devices/platform/ahb/1e620000.spi/spi_master/spi0/spi0.0/spi-nor/manufacturer
> winbond
> root@bletchley:~# cat
> /sys/devices/platform/ahb/1e620000.spi/spi_master/spi0/spi0.0/spi-nor/partname
> w25q01jv-iq
> root@bletchley:~# hexdump -C
> /sys/devices/platform/ahb/1e620000.spi/spi_master/spi0/spi0.0/spi-nor/sfdp
> 00000000 53 46 44 50 06 01 01 ff 00 06 01 10 80 00 00 ff
> |SFDP............|
> 00000010 84 00 01 02 d0 00 00 ff 03 00 01 02 f0 00 00 ff
> |................|
> 00000020 ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff
> |................|
> *
> 00000080 e5 20 fb ff ff ff ff 3f 44 eb 08 6b 08 3b 42 bb |.
> .....?D..k.;B.|
> 00000090 fe ff ff ff ff ff 00 00 ff ff 40 eb 0c 20 0f 52 |..........@..
> .R|
> 000000a0 10 d8 00 00 36 02 a6 00 82 ea 14 e2 e9 63 76 33
> |....6........cv3|
> 000000b0 7a 75 7a 75 f7 a2 d5 5c 19 f7 4d ff e9 70 f9 a5
> |zuzu...\..M..p..|
> 000000c0 ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff
> |................|
> 000000d0 ff 0a f0 ff 21 ff dc ff |....!...|
> 000000d8
Can you please provide an md5sum or sha256sum of this file?
>
> Signed-off-by: Potin Lai <potin.lai@quantatw.com>
>
> ---
>
> Changes v1 --> v2:
> - rework patch to work with new flags
>
> ---
> drivers/mtd/spi-nor/winbond.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/mtd/spi-nor/winbond.c
> b/drivers/mtd/spi-nor/winbond.c
> index 59d53b4c39c8..4c088250fe96 100644
> --- a/drivers/mtd/spi-nor/winbond.c
> +++ b/drivers/mtd/spi-nor/winbond.c
> @@ -131,6 +131,8 @@ static const struct flash_info winbond_parts[] = {
> { "w25q512jvq", INFO(0xef4020, 0, 64 * 1024, 1024)
> NO_SFDP_FLAGS(SECT_4K | SPI_NOR_DUAL_READ |
> SPI_NOR_QUAD_READ) },
> + { "w25q01jv-iq", INFO(0xef4021, 0, 64 * 1024, 2048)
name should be "w25q01jvq", see the flash name right before.
With that fixed, and the md5sum above:
Reviewed-by: Michael Walle <michael@walle.cc>
> + PARSE_SFDP },
> };
>
-michael
next prev parent reply other threads:[~2022-02-22 7:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-22 6:42 [PATCH v2 1/1] mtd: spi-nor: winbond: Add support for w25q01jv-iq Potin Lai
2022-02-22 7:24 ` Michael Walle [this message]
2022-02-22 7:37 ` Potin Lai (賴柏廷)
2022-02-22 7:50 ` Michael Walle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aedb6f8e3d878f487aa7fef147e352b4@walle.cc \
--to=michael@walle.cc \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=miquel.raynal@bootlin.com \
--cc=p.yadav@ti.com \
--cc=patrick@stwcx.xyz \
--cc=potin.lai@quantatw.com \
--cc=richard@nod.at \
--cc=tudor.ambarus@microchip.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox