* [PATCH v2 1/1] mtd: spi-nor: winbond: Add support for w25q01jv-iq
@ 2022-02-22 6:42 Potin Lai
2022-02-22 7:24 ` Michael Walle
0 siblings, 1 reply; 4+ messages in thread
From: Potin Lai @ 2022-02-22 6:42 UTC (permalink / raw)
To: Tudor Ambarus, Michael Walle, Pratyush Yadav, Miquel Raynal,
Richard Weinberger, Vignesh Raghavendra
Cc: Patrick Williams, Potin Lai, linux-mtd, linux-kernel
Add support for winbond w25q01jv-iq chip
root@bletchley:~# cat /sys/devices/platform/ahb/1e620000.spi/spi_master/spi0/spi0.0/spi-nor/jedec_id
ef4021
root@bletchley:~# cat /sys/devices/platform/ahb/1e620000.spi/spi_master/spi0/spi0.0/spi-nor/manufacturer
winbond
root@bletchley:~# cat /sys/devices/platform/ahb/1e620000.spi/spi_master/spi0/spi0.0/spi-nor/partname
w25q01jv-iq
root@bletchley:~# hexdump -C /sys/devices/platform/ahb/1e620000.spi/spi_master/spi0/spi0.0/spi-nor/sfdp
00000000 53 46 44 50 06 01 01 ff 00 06 01 10 80 00 00 ff |SFDP............|
00000010 84 00 01 02 d0 00 00 ff 03 00 01 02 f0 00 00 ff |................|
00000020 ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff |................|
*
00000080 e5 20 fb ff ff ff ff 3f 44 eb 08 6b 08 3b 42 bb |. .....?D..k.;B.|
00000090 fe ff ff ff ff ff 00 00 ff ff 40 eb 0c 20 0f 52 |..........@.. .R|
000000a0 10 d8 00 00 36 02 a6 00 82 ea 14 e2 e9 63 76 33 |....6........cv3|
000000b0 7a 75 7a 75 f7 a2 d5 5c 19 f7 4d ff e9 70 f9 a5 |zuzu...\..M..p..|
000000c0 ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff |................|
000000d0 ff 0a f0 ff 21 ff dc ff |....!...|
000000d8
Signed-off-by: Potin Lai <potin.lai@quantatw.com>
---
Changes v1 --> v2:
- rework patch to work with new flags
---
drivers/mtd/spi-nor/winbond.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/mtd/spi-nor/winbond.c b/drivers/mtd/spi-nor/winbond.c
index 59d53b4c39c8..4c088250fe96 100644
--- a/drivers/mtd/spi-nor/winbond.c
+++ b/drivers/mtd/spi-nor/winbond.c
@@ -131,6 +131,8 @@ static const struct flash_info winbond_parts[] = {
{ "w25q512jvq", INFO(0xef4020, 0, 64 * 1024, 1024)
NO_SFDP_FLAGS(SECT_4K | SPI_NOR_DUAL_READ |
SPI_NOR_QUAD_READ) },
+ { "w25q01jv-iq", INFO(0xef4021, 0, 64 * 1024, 2048)
+ PARSE_SFDP },
};
/**
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH v2 1/1] mtd: spi-nor: winbond: Add support for w25q01jv-iq
2022-02-22 6:42 [PATCH v2 1/1] mtd: spi-nor: winbond: Add support for w25q01jv-iq Potin Lai
@ 2022-02-22 7:24 ` Michael Walle
2022-02-22 7:37 ` Potin Lai (賴柏廷)
0 siblings, 1 reply; 4+ messages in thread
From: Michael Walle @ 2022-02-22 7:24 UTC (permalink / raw)
To: Potin Lai
Cc: Tudor Ambarus, Pratyush Yadav, Miquel Raynal, Richard Weinberger,
Vignesh Raghavendra, Patrick Williams, linux-mtd, linux-kernel
Hi,
Am 2022-02-22 07:42, schrieb Potin Lai:
> Add support for winbond w25q01jv-iq chip
>
> root@bletchley:~# cat
> /sys/devices/platform/ahb/1e620000.spi/spi_master/spi0/spi0.0/spi-nor/jedec_id
> ef4021
> root@bletchley:~# cat
> /sys/devices/platform/ahb/1e620000.spi/spi_master/spi0/spi0.0/spi-nor/manufacturer
> winbond
> root@bletchley:~# cat
> /sys/devices/platform/ahb/1e620000.spi/spi_master/spi0/spi0.0/spi-nor/partname
> w25q01jv-iq
> root@bletchley:~# hexdump -C
> /sys/devices/platform/ahb/1e620000.spi/spi_master/spi0/spi0.0/spi-nor/sfdp
> 00000000 53 46 44 50 06 01 01 ff 00 06 01 10 80 00 00 ff
> |SFDP............|
> 00000010 84 00 01 02 d0 00 00 ff 03 00 01 02 f0 00 00 ff
> |................|
> 00000020 ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff
> |................|
> *
> 00000080 e5 20 fb ff ff ff ff 3f 44 eb 08 6b 08 3b 42 bb |.
> .....?D..k.;B.|
> 00000090 fe ff ff ff ff ff 00 00 ff ff 40 eb 0c 20 0f 52 |..........@..
> .R|
> 000000a0 10 d8 00 00 36 02 a6 00 82 ea 14 e2 e9 63 76 33
> |....6........cv3|
> 000000b0 7a 75 7a 75 f7 a2 d5 5c 19 f7 4d ff e9 70 f9 a5
> |zuzu...\..M..p..|
> 000000c0 ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff
> |................|
> 000000d0 ff 0a f0 ff 21 ff dc ff |....!...|
> 000000d8
Can you please provide an md5sum or sha256sum of this file?
>
> Signed-off-by: Potin Lai <potin.lai@quantatw.com>
>
> ---
>
> Changes v1 --> v2:
> - rework patch to work with new flags
>
> ---
> drivers/mtd/spi-nor/winbond.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/mtd/spi-nor/winbond.c
> b/drivers/mtd/spi-nor/winbond.c
> index 59d53b4c39c8..4c088250fe96 100644
> --- a/drivers/mtd/spi-nor/winbond.c
> +++ b/drivers/mtd/spi-nor/winbond.c
> @@ -131,6 +131,8 @@ static const struct flash_info winbond_parts[] = {
> { "w25q512jvq", INFO(0xef4020, 0, 64 * 1024, 1024)
> NO_SFDP_FLAGS(SECT_4K | SPI_NOR_DUAL_READ |
> SPI_NOR_QUAD_READ) },
> + { "w25q01jv-iq", INFO(0xef4021, 0, 64 * 1024, 2048)
name should be "w25q01jvq", see the flash name right before.
With that fixed, and the md5sum above:
Reviewed-by: Michael Walle <michael@walle.cc>
> + PARSE_SFDP },
> };
>
-michael
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH v2 1/1] mtd: spi-nor: winbond: Add support for w25q01jv-iq
2022-02-22 7:24 ` Michael Walle
@ 2022-02-22 7:37 ` Potin Lai (賴柏廷)
2022-02-22 7:50 ` Michael Walle
0 siblings, 1 reply; 4+ messages in thread
From: Potin Lai (賴柏廷) @ 2022-02-22 7:37 UTC (permalink / raw)
To: Michael Walle
Cc: Tudor Ambarus, Pratyush Yadav, Miquel Raynal, Richard Weinberger,
Vignesh Raghavendra, Patrick Williams,
linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org
Michael Walle 於 2022/2/22 下午 03:24 寫道:
> Hi,
>
> Am 2022-02-22 07:42, schrieb Potin Lai:
>> Add support for winbond w25q01jv-iq chip
>>
>> root@bletchley:~# cat
>> /sys/devices/platform/ahb/1e620000.spi/spi_master/spi0/spi0.0/spi-nor/jedec_id
>> ef4021
>> root@bletchley:~# cat
>> /sys/devices/platform/ahb/1e620000.spi/spi_master/spi0/spi0.0/spi-nor/manufacturer
>> winbond
>> root@bletchley:~# cat
>> /sys/devices/platform/ahb/1e620000.spi/spi_master/spi0/spi0.0/spi-nor/partname
>> w25q01jv-iq
>> root@bletchley:~# hexdump -C
>> /sys/devices/platform/ahb/1e620000.spi/spi_master/spi0/spi0.0/spi-nor/sfdp
>> 00000000 53 46 44 50 06 01 01 ff 00 06 01 10 80 00 00 ff |SFDP............|
>> 00000010 84 00 01 02 d0 00 00 ff 03 00 01 02 f0 00 00 ff |................|
>> 00000020 ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff |................|
>> *
>> 00000080 e5 20 fb ff ff ff ff 3f 44 eb 08 6b 08 3b 42 bb |. .....?D..k.;B.|
>> 00000090 fe ff ff ff ff ff 00 00 ff ff 40 eb 0c 20 0f 52 |..........@.. .R|
>> 000000a0 10 d8 00 00 36 02 a6 00 82 ea 14 e2 e9 63 76 33 |....6........cv3|
>> 000000b0 7a 75 7a 75 f7 a2 d5 5c 19 f7 4d ff e9 70 f9 a5 |zuzu...\..M..p..|
>> 000000c0 ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff |................|
>> 000000d0 ff 0a f0 ff 21 ff dc ff |....!...|
>> 000000d8
>
> Can you please provide an md5sum or sha256sum of this file?
root@bletchley:~# md5sum /sys/devices/platform/ahb/1e620000.spi/spi_master/spi0/spi0.0/spi-nor/sfdp
a7b9dbf76e99a33db99e557b6676588a /sys/devices/platform/ahb/1e620000.spi/spi_master/spi0/spi0.0/spi-nor/sfdp
Is it required in commit message, if yes, I will update it.
Thanks,
Potin
>
>>
>> Signed-off-by: Potin Lai <potin.lai@quantatw.com>
>>
>> ---
>>
>> Changes v1 --> v2:
>> - rework patch to work with new flags
>>
>> ---
>> drivers/mtd/spi-nor/winbond.c | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/drivers/mtd/spi-nor/winbond.c b/drivers/mtd/spi-nor/winbond.c
>> index 59d53b4c39c8..4c088250fe96 100644
>> --- a/drivers/mtd/spi-nor/winbond.c
>> +++ b/drivers/mtd/spi-nor/winbond.c
>> @@ -131,6 +131,8 @@ static const struct flash_info winbond_parts[] = {
>> { "w25q512jvq", INFO(0xef4020, 0, 64 * 1024, 1024)
>> NO_SFDP_FLAGS(SECT_4K | SPI_NOR_DUAL_READ |
>> SPI_NOR_QUAD_READ) },
>> + { "w25q01jv-iq", INFO(0xef4021, 0, 64 * 1024, 2048)
>
> name should be "w25q01jvq", see the flash name right before.
>
> With that fixed, and the md5sum above:
>
> Reviewed-by: Michael Walle <michael@walle.cc>
>
>> + PARSE_SFDP },
>> };
>>
>
> -michael
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH v2 1/1] mtd: spi-nor: winbond: Add support for w25q01jv-iq
2022-02-22 7:37 ` Potin Lai (賴柏廷)
@ 2022-02-22 7:50 ` Michael Walle
0 siblings, 0 replies; 4+ messages in thread
From: Michael Walle @ 2022-02-22 7:50 UTC (permalink / raw)
To: Potin Lai (賴柏廷)
Cc: Tudor Ambarus, Pratyush Yadav, Miquel Raynal, Richard Weinberger,
Vignesh Raghavendra, Patrick Williams, linux-mtd, linux-kernel
Am 2022-02-22 08:37, schrieb Potin Lai:
> Michael Walle 於 2022/2/22 下午 03:24 寫道:
>> Hi,
>>
>> Am 2022-02-22 07:42, schrieb Potin Lai:
>>> Add support for winbond w25q01jv-iq chip
>>>
>>> root@bletchley:~# cat
>>> /sys/devices/platform/ahb/1e620000.spi/spi_master/spi0/spi0.0/spi-nor/jedec_id
>>> ef4021
>>> root@bletchley:~# cat
>>> /sys/devices/platform/ahb/1e620000.spi/spi_master/spi0/spi0.0/spi-nor/manufacturer
>>> winbond
>>> root@bletchley:~# cat
>>> /sys/devices/platform/ahb/1e620000.spi/spi_master/spi0/spi0.0/spi-nor/partname
>>> w25q01jv-iq
>>> root@bletchley:~# hexdump -C
>>> /sys/devices/platform/ahb/1e620000.spi/spi_master/spi0/spi0.0/spi-nor/sfdp
>>> 00000000 53 46 44 50 06 01 01 ff 00 06 01 10 80 00 00 ff
>>> |SFDP............|
>>> 00000010 84 00 01 02 d0 00 00 ff 03 00 01 02 f0 00 00 ff
>>> |................|
>>> 00000020 ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff
>>> |................|
>>> *
>>> 00000080 e5 20 fb ff ff ff ff 3f 44 eb 08 6b 08 3b 42 bb |.
>>> .....?D..k.;B.|
>>> 00000090 fe ff ff ff ff ff 00 00 ff ff 40 eb 0c 20 0f 52
>>> |..........@.. .R|
>>> 000000a0 10 d8 00 00 36 02 a6 00 82 ea 14 e2 e9 63 76 33
>>> |....6........cv3|
>>> 000000b0 7a 75 7a 75 f7 a2 d5 5c 19 f7 4d ff e9 70 f9 a5
>>> |zuzu...\..M..p..|
>>> 000000c0 ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff
>>> |................|
>>> 000000d0 ff 0a f0 ff 21 ff dc ff |....!...|
>>> 000000d8
>>
>> Can you please provide an md5sum or sha256sum of this file?
>
> root@bletchley:~# md5sum
> /sys/devices/platform/ahb/1e620000.spi/spi_master/spi0/spi0.0/spi-nor/sfdp
> a7b9dbf76e99a33db99e557b6676588a
Thanks!
> /sys/devices/platform/ahb/1e620000.spi/spi_master/spi0/spi0.0/spi-nor/sfdp
>
> Is it required in commit message, if yes, I will update it.
Ohh, I actually missed that. These information should go as
a comment, that is below the "---" line.
-michael
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-02-22 7:50 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-02-22 6:42 [PATCH v2 1/1] mtd: spi-nor: winbond: Add support for w25q01jv-iq Potin Lai
2022-02-22 7:24 ` Michael Walle
2022-02-22 7:37 ` Potin Lai (賴柏廷)
2022-02-22 7:50 ` Michael Walle
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox