[PATCH 0/2] scsi: ufs: dt-bindings: Add compatibles for Nord UFS controller

[PATCH 0/2] scsi: ufs: dt-bindings: Add compatibles for Nord UFS controller

[Shawn Guo]

This series documents the UFS host controller on Qualcomm Nord SoC.

Nord is a Qualcomm SoC series. Its UFS controller has a multi-queue
command (MCQ) register range in addition to the standard one,
both of which are required.

Nord also has an automotive variant, SA8797P, where the platform
firmware implements an SCMI server and manages UFS resources such as
the PHY, clocks, regulators and resets. As a result, SA8797P shares
the minimal OS-visible DT interface of SA8255P and uses it as the
fallback compatible.

Deepti Jaggi (1):
  scsi: ufs: dt-bindings: Add compatible for SA8797P UFS Host Controller

Shawn Guo (1):
  scsi: ufs: dt-bindings: Add compatible for Nord UFS Host Controller

 .../devicetree/bindings/ufs/qcom,sa8255p-ufshc.yaml        | 7 +++++--
 .../devicetree/bindings/ufs/qcom,sm8650-ufshc.yaml         | 3 +++
 2 files changed, 8 insertions(+), 2 deletions(-)

-- 
2.43.0

[PATCH 1/2] scsi: ufs: dt-bindings: Add compatible for Nord UFS Host Controller

[Shawn Guo]

Document UFS Host Controller on Qualcomm Nord SoC.  Like the Eliza SoC,
Nord has a multi-queue command (MCQ) register range in addition to
the standard one, making both reg entries required.

Signed-off-by: Shawn Guo <shengchao.guo@oss.qualcomm.com>
---
 Documentation/devicetree/bindings/ufs/qcom,sm8650-ufshc.yaml | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/Documentation/devicetree/bindings/ufs/qcom,sm8650-ufshc.yaml b/Documentation/devicetree/bindings/ufs/qcom,sm8650-ufshc.yaml
index f28641c6e68f..900d93b675cd 100644
--- a/Documentation/devicetree/bindings/ufs/qcom,sm8650-ufshc.yaml
+++ b/Documentation/devicetree/bindings/ufs/qcom,sm8650-ufshc.yaml
@@ -17,6 +17,7 @@ select:
         enum:
           - qcom,eliza-ufshc
           - qcom,kaanapali-ufshc
+          - qcom,nord-ufshc
           - qcom,sm8650-ufshc
           - qcom,sm8750-ufshc
   required:
@@ -28,6 +29,7 @@ properties:
       - enum:
           - qcom,eliza-ufshc
           - qcom,kaanapali-ufshc
+          - qcom,nord-ufshc
           - qcom,sm8650-ufshc
           - qcom,sm8750-ufshc
       - const: qcom,ufshc
@@ -74,6 +76,7 @@ allOf:
           contains:
             enum:
               - qcom,eliza-ufshc
+              - qcom,nord-ufshc
     then:
       properties:
         reg:
-- 
2.43.0

[PATCH 2/2] scsi: ufs: dt-bindings: Add compatible for SA8797P UFS Host Controller

[Shawn Guo]

From: Deepti Jaggi <deepti.jaggi@oss.qualcomm.com>

SA8797P is the automotive variant of the Nord SoC.  Like SA8255P, its
platform firmware implements an SCMI server that manages UFS resources
such as the PHY, clocks, regulators and resets via the SCMI power
protocol. As a result, the OS-visible DT only describes the controller's
MMIO, interrupt, IOMMU and power-domain interfaces, making SA8255P the
appropriate fallback compatible.

Signed-off-by: Deepti Jaggi <deepti.jaggi@oss.qualcomm.com>
Signed-off-by: Shawn Guo <shengchao.guo@oss.qualcomm.com>
---
 .../devicetree/bindings/ufs/qcom,sa8255p-ufshc.yaml        | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/ufs/qcom,sa8255p-ufshc.yaml b/Documentation/devicetree/bindings/ufs/qcom,sa8255p-ufshc.yaml
index 75fae9f1eba7..f2f3bfc73216 100644
--- a/Documentation/devicetree/bindings/ufs/qcom,sa8255p-ufshc.yaml
+++ b/Documentation/devicetree/bindings/ufs/qcom,sa8255p-ufshc.yaml
@@ -11,8 +11,11 @@ maintainers:
 
 properties:
   compatible:
-    const: qcom,sa8255p-ufshc
-
+    oneOf:
+      - const: qcom,sa8255p-ufshc
+      - items:
+          - const: qcom,sa8797p-ufshc
+          - const: qcom,sa8255p-ufshc
   reg:
     maxItems: 1
 
-- 
2.43.0

Re: [PATCH 2/2] scsi: ufs: dt-bindings: Add compatible for SA8797P UFS Host Controller

[Krzysztof Kozlowski]

On Mon, Apr 20, 2026 at 06:04:16PM +0800, Shawn Guo wrote:
> From: Deepti Jaggi <deepti.jaggi@oss.qualcomm.com>
> 
> SA8797P is the automotive variant of the Nord SoC.  Like SA8255P, its
> platform firmware implements an SCMI server that manages UFS resources
> such as the PHY, clocks, regulators and resets via the SCMI power
> protocol. As a result, the OS-visible DT only describes the controller's
> MMIO, interrupt, IOMMU and power-domain interfaces, making SA8255P the
> appropriate fallback compatible.
> 
> Signed-off-by: Deepti Jaggi <deepti.jaggi@oss.qualcomm.com>
> Signed-off-by: Shawn Guo <shengchao.guo@oss.qualcomm.com>
> ---
>  .../devicetree/bindings/ufs/qcom,sa8255p-ufshc.yaml        | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/ufs/qcom,sa8255p-ufshc.yaml b/Documentation/devicetree/bindings/ufs/qcom,sa8255p-ufshc.yaml
> index 75fae9f1eba7..f2f3bfc73216 100644
> --- a/Documentation/devicetree/bindings/ufs/qcom,sa8255p-ufshc.yaml
> +++ b/Documentation/devicetree/bindings/ufs/qcom,sa8255p-ufshc.yaml
> @@ -11,8 +11,11 @@ maintainers:
>  
>  properties:
>    compatible:
> -    const: qcom,sa8255p-ufshc
> -

Do not remove the blank line separating from the next property.

Best regards,
Krzysztof

Re: [PATCH 1/2] scsi: ufs: dt-bindings: Add compatible for Nord UFS Host Controller

[Krzysztof Kozlowski]

On Mon, Apr 20, 2026 at 06:04:15PM +0800, Shawn Guo wrote:
> Document UFS Host Controller on Qualcomm Nord SoC.  Like the Eliza SoC,
> Nord has a multi-queue command (MCQ) register range in addition to
> the standard one, making both reg entries required.
> 
> Signed-off-by: Shawn Guo <shengchao.guo@oss.qualcomm.com>
> ---
>  Documentation/devicetree/bindings/ufs/qcom,sm8650-ufshc.yaml | 3 +++
>  1 file changed, 3 insertions(+)

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>

You posted ~22 patchsets for DT review during the merge window.
https://patchwork.kernel.org/project/devicetree/list/?submitter=220289&archive=both&state=*

Some maintainers, including myself, dislike receiving huge pile of work
during the merge window, because it is not the time to review such work.
I finish here and skip the rest of the Nord patches.

Best regards,
Krzysztof

Re: [PATCH 2/2] scsi: ufs: dt-bindings: Add compatible for SA8797P UFS Host Controller

[Manivannan Sadhasivam]

On Mon, Apr 20, 2026 at 06:04:16PM +0800, Shawn Guo wrote:
> From: Deepti Jaggi <deepti.jaggi@oss.qualcomm.com>
> 
> SA8797P is the automotive variant of the Nord SoC.  Like SA8255P, its
> platform firmware implements an SCMI server that manages UFS resources
> such as the PHY, clocks, regulators and resets via the SCMI power
> protocol. As a result, the OS-visible DT only describes the controller's
> MMIO, interrupt, IOMMU and power-domain interfaces, making SA8255P the
> appropriate fallback compatible.
> 
> Signed-off-by: Deepti Jaggi <deepti.jaggi@oss.qualcomm.com>
> Signed-off-by: Shawn Guo <shengchao.guo@oss.qualcomm.com>

Reviewed-by: Manivannan Sadhasivam <mani@kernel.org>

- Mani

> ---
>  .../devicetree/bindings/ufs/qcom,sa8255p-ufshc.yaml        | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/ufs/qcom,sa8255p-ufshc.yaml b/Documentation/devicetree/bindings/ufs/qcom,sa8255p-ufshc.yaml
> index 75fae9f1eba7..f2f3bfc73216 100644
> --- a/Documentation/devicetree/bindings/ufs/qcom,sa8255p-ufshc.yaml
> +++ b/Documentation/devicetree/bindings/ufs/qcom,sa8255p-ufshc.yaml
> @@ -11,8 +11,11 @@ maintainers:
>  
>  properties:
>    compatible:
> -    const: qcom,sa8255p-ufshc
> -
> +    oneOf:
> +      - const: qcom,sa8255p-ufshc
> +      - items:
> +          - const: qcom,sa8797p-ufshc
> +          - const: qcom,sa8255p-ufshc
>    reg:
>      maxItems: 1
>  
> -- 
> 2.43.0
> 

-- 
மணிவண்ணன் சதாசிவம்

Re: [PATCH 1/2] scsi: ufs: dt-bindings: Add compatible for Nord UFS Host Controller

[Manivannan Sadhasivam]

On Mon, Apr 20, 2026 at 06:04:15PM +0800, Shawn Guo wrote:
> Document UFS Host Controller on Qualcomm Nord SoC.  Like the Eliza SoC,
> Nord has a multi-queue command (MCQ) register range in addition to
> the standard one, making both reg entries required.
> 
> Signed-off-by: Shawn Guo <shengchao.guo@oss.qualcomm.com>

Reviewed-by: Manivannan Sadhasivam <mani@kernel.org>

- Mani

> ---
>  Documentation/devicetree/bindings/ufs/qcom,sm8650-ufshc.yaml | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/ufs/qcom,sm8650-ufshc.yaml b/Documentation/devicetree/bindings/ufs/qcom,sm8650-ufshc.yaml
> index f28641c6e68f..900d93b675cd 100644
> --- a/Documentation/devicetree/bindings/ufs/qcom,sm8650-ufshc.yaml
> +++ b/Documentation/devicetree/bindings/ufs/qcom,sm8650-ufshc.yaml
> @@ -17,6 +17,7 @@ select:
>          enum:
>            - qcom,eliza-ufshc
>            - qcom,kaanapali-ufshc
> +          - qcom,nord-ufshc
>            - qcom,sm8650-ufshc
>            - qcom,sm8750-ufshc
>    required:
> @@ -28,6 +29,7 @@ properties:
>        - enum:
>            - qcom,eliza-ufshc
>            - qcom,kaanapali-ufshc
> +          - qcom,nord-ufshc
>            - qcom,sm8650-ufshc
>            - qcom,sm8750-ufshc
>        - const: qcom,ufshc
> @@ -74,6 +76,7 @@ allOf:
>            contains:
>              enum:
>                - qcom,eliza-ufshc
> +              - qcom,nord-ufshc
>      then:
>        properties:
>          reg:
> -- 
> 2.43.0
> 

-- 
மணிவண்ணன் சதாசிவம்

Re: [PATCH 2/2] scsi: ufs: dt-bindings: Add compatible for SA8797P UFS Host Controller

[Shawn Guo]

On Tue, Apr 21, 2026 at 12:37:31PM +0200, Krzysztof Kozlowski wrote:
> On Mon, Apr 20, 2026 at 06:04:16PM +0800, Shawn Guo wrote:
> > From: Deepti Jaggi <deepti.jaggi@oss.qualcomm.com>
> > 
> > SA8797P is the automotive variant of the Nord SoC.  Like SA8255P, its
> > platform firmware implements an SCMI server that manages UFS resources
> > such as the PHY, clocks, regulators and resets via the SCMI power
> > protocol. As a result, the OS-visible DT only describes the controller's
> > MMIO, interrupt, IOMMU and power-domain interfaces, making SA8255P the
> > appropriate fallback compatible.
> > 
> > Signed-off-by: Deepti Jaggi <deepti.jaggi@oss.qualcomm.com>
> > Signed-off-by: Shawn Guo <shengchao.guo@oss.qualcomm.com>
> > ---
> >  .../devicetree/bindings/ufs/qcom,sa8255p-ufshc.yaml        | 7 +++++--
> >  1 file changed, 5 insertions(+), 2 deletions(-)
> > 
> > diff --git a/Documentation/devicetree/bindings/ufs/qcom,sa8255p-ufshc.yaml b/Documentation/devicetree/bindings/ufs/qcom,sa8255p-ufshc.yaml
> > index 75fae9f1eba7..f2f3bfc73216 100644
> > --- a/Documentation/devicetree/bindings/ufs/qcom,sa8255p-ufshc.yaml
> > +++ b/Documentation/devicetree/bindings/ufs/qcom,sa8255p-ufshc.yaml
> > @@ -11,8 +11,11 @@ maintainers:
> >  
> >  properties:
> >    compatible:
> > -    const: qcom,sa8255p-ufshc
> > -
> 
> Do not remove the blank line separating from the next property.

You are right!  I dropped the newline accidentally.

Shawn