Re: [PATCH v3 0/2] tpm_tis: fix retry exhaustion and add logging

Re: [PATCH v3 0/2] tpm_tis: fix retry exhaustion and add logging

[Axel Rasmussen]

On Wed, Apr 15, 2026 at 9:00 AM Jacqueline Wong <jacqwong@google.com> wrote:
>
> The Fix:
> - Patch 1: Adds error logs to identify the specific hardware status mismatch.
> - Patch 2: Stops execution immediately when retries are exhausted.
>
> v3 changes:
> - Improved code alignment to pass checkpatch --strict.

Thanks for sending the v3 Jacqueline!
I suspect this may have slipped under folks' radar by not CC'ing +linux-kernel@.

>
> v2 changes:
> - Split logging and logic into separate patches.
> - Added retry count to the error message.
> - Included dmesg traces below.
>
> Testing:
> Dmesg traces obtained using error injection to simulate status register mismatches.
>
> Before:
> [  130.288751] tpm tpm0: Operation Timed out
> [  250.306070] tpm tpm0: Operation Timed out
> [  250.310173] tpm tpm0: A TPM error (-62) occurred attempting to determine the timeouts
>
> After:
> [   10.271547] tpm tpm0: TPM_STS_DATA_EXPECT should be unset. sts = 0x00000080
> ...
> [   10.646283] tpm tpm0: TPM_STS_DATA_EXPECT should be unset. sts = 0x00000080
> [   10.653461] tpm tpm0: Exhausted 50 tpm_tis_send_data retries
> [   10.659304] tpm tpm0: tpm_try_transmit: send(): error -5
> [   10.665435] tpm tpm0: TPM_STS_DATA_EXPECT should be unset. sts = 0x00000080
> ...
> [   11.037198] tpm tpm0: TPM_STS_DATA_EXPECT should be unset. sts = 0x00000080
> [   11.044441] tpm tpm0: Exhausted 50 tpm_tis_send_data retries
> [   11.050288] tpm tpm0: tpm_try_transmit: send(): error -5
> [   11.055723] tpm tpm0: A TPM error (-5) occurred attempting to determine the timeouts
>
> Jacqueline Wong (2):
>   tpm: tpm_tis: add error logging for data transfer
>   tpm: tpm_tis: stop transmit if retries are exhausted
>
>  drivers/char/tpm/tpm_tis_core.c | 11 ++++++++++-
>  1 file changed, 10 insertions(+), 1 deletion(-)
>
> --
> 2.54.0.rc0.605.g598a273b03-goog
>

Re: [PATCH v3 0/2] tpm_tis: fix retry exhaustion and add logging

[Jarkko Sakkinen]

On Wed, Apr 22, 2026 at 04:00:17PM -0700, Axel Rasmussen wrote:
> On Wed, Apr 15, 2026 at 9:00 AM Jacqueline Wong <jacqwong@google.com> wrote:
> >
> > The Fix:
> > - Patch 1: Adds error logs to identify the specific hardware status mismatch.
> > - Patch 2: Stops execution immediately when retries are exhausted.
> >
> > v3 changes:
> > - Improved code alignment to pass checkpatch --strict.
> 
> Thanks for sending the v3 Jacqueline!
> I suspect this may have slipped under folks' radar by not CC'ing +linux-kernel@.

Please check that I carry the correct version of patches:

https://git.kernel.org/pub/scm/linux/kernel/git/jarkko/linux-tpmdd.git/log/?h=for-next-tpm

This is related to:

1. https://lore.kernel.org/linux-integrity/aeVSbVIFaCDRXf7C@kernel.org/
2. https://lore.kernel.org/linux-integrity/CAHk-=wiPWCUHsNvzKep7z4VGaL-Brx6Zmh7Efn28WWTPbwn5dA@mail.gmail.com/
3. https://lore.kernel.org/all/aee_mCW8p2J6IbIO@kernel.org/

I will try to send PRs after my split next branches are sync to -next.

BR, Jarkko

Re: [PATCH v3 0/2] tpm_tis: fix retry exhaustion and add logging

[Jarkko Sakkinen]

OK cool, thanks for heads up.

I'll most likely address this mess I'm having ATM by doing rc2
PR with the bug fixes.

BR, Jarkko

On Thu, Apr 23, 2026 at 08:29:47AM -0700, Jacqueline Wong wrote:
> Thanks Jarkko, the patches look correct to me.
> 
> Thanks,
> Jacqueline
> 
> On Thu, Apr 23, 2026 at 3:21 AM Jarkko Sakkinen <jarkko@kernel.org> wrote:
> 
>     On Wed, Apr 22, 2026 at 04:00:17PM -0700, Axel Rasmussen wrote:
>     > On Wed, Apr 15, 2026 at 9:00 AM Jacqueline Wong <jacqwong@google.com>
>     wrote:
>     > >
>     > > The Fix:
>     > > - Patch 1: Adds error logs to identify the specific hardware status
>     mismatch.
>     > > - Patch 2: Stops execution immediately when retries are exhausted.
>     > >
>     > > v3 changes:
>     > > - Improved code alignment to pass checkpatch --strict.
>     >
>     > Thanks for sending the v3 Jacqueline!
>     > I suspect this may have slipped under folks' radar by not CC'ing
>     +linux-kernel@.
> 
>     Please check that I carry the correct version of patches:
> 
>     https://git.kernel.org/pub/scm/linux/kernel/git/jarkko/linux-tpmdd.git/log
>     /?h=for-next-tpm
> 
>     This is related to:
> 
>     1. https://lore.kernel.org/linux-integrity/aeVSbVIFaCDRXf7C@kernel.org/
>     2. https://lore.kernel.org/linux-integrity/CAHk-=
>     wiPWCUHsNvzKep7z4VGaL-Brx6Zmh7Efn28WWTPbwn5dA@mail.gmail.com/
>     3. https://lore.kernel.org/all/aee_mCW8p2J6IbIO@kernel.org/
> 
>     I will try to send PRs after my split next branches are sync to -next.
> 
>     BR, Jarkko
>