* [PATCH] Input: elan_i2c - Add ic type 0x19
@ 2026-04-21 7:00 Jingle Wu 吳金國
2026-04-21 7:02 ` [PATCH] Input: elan_i2c - increase device reset wait timeout after update FW Jingle Wu 吳金國
2026-04-23 18:02 ` [PATCH] Input: elan_i2c - Add ic type 0x19 Dmitry.torokhov@gmail.com
0 siblings, 2 replies; 3+ messages in thread
From: Jingle Wu 吳金國 @ 2026-04-21 7:00 UTC (permalink / raw)
To: Linux-kernel@vger.kernel.org, Linux-input@vger.kernel.org,
Dmitry.torokhov@gmail.com
The 0x19 is valid 3000 serial ic type too.
Signed-off-by: Jingle Wu <jingle.wu@emc.com.tw>
---
drivers/input/mouse/elan_i2c_core.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/input/mouse/elan_i2c_core.c b/drivers/input/mouse/elan_i2c_core.c
index fee1796da3d0..7475803c6ce4 100644
--- a/drivers/input/mouse/elan_i2c_core.c
+++ b/drivers/input/mouse/elan_i2c_core.c
@@ -162,6 +162,9 @@ static int elan_get_fwinfo(u16 ic_type, u8 iap_version, u16 *validpage_count,
case 0x15:
*validpage_count = 1024;
break;
+ case 0x19:
+ *validpage_count = 2032;
+ break;
default:
/* unknown ic type clear value */
*validpage_count = 0;
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH] Input: elan_i2c - increase device reset wait timeout after update FW
2026-04-21 7:00 [PATCH] Input: elan_i2c - Add ic type 0x19 Jingle Wu 吳金國
@ 2026-04-21 7:02 ` Jingle Wu 吳金國
2026-04-23 18:02 ` [PATCH] Input: elan_i2c - Add ic type 0x19 Dmitry.torokhov@gmail.com
1 sibling, 0 replies; 3+ messages in thread
From: Jingle Wu 吳金國 @ 2026-04-21 7:02 UTC (permalink / raw)
To: Linux-kernel@vger.kernel.org, Linux-input@vger.kernel.org,
Dmitry.torokhov@gmail.com
Extend wait_for_completion_timeout from 300ms to 700ms to ensure
sufficient time for device reset after firmware update.
Signed-off-by: Jingle Wu <jingle.wu@emc.com.tw>
---
drivers/input/mouse/elan_i2c_i2c.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/input/mouse/elan_i2c_i2c.c b/drivers/input/mouse/elan_i2c_i2c.c
index a9057d124a88..88d4070d4b44 100644
--- a/drivers/input/mouse/elan_i2c_i2c.c
+++ b/drivers/input/mouse/elan_i2c_i2c.c
@@ -690,7 +690,7 @@ static int elan_i2c_finish_fw_update(struct i2c_client *client,
if (error) {
dev_err(dev, "device reset failed: %d\n", error);
} else if (!wait_for_completion_timeout(completion,
- msecs_to_jiffies(300))) {
+ msecs_to_jiffies(700))) {
dev_err(dev, "timeout waiting for device reset\n");
error = -ETIMEDOUT;
}
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] Input: elan_i2c - Add ic type 0x19
2026-04-21 7:00 [PATCH] Input: elan_i2c - Add ic type 0x19 Jingle Wu 吳金國
2026-04-21 7:02 ` [PATCH] Input: elan_i2c - increase device reset wait timeout after update FW Jingle Wu 吳金國
@ 2026-04-23 18:02 ` Dmitry.torokhov@gmail.com
1 sibling, 0 replies; 3+ messages in thread
From: Dmitry.torokhov@gmail.com @ 2026-04-23 18:02 UTC (permalink / raw)
To: Jingle Wu 吳金國
Cc: Linux-kernel@vger.kernel.org, Linux-input@vger.kernel.org
On Tue, Apr 21, 2026 at 07:00:10AM +0000, Jingle Wu 吳金國 wrote:
> The 0x19 is valid 3000 serial ic type too.
>
> Signed-off-by: Jingle Wu <jingle.wu@emc.com.tw>
> ---
> drivers/input/mouse/elan_i2c_core.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/input/mouse/elan_i2c_core.c b/drivers/input/mouse/elan_i2c_core.c
> index fee1796da3d0..7475803c6ce4 100644
> --- a/drivers/input/mouse/elan_i2c_core.c
> +++ b/drivers/input/mouse/elan_i2c_core.c
> @@ -162,6 +162,9 @@ static int elan_get_fwinfo(u16 ic_type, u8 iap_version, u16 *validpage_count,
> case 0x15:
> *validpage_count = 1024;
> break;
> + case 0x19:
> + *validpage_count = 2032;
> + break;
> default:
> /* unknown ic type clear value */
> *validpage_count = 0;
Applied both, thank you.
--
Dmitry
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-04-23 18:02 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-04-21 7:00 [PATCH] Input: elan_i2c - Add ic type 0x19 Jingle Wu 吳金國
2026-04-21 7:02 ` [PATCH] Input: elan_i2c - increase device reset wait timeout after update FW Jingle Wu 吳金國
2026-04-23 18:02 ` [PATCH] Input: elan_i2c - Add ic type 0x19 Dmitry.torokhov@gmail.com
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox