From: Tejun Heo <tj@kernel.org>
To: Kuba Piecuch <jpiecuch@google.com>
Cc: Andrea Righi <arighi@nvidia.com>,
Changwoo Min <changwoo@igalia.com>,
David Vernet <void@manifault.com>,
linux-kernel@vger.kernel.org, sched-ext@lists.linux.dev
Subject: Re: SCX_ENQ_IMMED potentially leaving dispatched tasks lingering on local DSQs
Date: Thu, 23 Apr 2026 11:57:06 -1000 [thread overview]
Message-ID: <aeqVstPcyR_WMCas@slm.duckdns.org> (raw)
In-Reply-To: <DI0SXNWQZSTV.39HPITQGOG1YS@google.com>
Hello,
On Thu, Apr 23, 2026 at 08:03:51PM +0000, Kuba Piecuch wrote:
...
> I don't like the idea of maintaining the separate checks, precisely because
> of how subtle and finnicky they are. I worry that it will be difficult to keep
> all cases covered as the codebase evolves.
>
> As an optimization, we could skip wakeup_preempt() in local_dsq_post_enq() if
> rq->next_class == &ext_sched_class. That should make the performance impact
> negligible in the common case, WDYT?
Yeah, let's do that. Please send a patch and can you also cc PeterZ?
Thanks.
--
tejun
prev parent reply other threads:[~2026-04-23 21:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-22 13:21 SCX_ENQ_IMMED potentially leaving dispatched tasks lingering on local DSQs Kuba Piecuch
2026-04-22 16:50 ` Tejun Heo
2026-04-23 9:48 ` Kuba Piecuch
2026-04-23 16:53 ` Tejun Heo
2026-04-23 19:12 ` Kuba Piecuch
2026-04-23 19:29 ` Tejun Heo
2026-04-23 20:03 ` Kuba Piecuch
2026-04-23 21:57 ` Tejun Heo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aeqVstPcyR_WMCas@slm.duckdns.org \
--to=tj@kernel.org \
--cc=arighi@nvidia.com \
--cc=changwoo@igalia.com \
--cc=jpiecuch@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sched-ext@lists.linux.dev \
--cc=void@manifault.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox