public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Johan Hovold <johan@kernel.org>
To: Damien Le Moal <dlemoal@kernel.org>
Cc: Niklas Cassel <cassel@kernel.org>,
	linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ata: pata_parport: switch to dynamic root device
Date: Fri, 24 Apr 2026 16:00:06 +0200	[thread overview]
Message-ID: <aet3ZhRMCSHcWoOe@hovoldconsulting.com> (raw)
In-Reply-To: <c5a202d0-3938-4bd0-8f95-b4628265840b@kernel.org>

On Fri, Apr 24, 2026 at 08:18:31PM +0900, Damien Le Moal wrote:
> On 4/24/26 19:38, Johan Hovold wrote:
> > Driver core expects devices to be dynamically allocated and will, for
> > example, complain loudly when no release function has been provided.
> > 
> > Use root_device_register() to allocate and register the root device
> > instead of open coding using a static device.
> > 
> > Note that this also fixes a reference leak in the unlikely event that
> > device_register() ever fails.
> > 
> > Signed-off-by: Johan Hovold <johan@kernel.org>
> 
> Looks OK to me.
> 
> Reviewed-by: Damien Le Moal <dlemoal@kernel.org>
> 
> I suspect that this should go in for 7.1, right ?

Yeah, probably, because of the reference leak which someone may try to
fix in the meantime.

Johan

  reply	other threads:[~2026-04-24 14:00 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-24 10:38 [PATCH] ata: pata_parport: switch to dynamic root device Johan Hovold
2026-04-24 11:18 ` Damien Le Moal
2026-04-24 14:00   ` Johan Hovold [this message]
2026-04-27  9:40 ` Niklas Cassel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aet3ZhRMCSHcWoOe@hovoldconsulting.com \
    --to=johan@kernel.org \
    --cc=cassel@kernel.org \
    --cc=dlemoal@kernel.org \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox