From: Damien Le Moal <dlemoal@kernel.org>
To: Johan Hovold <johan@kernel.org>, Niklas Cassel <cassel@kernel.org>
Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ata: pata_parport: switch to dynamic root device
Date: Fri, 24 Apr 2026 20:18:31 +0900 [thread overview]
Message-ID: <c5a202d0-3938-4bd0-8f95-b4628265840b@kernel.org> (raw)
In-Reply-To: <20260424103830.2616828-1-johan@kernel.org>
On 4/24/26 19:38, Johan Hovold wrote:
> Driver core expects devices to be dynamically allocated and will, for
> example, complain loudly when no release function has been provided.
>
> Use root_device_register() to allocate and register the root device
> instead of open coding using a static device.
>
> Note that this also fixes a reference leak in the unlikely event that
> device_register() ever fails.
>
> Signed-off-by: Johan Hovold <johan@kernel.org>
Looks OK to me.
Reviewed-by: Damien Le Moal <dlemoal@kernel.org>
I suspect that this should go in for 7.1, right ?
--
Damien Le Moal
Western Digital Research
next prev parent reply other threads:[~2026-04-24 11:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-24 10:38 [PATCH] ata: pata_parport: switch to dynamic root device Johan Hovold
2026-04-24 11:18 ` Damien Le Moal [this message]
2026-04-24 14:00 ` Johan Hovold
2026-04-27 9:40 ` Niklas Cassel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c5a202d0-3938-4bd0-8f95-b4628265840b@kernel.org \
--to=dlemoal@kernel.org \
--cc=cassel@kernel.org \
--cc=johan@kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox