* Re: [PATCH v4 10/11] Input: stmfts - support FTS5
[not found] ` <20260409-stmfts5-v4-10-64fe62027db5@ixit.cz>
@ 2026-05-08 6:11 ` Dmitry Torokhov
0 siblings, 0 replies; 2+ messages in thread
From: Dmitry Torokhov @ 2026-05-08 6:11 UTC (permalink / raw)
To: david
Cc: Maxime Coquelin, Alexandre Torgue, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Henrik Rydberg,
Bjorn Andersson, Konrad Dybcio, Petr Hodina, linux-input,
linux-stm32, linux-arm-kernel, linux-kernel, Krzysztof Kozlowski,
devicetree, linux-arm-msm, phone-devel
Hi David,
On Thu, Apr 09, 2026 at 12:15:53AM +0200, David Heidelberg via B4 Relay wrote:
> @@ -101,12 +129,27 @@ struct stmfts_data {
>
> struct completion cmd_done;
>
> + unsigned long touch_id;
> + unsigned long stylus_id;
I wonder why do you track contacts yourself instead of telling input
core to do it for you and report BTN_TOUCH as needed? You just need to
call input_mt_sync_frame() when you are done processing input frame.
Does the device send all contacts state in one transmission or it can
transmit contacts one by one?
> +
> + /* Boundary check - some devices report max value, adjust */
> + if (x >= sdata->prop.max_x)
> + x = sdata->prop.max_x - 1;
> + if (y >= sdata->prop.max_y)
> + y = sdata->prop.max_y - 1;
It is allowed to exceed declared min and max, so this clampin is not
needed.
>
> +static int stmfts5_set_scan_mode(struct stmfts_data *sdata, const u8 val)
> +{
> + int err;
> +
> + u8 scan_mode_cmd[3] = { STMFTS5_SET_SCAN_MODE, 0x00, val };
> + struct i2c_msg msg = {
> + .addr = sdata->client->addr,
> + .len = sizeof(scan_mode_cmd),
> + .buf = scan_mode_cmd,
> + };
> +
> + err = i2c_transfer(sdata->client->adapter, &msg, 1);
Is this i2c_master_send()?
> + if (err != 1)
> + return err < 0 ? err : -EIO;
> +
> + return 0;
> +
> +}
> +
> static int stmfts_input_open(struct input_dev *dev)
> {
> struct stmfts_data *sdata = input_get_drvdata(dev);
> @@ -371,6 +622,28 @@ static int stmfts_input_open(struct input_dev *dev)
> return 0;
> }
>
> +static int stmfts5_input_open(struct input_dev *dev)
> +{
> + struct stmfts_data *sdata = input_get_drvdata(dev);
> + int err;
> +
> + err = pm_runtime_resume_and_get(&sdata->client->dev);
> + if (err)
> + return err;
> +
> + mutex_lock(&sdata->mutex);
> + sdata->running = true;
> + mutex_unlock(&sdata->mutex);
scoped_guard(mutex, &sdata->mutex)
sdata->running;
> +
> + err = stmfts5_set_scan_mode(sdata, 0xff);
> + if (err) {
> + pm_runtime_put_sync(&sdata->client->dev);
Reset "running"?
> + return err;
> + }
> +
> + return 0;
> +}
> +
> static void stmfts_input_close(struct input_dev *dev)
> {
> struct stmfts_data *sdata = input_get_drvdata(dev);
> @@ -404,6 +677,23 @@ static void stmfts_input_close(struct input_dev *dev)
> pm_runtime_put_sync(&sdata->client->dev);
> }
>
> +static void stmfts5_input_close(struct input_dev *dev)
> +{
> + struct stmfts_data *sdata = input_get_drvdata(dev);
> + int err;
> +
> + err = stmfts5_set_scan_mode(sdata, 0x00);
> + if (err)
> + dev_warn(&sdata->client->dev,
> + "failed to disable touchscreen: %d\n", err);
> +
> + mutex_lock(&sdata->mutex);
> + sdata->running = false;
> + mutex_unlock(&sdata->mutex);
scoped_guard()
> +
> + pm_runtime_put_sync(&sdata->client->dev);
> +}
> +
> static ssize_t stmfts_sysfs_chip_id(struct device *dev,
> struct device_attribute *attr, char *buf)
> {
> @@ -484,10 +774,8 @@ static ssize_t stmfts_sysfs_hover_enable_write(struct device *dev,
> guard(mutex)(&sdata->mutex);
>
> if (hover != sdata->hover_enabled) {
> - if (sdata->running) {
> - err = i2c_smbus_write_byte(sdata->client,
> - value ? STMFTS_SS_HOVER_SENSE_ON :
> - STMFTS_SS_HOVER_SENSE_OFF);
> + if (sdata->running && sdata->ops->set_hover) {
> + err = sdata->ops->set_hover(sdata, hover);
> if (err)
> return err;
> }
> @@ -612,7 +900,7 @@ static int stmfts_power_on(struct stmfts_data *sdata)
> if (sdata->reset_gpio)
> stmfts_reset(sdata);
>
> - err = stmfts_configure(sdata);
> + err = sdata->ops->configure(sdata);
> if (err)
> regulator_bulk_disable(ARRAY_SIZE(stmfts_supplies),
> sdata->supplies);
> @@ -620,6 +908,29 @@ static int stmfts_power_on(struct stmfts_data *sdata)
> return err;
> }
>
> +static int stmfts5_configure(struct stmfts_data *sdata)
> +{
> + u8 event[STMFTS_EVENT_SIZE];
> + int ret;
> +
> + /* Verify I2C communication */
> + ret = i2c_smbus_read_i2c_block_data(sdata->client,
> + STMFTS_READ_ALL_EVENT,
> + sizeof(event), event);
> + if (ret < 0)
> + return ret;
> +
> + enable_irq(sdata->client->irq);
> +
> + return 0;
> +}
> +
> +static void stmfts5_chip_power_off(struct stmfts_data *sdata)
> +{
> + i2c_smbus_write_byte(sdata->client, STMFTS_SLEEP_IN);
> + msleep(20);
> +}
> +
> static void stmfts_power_off(void *data)
> {
> struct stmfts_data *sdata = data;
> @@ -629,10 +940,73 @@ static void stmfts_power_off(void *data)
> if (sdata->reset_gpio)
> gpiod_set_value_cansleep(sdata->reset_gpio, 1);
>
> + if (sdata->ops->power_off)
> + sdata->ops->power_off(sdata);
> +
> regulator_bulk_disable(ARRAY_SIZE(stmfts_supplies),
> sdata->supplies);
> }
>
> +static int stmfts_setup_input(struct stmfts_data *sdata)
> +{
> + struct device *dev = &sdata->client->dev;
> +
> + input_set_abs_params(sdata->input, ABS_MT_ORIENTATION, 0, 255, 0, 0);
> + input_set_abs_params(sdata->input, ABS_DISTANCE, 0, 255, 0, 0);
> +
> + sdata->use_key = device_property_read_bool(dev, "touch-key-connected");
> + if (sdata->use_key) {
> + input_set_capability(sdata->input, EV_KEY, KEY_MENU);
> + input_set_capability(sdata->input, EV_KEY, KEY_BACK);
> + }
> +
> + return input_mt_init_slots(sdata->input, STMFTS_MAX_FINGERS,
> + INPUT_MT_DIRECT);
> +}
> +
> +static int stmfts5_setup_input(struct stmfts_data *sdata)
> +{
> + struct device *dev = &sdata->client->dev;
> +
> + sdata->mode_switch_gpio = devm_gpiod_get_optional(dev, "mode-switch",
> + GPIOD_OUT_HIGH);
> + if (IS_ERR(sdata->mode_switch_gpio))
> + return dev_err_probe(dev, PTR_ERR(sdata->mode_switch_gpio),
> + "Failed to get GPIO 'switch'\n");
> +
> + /* Mark as direct input device for calibration support */
> + __set_bit(INPUT_PROP_DIRECT, sdata->input->propbit);
> +
> + /* Set up basic touch capabilities */
> + input_set_capability(sdata->input, EV_KEY, BTN_TOUCH);
This will be done by input_mt_init_slots(..., INPUT_MT_DIRECT).
> +
> + /* Set resolution for accurate calibration */
> + if (!input_abs_get_res(sdata->input, ABS_MT_POSITION_X)) {
> + input_abs_set_res(sdata->input, ABS_MT_POSITION_X, 10);
> + input_abs_set_res(sdata->input, ABS_MT_POSITION_Y, 10);
> + }
> +
> + input_set_abs_params(sdata->input, ABS_MT_DISTANCE, 0, 255, 0, 0);
> +
> + /* Enable stylus support if requested */
> + sdata->stylus_enabled = device_property_read_bool(dev, "stylus-enabled");
> +
> + /* Initialize touch tracking bitmaps */
> + sdata->touch_id = 0;
> + sdata->stylus_id = 0;
> +
> + /* Initialize MT slots with support for pen tool type */
> + return input_mt_init_slots(sdata->input, STMFTS_MAX_FINGERS,
> + INPUT_MT_DIRECT | INPUT_MT_DROP_UNUSED);
Why INPUT_MT_DROP_UNUSED?
> +}
> +
> +static int stmfts_set_hover(struct stmfts_data *sdata, bool enable)
> +{
> + return i2c_smbus_write_byte(sdata->client,
> + enable ? STMFTS_SS_HOVER_SENSE_ON :
> + STMFTS_SS_HOVER_SENSE_OFF);
> +}
> +
> static int stmfts_enable_led(struct stmfts_data *sdata)
> {
> int err;
> @@ -678,6 +1052,8 @@ static int stmfts_probe(struct i2c_client *client)
> mutex_init(&sdata->mutex);
> init_completion(&sdata->cmd_done);
>
> + sdata->ops = of_device_get_match_data(dev);
> +
> err = devm_regulator_bulk_get_const(dev,
> ARRAY_SIZE(stmfts_supplies),
> stmfts_supplies,
> @@ -697,8 +1073,8 @@ static int stmfts_probe(struct i2c_client *client)
>
> sdata->input->name = STMFTS_DEV_NAME;
> sdata->input->id.bustype = BUS_I2C;
> - sdata->input->open = stmfts_input_open;
> - sdata->input->close = stmfts_input_close;
> + sdata->input->open = sdata->ops->input_open;
> + sdata->input->close = sdata->ops->input_close;
>
> input_set_capability(sdata->input, EV_ABS, ABS_MT_POSITION_X);
> input_set_capability(sdata->input, EV_ABS, ABS_MT_POSITION_Y);
> @@ -706,19 +1082,9 @@ static int stmfts_probe(struct i2c_client *client)
>
> input_set_abs_params(sdata->input, ABS_MT_TOUCH_MAJOR, 0, 255, 0, 0);
> input_set_abs_params(sdata->input, ABS_MT_TOUCH_MINOR, 0, 255, 0, 0);
> - input_set_abs_params(sdata->input, ABS_MT_ORIENTATION, 0, 255, 0, 0);
> input_set_abs_params(sdata->input, ABS_MT_PRESSURE, 0, 255, 0, 0);
> - input_set_abs_params(sdata->input, ABS_DISTANCE, 0, 255, 0, 0);
> -
> - sdata->use_key = device_property_read_bool(dev,
> - "touch-key-connected");
> - if (sdata->use_key) {
> - input_set_capability(sdata->input, EV_KEY, KEY_MENU);
> - input_set_capability(sdata->input, EV_KEY, KEY_BACK);
> - }
>
> - err = input_mt_init_slots(sdata->input,
> - STMFTS_MAX_FINGERS, INPUT_MT_DIRECT);
> + err = sdata->ops->setup_input(sdata);
> if (err)
> return err;
>
> @@ -789,13 +1155,62 @@ static int stmfts_runtime_suspend(struct device *dev)
> return ret;
> }
>
> -static int stmfts_runtime_resume(struct device *dev)
> +static int stmfts_chip_runtime_resume(struct stmfts_data *sdata)
> +{
> + return i2c_smbus_write_byte(sdata->client, STMFTS_SLEEP_OUT);
> +}
> +
> +static int stmfts5_chip_runtime_resume(struct stmfts_data *sdata)
> {
> - struct stmfts_data *sdata = dev_get_drvdata(dev);
> struct i2c_client *client = sdata->client;
> + struct device *dev = &client->dev;
> + u8 int_enable_cmd[4] = {0xB6, 0x00, 0x2C, 0x01};
> + struct i2c_msg msg = {
> + .addr = client->addr,
> + .len = sizeof(int_enable_cmd),
> + .buf = int_enable_cmd,
> + };
> int ret;
"int err" everywhere where the variable carries error code or 0.
Thanks.
--
Dmitry
^ permalink raw reply [flat|nested] 2+ messages in thread