The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Sasha Levin <sashal@kernel.org>
To: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Cc: Joshua Peisach <jpeisach@ubuntu.com>,
	corbet@lwn.net, akpm@linux-foundation.org,
	skhan@linuxfoundation.org, linux-doc@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
	gregkh@linuxfoundation.org
Subject: Re: [PATCH] killswitch: add per-function short-circuit mitigation primitive
Date: Fri, 8 May 2026 12:23:19 -0400	[thread overview]
Message-ID: <af4N9_YOgDQziRCR@laps> (raw)
In-Reply-To: <b14d54c0-0fe8-4d98-a2ea-2dd830cd5869@efficios.com>

On Fri, May 08, 2026 at 12:18:28PM -0400, Mathieu Desnoyers wrote:
>On 2026-05-08 12:13, Sasha Levin wrote:
>[...]
>>>One possible approach to prevent "footgun" type of killswitch use would
>>>be to first apply a statistics collection killswitch handler that does
>>>not change the behavior: it checks whether the target function is
>>>invoked at all on the system for a given period of time. Then it applies
>>>the killswitch if it was not invoked during that period. Overall
>>>sequence:
>>>
>>>- pre-soak killswitch for e.g. 30s, checking whether the function is
>>> invoked at all. (period would be user-configurable)
>>>- if no calls were detected, engage killswitch, else report failure to
>>> the user.
>>>
>>>This should prevent footguns such as trying to killswitch fork, malloc
>>>or other core functions which are inherently required.
>>
>>Why not just use our good old tracing infra? Set tracepoints where ever you
>>want, collect any data you might need, and engage the killswitch 
>>when you're
>>happy with the data you have?
>>
>>It feels a bit weird adding something like this into killswitch.
>
>It really depends on whether you want to include some basic safety nets
>directly within killswitch, or leave that entirely to the end user.
>
>I don't have a strong opinion either way. I was just pointing out the
>feasibility of a pre-soak sanity check before applying the killswitch.

What about doing this with some userspace tooling (maybe under scripts/) to
facilitate this?

-- 
Thanks,
Sasha

  reply	other threads:[~2026-05-08 16:23 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-07  7:05 [PATCH] killswitch: add per-function short-circuit mitigation primitive Sasha Levin
2026-05-07 10:47 ` Greg KH
2026-05-07 13:40   ` Sasha Levin
2026-05-07 16:23     ` Greg KH
2026-05-07 15:21 ` Jonathan Corbet
2026-05-08 13:44   ` Sasha Levin
2026-05-08 15:40 ` Joshua Peisach
2026-05-08 15:48   ` Mathieu Desnoyers
2026-05-08 16:13     ` Sasha Levin
2026-05-08 16:18       ` Mathieu Desnoyers
2026-05-08 16:23         ` Sasha Levin [this message]
2026-05-08 16:26           ` Mathieu Desnoyers
2026-05-08 16:54             ` Sasha Levin
2026-05-08 20:56 ` Andrew Morton
2026-05-08 21:47   ` Sasha Levin
2026-05-08 23:49     ` Andrew Morton
2026-05-09  0:15       ` Sasha Levin
2026-05-09  0:36         ` Andrew Morton
2026-05-11 11:41     ` Breno Leitao
2026-05-11 13:07       ` Michal Hocko
2026-05-11 13:39         ` Sasha Levin
2026-05-11 13:49           ` Michal Hocko
2026-05-11 13:56             ` Sasha Levin
2026-05-11 14:25               ` Michal Hocko
2026-05-11 15:55                 ` Sasha Levin
2026-05-11 16:10                   ` Michal Hocko
2026-05-11 16:45                     ` Sasha Levin
2026-05-11 17:10                       ` Michal Hocko
2026-05-11 18:09                         ` Sasha Levin
2026-05-11 13:40         ` Breno Leitao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=af4N9_YOgDQziRCR@laps \
    --to=sashal@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=corbet@lwn.net \
    --cc=gregkh@linuxfoundation.org \
    --cc=jpeisach@ubuntu.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=mathieu.desnoyers@efficios.com \
    --cc=skhan@linuxfoundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox