Re: [PATCH] tpm: Remove dead NULL check in tpm2_flush_space()

[Jarkko Sakkinen <jarkko@kernel.org>]

On Sat, May 09, 2026 at 02:28:08PM +0300, Jarkko Sakkinen wrote:
> On Mon, Apr 27, 2026 at 04:32:26PM +0000, Gunnar Kudrjavets wrote:
> > The 'space' pointer in tpm2_flush_space() is assigned from
> > &chip->work_space, which is the address of an embedded struct member
> > within struct tpm_chip. This address can never be NULL, making the
> > NULL check dead code. The new code follows the existing pattern
> > established by the other callers in tpm2-space.c which also assign
> > from &chip->work_space without a NULL check. Remove the dead code
> > to avoid confusion.
> > 
> > Fixes: e3aaebcbb7c6 ("tpm: Clean up TPM space after command failure")
> > Signed-off-by: Gunnar Kudrjavets <gunnarku@amazon.com>
> > Assisted-by: Kiro:claude-opus-4.6
> 
> Just for sake of understanding:
> 
> What is "kiro" and is assisted-by the tag supposed to be used here?
> 
> > Reviewed-by: Justinien Bouron <jbouron@amazon.com>
> > ---
> >  drivers/char/tpm/tpm2-space.c | 3 ---
> >  1 file changed, 3 deletions(-)
> > 
> > diff --git a/drivers/char/tpm/tpm2-space.c b/drivers/char/tpm/tpm2-space.c
> > index 60354cd53b5c..1eec72eb8208 100644
> > --- a/drivers/char/tpm/tpm2-space.c
> > +++ b/drivers/char/tpm/tpm2-space.c
> > @@ -169,9 +169,6 @@ void tpm2_flush_space(struct tpm_chip *chip)
> >  	struct tpm_space *space = &chip->work_space;
> >  	int i;
> >  
> > -	if (!space)
> > -		return;
> > -
> >  	for (i = 0; i < ARRAY_SIZE(space->context_tbl); i++)
> >  		if (space->context_tbl[i] && ~space->context_tbl[i])
> >  			tpm2_flush_context(chip, space->context_tbl[i]);
> > 
> > base-commit: 949692da7211572fac419b2986b6abc0cd1aeb76
> > -- 
> > 2.47.3
> > 
> 
> It's all good otherwise, just need clarification as we are learning
> how to deal with these patches :-)

Hold on, I would not remove it: it's an invariant. It's not dead code.

BR, Jarkko