Re: [PATCH] tpm: Remove dead NULL check in tpm2_flush_space()

[Jarkko Sakkinen <jarkko@kernel.org>]

On Tue, Apr 28, 2026 at 08:18:09AM +0200, Paul Menzel wrote:
> Dear Gunnar,
> 
> 
> Am 28.04.26 um 00:57 schrieb Gunnar Kudrjavets:
> > On Sun, Apr 27, 2026 at 10:49 PM Paul Menzel <pmenzel@molgen.mpg.de> wrote:
> > > gemini/gemini-3.1-pro-preview made a comment [1]. No idea, if it's valid.
> > 
> > Thanks for forwarding, Paul. AFAICS, the comment is a false positive.
> > 
> > My theory is that Gemini conflates two different variables named
> > 'space':
> > 
> > 1. The 'space' parameter passed to tpm_dev_transmit(). This *can* be
> >     NULL (it is NULL for /dev/tpm0 clients).
> > 
> > 2. The local 'space' variable inside tpm2_flush_space(). This is
> >     assigned from &chip->work_space and can *never* be NULL.
> > 
> > The removed NULL check was testing case (2), not case (1).
> 
> Thank you for quickly looking into this. Sorry for the noise.

I felt sleep while reading the text generated by Gemini but yes exactly
because it can't be NULL the check is there.

I.e. Opus is right but the action taken is still plain wrong.

> Kind regards,
> 
> Paul

BR, Jarkko