From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Arnd Bergmann <arnd@kernel.org>
Cc: Matti Vaittinen <mazziesaccount@gmail.com>,
Lee Jones <lee@kernel.org>, Arnd Bergmann <arnd@arndb.de>,
Gatien Chevallier <gatien.chevallier@foss.st.com>,
Marco Crivellari <marco.crivellari@suse.com>,
Fabrice Gasnier <fabrice.gasnier@foss.st.com>,
Andreas Kemnade <andreas@kemnade.info>,
Krzysztof Kozlowski <krzk@kernel.org>,
Charles Keepax <ckeepax@opensource.cirrus.com>,
Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] [v2] input: gpio-keys: make legacy gpiolib optional
Date: Mon, 27 Apr 2026 21:14:38 -0700 [thread overview]
Message-ID: <afAz-UQY0aCaThV3@google.com> (raw)
In-Reply-To: <20260427143406.3020992-1-arnd@kernel.org>
On Mon, Apr 27, 2026 at 04:33:49PM +0200, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> Most users of gpio-keys and gpio-keys-polled use modern gpiolib
> interfaces, but there are still number of ancient sh, arm32 and x86
> machines that have never been converted.
>
> Add an #ifdef block for the parts of the driver that are only used on
> those legacy machines.
>
> The two Rohm PMIC drivers use a gpio-keys device without an actual GPIO,
> passing an IRQ number instead. In order to keep this working both with
> and with CONFIG_GPIOLIB_LEGACY, change the gpio-keys driver to ignore
> the gpio number if an IRQ is passed.
>
> Link: https://lore.kernel.org/all/b3c94552-c104-42e3-be15-7e8362e8039e@gmail.com/
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> v2: skip the fake GPIO number passing from mfd
> ---
> drivers/input/keyboard/gpio_keys.c | 7 ++++---
> drivers/input/keyboard/gpio_keys_polled.c | 2 ++
> drivers/mfd/rohm-bd71828.c | 1 -
> drivers/mfd/rohm-bd718x7.c | 1 -
Let's see if my patches to rohm drivers will get accepted and then maybe
we can remove legacy gpio API from gpio-keys altogether.
Thanks.
--
Dmitry
next prev parent reply other threads:[~2026-04-28 4:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-27 14:33 [PATCH] [v2] input: gpio-keys: make legacy gpiolib optional Arnd Bergmann
2026-04-28 4:14 ` Dmitry Torokhov [this message]
2026-04-28 6:12 ` Arnd Bergmann
2026-04-29 19:12 ` Dmitry Torokhov
2026-04-29 6:25 ` Matti Vaittinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=afAz-UQY0aCaThV3@google.com \
--to=dmitry.torokhov@gmail.com \
--cc=andreas@kemnade.info \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=christophe.jaillet@wanadoo.fr \
--cc=ckeepax@opensource.cirrus.com \
--cc=fabrice.gasnier@foss.st.com \
--cc=gatien.chevallier@foss.st.com \
--cc=krzk@kernel.org \
--cc=lee@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marco.crivellari@suse.com \
--cc=mazziesaccount@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox