[PATCH v2] dt-bindings: mfd: qcom,tcsr: Add compatible for Nord

[PATCH v2] dt-bindings: mfd: qcom,tcsr: Add compatible for Nord

[Shawn Guo]

From: Deepti Jaggi <deepti.jaggi@oss.qualcomm.com>

Document Top Control and Status Register controller on Qualcomm Nord SoC
which is compatible with 'syscon'.

Signed-off-by: Deepti Jaggi <deepti.jaggi@oss.qualcomm.com>
Signed-off-by: Shawn Guo <shengchao.guo@oss.qualcomm.com>
---
Changes in v2:
 - Improve commit log to make the compatibility explicit
 - Link to v1: https://lore.kernel.org/all/20260420042124.1247995-1-shengchao.guo@oss.qualcomm.com/

 Documentation/devicetree/bindings/mfd/qcom,tcsr.yaml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/mfd/qcom,tcsr.yaml b/Documentation/devicetree/bindings/mfd/qcom,tcsr.yaml
index 14ae3f00ef7e..23317d1b381c 100644
--- a/Documentation/devicetree/bindings/mfd/qcom,tcsr.yaml
+++ b/Documentation/devicetree/bindings/mfd/qcom,tcsr.yaml
@@ -19,6 +19,7 @@ properties:
       - enum:
           - qcom,msm8976-tcsr
           - qcom,msm8998-tcsr
+          - qcom,nord-tcsr
           - qcom,qcm2290-tcsr
           - qcom,qcs404-tcsr
           - qcom,qcs615-tcsr
-- 
2.43.0

Re: [PATCH v2] dt-bindings: mfd: qcom,tcsr: Add compatible for Nord

[Krzysztof Kozlowski]

On Mon, Apr 27, 2026 at 09:21:16AM +0800, Shawn Guo wrote:
> From: Deepti Jaggi <deepti.jaggi@oss.qualcomm.com>
> 
> Document Top Control and Status Register controller on Qualcomm Nord SoC
> which is compatible with 'syscon'.

TCSR is not compatible with syscon, because there is no such device as
syscon. That's Linuxism. One device cannot be compatible with non-device
Linuxism.

Few other commits also are not helping - you keep repeating the binding,
that device is compatible with some other "compatible". But we
never asked for it. We asked to describe this hardware or say something
not visible in the diff - why you are using one or other fallback.

Best regards,
Krzysztof

Re: [PATCH v2] dt-bindings: mfd: qcom,tcsr: Add compatible for Nord

[Shawn Guo]

On Tue, Apr 28, 2026 at 08:18:37AM +0200, Krzysztof Kozlowski wrote:
> On Mon, Apr 27, 2026 at 09:21:16AM +0800, Shawn Guo wrote:
> > From: Deepti Jaggi <deepti.jaggi@oss.qualcomm.com>
> > 
> > Document Top Control and Status Register controller on Qualcomm Nord SoC
> > which is compatible with 'syscon'.
> 
> TCSR is not compatible with syscon, because there is no such device as
> syscon. That's Linuxism. One device cannot be compatible with non-device
> Linuxism.
> 
> Few other commits also are not helping - you keep repeating the binding,
> that device is compatible with some other "compatible". But we
> never asked for it.

Ok, I will just drop it.

Shawn