From: Breno Leitao <leitao@debian.org>
To: Tejun Heo <tj@kernel.org>
Cc: Lai Jiangshan <jiangshanlai@gmail.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>,
clm@fb.com, linux-kernel@vger.kernel.org, kernel-team@meta.com
Subject: Re: [PATCH] workqueue: fix devm_alloc_workqueue() va_list misuse
Date: Tue, 28 Apr 2026 08:00:27 -0700 [thread overview]
Message-ID: <afDLeuqvir4IyZrf@gmail.com> (raw)
In-Reply-To: <def0f1ab3576e806193401a021e7e4c2@kernel.org>
On Mon, Apr 27, 2026 at 07:29:31AM -1000, Tejun Heo wrote:
> Nice catch. Could you fold both noprof entries onto a shared helper?
>
> static struct workqueue_struct *
> alloc_workqueue_va(const char *fmt, unsigned int flags,
> int max_active, va_list args)
> {
> struct workqueue_struct *wq;
>
> wq = __alloc_workqueue(fmt, flags, max_active, args);
> if (wq)
> wq_init_lockdep(wq);
> return wq;
> }
>
> alloc_workqueue_lockdep_map() can stay on bare __alloc_workqueue() since
> it supplies its own lockdep_map.
Ack, I will update and respin.
Thanks for the review,
--breno
next prev parent reply other threads:[~2026-04-28 15:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-27 16:47 [PATCH] workqueue: fix devm_alloc_workqueue() va_list misuse Breno Leitao
2026-04-27 17:29 ` Tejun Heo
2026-04-28 15:00 ` Breno Leitao [this message]
2026-04-27 17:51 ` Andy Shevchenko
2026-04-28 14:59 ` Breno Leitao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=afDLeuqvir4IyZrf@gmail.com \
--to=leitao@debian.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=clm@fb.com \
--cc=jiangshanlai@gmail.com \
--cc=kernel-team@meta.com \
--cc=krzysztof.kozlowski@oss.qualcomm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox