[PATCH] media: vpif_capture: fix OF node reference imbalance

[PATCH] media: vpif_capture: fix OF node reference imbalance

[Johan Hovold]

The driver reuses the OF node of the parent device but fails to take
another reference to balance the one dropped by the platform bus code
when unbinding the parent and releasing the child devices.

Fix this by using the intended helper for reusing OF nodes.

Fixes: 4a5f8ae50b66 ("[media] davinci: vpif_capture: get subdevs from DT when available")
Cc: stable@vger.kernel.org	# 4.13
Cc: Kevin Hilman <khilman@baylibre.com>
Signed-off-by: Johan Hovold <johan@kernel.org>
---
 drivers/media/platform/ti/davinci/vpif_capture.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/media/platform/ti/davinci/vpif_capture.c b/drivers/media/platform/ti/davinci/vpif_capture.c
index 15df3ea2f77e..91cb6223561a 100644
--- a/drivers/media/platform/ti/davinci/vpif_capture.c
+++ b/drivers/media/platform/ti/davinci/vpif_capture.c
@@ -1498,7 +1498,7 @@ vpif_capture_get_pdata(struct platform_device *pdev,
 	 * video ports & endpoints data.
 	 */
 	if (pdev->dev.parent && pdev->dev.parent->of_node)
-		pdev->dev.of_node = pdev->dev.parent->of_node;
+		device_set_of_node_from_dev(&pdev->dev, pdev->dev.parent);
 	if (!IS_ENABLED(CONFIG_OF) || !pdev->dev.of_node)
 		return pdev->dev.platform_data;
 
-- 
2.52.0

Re: [PATCH] media: vpif_capture: fix OF node reference imbalance

[Johan Hovold]

On Tue, Apr 07, 2026 at 12:08:31PM +0200, Johan Hovold wrote:
> The driver reuses the OF node of the parent device but fails to take
> another reference to balance the one dropped by the platform bus code
> when unbinding the parent and releasing the child devices.
> 
> Fix this by using the intended helper for reusing OF nodes.
> 
> Fixes: 4a5f8ae50b66 ("[media] davinci: vpif_capture: get subdevs from DT when available")
> Cc: stable@vger.kernel.org	# 4.13
> Cc: Kevin Hilman <khilman@baylibre.com>
> Signed-off-by: Johan Hovold <johan@kernel.org>
> ---

Can this one be picked up now?

Also here there was some invalid complaint from the media CI bot so just
want to make sure it has not been silently rejected.

Johan